Page MenuHomePhabricator

openmp: Recognise ARMv7ve machine arch
ClosedPublic

Authored by raj.khem on Oct 5 2019, 3:05 PM.

Details

Summary

-march in clang when set to armv7ve emits ARM_ARCH_7VE internal
define and not ARM_ARCH_7A, hence the condition fails and openmp can
not be compiled, this makes sure that ARM_ARCH_7VE is taken into
consideration as KMP_ARCH_ARMV7 as well

Diff Detail

Event Timeline

raj.khem created this revision.Oct 5 2019, 3:05 PM
AndreyChurbanov accepted this revision.Nov 25 2019, 9:58 AM
AndreyChurbanov added a subscriber: AndreyChurbanov.

LGTM

I am not an ARM expert, but don't see any problems with checking extra define here.

This revision is now accepted and ready to land.Nov 25 2019, 9:58 AM

@AndreyChurbanov Can you push/commit this patch as well. As I dont have commit privs.

This revision was automatically updated to reflect the committed changes.