Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 38469 Build 38468: arc lint + arc unit
Event Timeline
Thanks for updating this! Pinging @sammccall since he is also working on writing some release docs, might be helpful to bring this to your attention.
| clang-tools-extra/docs/clangd/Installation.rst | ||
|---|---|---|
| 358–360 | I don't think it is necessary to mention the version. It could be better to directly start with Clangd builds an incremental index over files listed in the compilation database. | |
| 360 | instead of enables let's say improves ? | |
| 361 | drop the global | |
| 361–362 | let's mention it will only use your idle cores to build an index and total amount of cores it will use can be limited to X by passing -j=X to clangd | |
| 362–367 | that's not necessarily true, we also save at home directory, and I don't think it is relevant for installation. maybe rather drop it? | |
| 363 | s/canb/can | |
| 364 | instead of if it's disabled... Note that, disabling background-index will limit clangd's knowledge about your codebase to files you are currently editing. | |
| 370 | I don't think it is relevant for installation section again. But let's make the you probably don't need this a seperate line and make it bold or red ? | |
| clang-tools-extra/docs/clangd/Installation.rst | ||
|---|---|---|
| 362–367 | I think it is important to mention this. For most cases, .clangd/index is in in the project root, right? | |
address comments.
| clang-tools-extra/docs/clangd/Installation.rst | ||
|---|---|---|
| 364 | oops, I forgot this comment. | |
I don't think it is necessary to mention the version. It could be better to directly start with