Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Thanks for updating this! Pinging @sammccall since he is also working on writing some release docs, might be helpful to bring this to your attention.
| clang-tools-extra/docs/clangd/Installation.rst | ||
|---|---|---|
| 358 ↗ | (On Diff #217834) | I don't think it is necessary to mention the version. It could be better to directly start with Clangd builds an incremental index over files listed in the compilation database. |
| 360 ↗ | (On Diff #217834) | instead of enables let's say improves ? |
| 361 ↗ | (On Diff #217834) | drop the global |
| 362 ↗ | (On Diff #217834) | let's mention it will only use your idle cores to build an index and total amount of cores it will use can be limited to X by passing -j=X to clangd |
| 363 ↗ | (On Diff #217834) | that's not necessarily true, we also save at home directory, and I don't think it is relevant for installation. maybe rather drop it? |
| 364 ↗ | (On Diff #217834) | s/canb/can |
| 365 ↗ | (On Diff #217834) | instead of if it's disabled... Note that, disabling background-index will limit clangd's knowledge about your codebase to files you are currently editing. |
| 369 ↗ | (On Diff #217834) | I don't think it is relevant for installation section again. But let's make the you probably don't need this a seperate line and make it bold or red ? |
| clang-tools-extra/docs/clangd/Installation.rst | ||
|---|---|---|
| 363 ↗ | (On Diff #217834) | I think it is important to mention this. For most cases, .clangd/index is in in the project root, right? |
address comments.
| clang-tools-extra/docs/clangd/Installation.rst | ||
|---|---|---|
| 365 ↗ | (On Diff #217834) | oops, I forgot this comment. |
thanks, lgtm!
| clang-tools-extra/docs/clangd/Installation.rst | ||
|---|---|---|
| 364 ↗ | (On Diff #221523) | s/shareds/shards |