Details
- Reviewers
ilya-biryukov jkorous - Commits
- rG349ef2f2f9c2: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored…
rL370338: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored…
rCTE370338: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored…
rC370338: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored…
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 37431 Build 37430: arc lint + arc unit
Event Timeline
clang/include/clang/Index/IndexingAction.h | ||
---|---|---|
60 | Why not use default argument instead of overloading? |
clang/include/clang/Index/IndexingAction.h | ||
---|---|---|
60 | Writing a whole lambda in a default argument seemed to be a bit too much. I can change to a default argument if you think it is better. WDYT? |
clang/include/clang/Index/IndexingAction.h | ||
---|---|---|
60 | Seems like we do that in couple places (VisibleModuleSet::setVisible or FinishTemplateArgumentDeduction). Anyway, it's no big deal, I'm fine with either. |
cfe/trunk/include/clang/Index/IndexingAction.h | ||
---|---|---|
58 ↗ | (On Diff #217836) | I know ShouldSkipFunctionBody is important for multi-threaded indexing, but why is it a mandatory argument? There are lots of other overloads, are they good candidates for being mandatory arguments? |
Why not use default argument instead of overloading?