Correct order of fields and indirect fields in imported RecordDecl
is needed for correct work of record layout calculations.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 37494 Build 37493: arc lint + arc unit
Event Timeline
Comment Actions
Looks good, I just have a comment about the matcher.
clang/unittests/AST/ASTImporterTest.cpp | ||
---|---|---|
1437 | This name sounds strange for me, perhaps hasAnyKindOfFieldOrder ? |
This name sounds strange for me, perhaps hasAnyKindOfFieldOrder ?
Also, this matcher I think supersedes the hasFieldOrder, I mean in the tests where we use hasFieldOrder we could use this new matcher too, can't we? In that case, however, we can delete the old implementation.