This is an archive of the discontinued LLVM Phabricator instance.

Differential D66748

[PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*
ClosedPublic

Authored by jsji on Aug 26 2019, 8:42 AM.

Details

Reviewers
nemanjai
hfinkel
echristo
• wuzish
Group Reviewers
Restricted Project
Commits
rGa71c199f82cd: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*
rC370912: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*
rL370912: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*
Summary

This is follow up of https://reviews.llvm.org/D66699.
We might get ISEL ICE if we call vec_dss with non const 3rd arg.

Cannot select: intrinsic %llvm.ppc.altivec.dst

We should check the constraints in clang and generate better error
messages.

Diff Detail

Event Timeline

jsji created this revision.Aug 26 2019, 8:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2019, 8:42 AM
Herald added subscribers: cfe-commits, shchenz, MaskRay, kbarton. · View Herald Transcript
jsji added a reviewer: Restricted Project.Aug 26 2019, 8:43 AM
Herald added a subscriber: • wuzish. · View Herald TranscriptAug 26 2019, 8:43 AM
Harbormaster completed remote builds in B37299: Diff 217170.Aug 26 2019, 8:44 AM
jsji added a comment.Sep 2 2019, 8:20 AM

Ping..

jsji updated this revision to Diff 218485.Sep 3 2019, 10:33 AM

Add range check and tests.

Harbormaster completed remote builds in B37665: Diff 218485.Sep 3 2019, 10:34 AM
• wuzish accepted this revision.Sep 4 2019, 12:03 AM
This revision is now accepted and ready to land.Sep 4 2019, 12:03 AM
jsji updated this revision to Diff 218696.Sep 4 2019, 7:33 AM

Rebase to ToT.

Harbormaster completed remote builds in B37723: Diff 218696.Sep 4 2019, 7:37 AM
Closed by commit rL370912: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst* (authored by jsji). · Explain WhySep 4 2019, 8:22 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2019, 8:22 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
include/
clang/
Basic/
8 lines
test/
CodeGen/
8 lines

Diff 217170

clang/include/clang/Basic/BuiltinsPPC.def

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
BUILTIN(__builtin_altivec_vcfsx, "V4fV4iIi", "") BUILTIN(__builtin_altivec_vcfsx, "V4fV4iIi", "")
BUILTIN(__builtin_altivec_vcfux, "V4fV4iIi", "") BUILTIN(__builtin_altivec_vcfux, "V4fV4iIi", "")
BUILTIN(__builtin_altivec_vctsxs, "V4SiV4fIi", "") BUILTIN(__builtin_altivec_vctsxs, "V4SiV4fIi", "")
BUILTIN(__builtin_altivec_vctuxs, "V4UiV4fIi", "") BUILTIN(__builtin_altivec_vctuxs, "V4UiV4fIi", "")
BUILTIN(__builtin_altivec_dss, "vUi", "") BUILTIN(__builtin_altivec_dss, "vUi", "")
BUILTIN(__builtin_altivec_dssall, "v", "") BUILTIN(__builtin_altivec_dssall, "v", "")
BUILTIN(__builtin_altivec_dst, "vvC*iUi", "") BUILTIN(__builtin_altivec_dst, "vvC*iUIi", "")
BUILTIN(__builtin_altivec_dstt, "vvC*iUi", "") BUILTIN(__builtin_altivec_dstt, "vvC*iUIi", "")
BUILTIN(__builtin_altivec_dstst, "vvC*iUi", "") BUILTIN(__builtin_altivec_dstst, "vvC*iUIi", "")
BUILTIN(__builtin_altivec_dststt, "vvC*iUi", "") BUILTIN(__builtin_altivec_dststt, "vvC*iUIi", "")
BUILTIN(__builtin_altivec_vexptefp, "V4fV4f", "") BUILTIN(__builtin_altivec_vexptefp, "V4fV4f", "")
BUILTIN(__builtin_altivec_vrfim, "V4fV4f", "") BUILTIN(__builtin_altivec_vrfim, "V4fV4f", "")
BUILTIN(__builtin_altivec_lvx, "V4iivC*", "") BUILTIN(__builtin_altivec_lvx, "V4iivC*", "")
BUILTIN(__builtin_altivec_lvxl, "V4iivC*", "") BUILTIN(__builtin_altivec_lvxl, "V4iivC*", "")
BUILTIN(__builtin_altivec_lvebx, "V16civC*", "") BUILTIN(__builtin_altivec_lvebx, "V16civC*", "")
▲ Show 20 Lines • Show All 415 Lines • Show Last 20 Lines

clang/test/CodeGen/builtins-ppc-error.c

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
void testVCTUXS(int index) { void testVCTUXS(int index) {
vec_vctuxs(vf, index); //expected-error {{argument to '__builtin_altivec_vctuxs' must be a constant integer}} vec_vctuxs(vf, index); //expected-error {{argument to '__builtin_altivec_vctuxs' must be a constant integer}}
} }
void testUnpack128(int index) { void testUnpack128(int index) {
__builtin_unpack_vector_int128(vsllli, index); //expected-error {{argument to '__builtin_unpack_vector_int128' must be a constant integer}} __builtin_unpack_vector_int128(vsllli, index); //expected-error {{argument to '__builtin_unpack_vector_int128' must be a constant integer}}
__builtin_unpack_vector_int128(vsllli, 5); //expected-error {{argument value 5 is outside the valid range [0, 1]}} __builtin_unpack_vector_int128(vsllli, 5); //expected-error {{argument value 5 is outside the valid range [0, 1]}}
} }
void testDST(int index) {
vec_dst(&vsi, index, index); //expected-error {{argument to '__builtin_altivec_dst' must be a constant integer}}
vec_dstt(&vsi, index, index); //expected-error {{argument to '__builtin_altivec_dstt' must be a constant integer}}
vec_dstst(&vsi, index, index); //expected-error {{argument to '__builtin_altivec_dstst' must be a constant integer}}
vec_dststt(&vsi, index, index); //expected-error {{argument to '__builtin_altivec_dststt' must be a constant integer}}
}