This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*
ClosedPublic

Authored by jsji on Aug 26 2019, 8:42 AM.

Details

Summary

This is follow up of https://reviews.llvm.org/D66699.
We might get ISEL ICE if we call vec_dss with non const 3rd arg.

Cannot select: intrinsic %llvm.ppc.altivec.dst

We should check the constraints in clang and generate better error
messages.

Diff Detail

Repository
rL LLVM

Event Timeline

jsji created this revision.Aug 26 2019, 8:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2019, 8:42 AM
jsji added a reviewer: Restricted Project.Aug 26 2019, 8:43 AM
jsji updated this revision to Diff 218485.Sep 3 2019, 10:33 AM

Add range check and tests.

wuzish accepted this revision.Sep 4 2019, 12:03 AM
This revision is now accepted and ready to land.Sep 4 2019, 12:03 AM
jsji updated this revision to Diff 218696.Sep 4 2019, 7:33 AM

Rebase to ToT.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2019, 8:22 AM