test/llvm-objcopy/ELF/error-format.test is similar to test/llvm-readobj/error-format.test added in D66425.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM.
test/tools/llvm-objcopy/ELF/error-format.test | ||
---|---|---|
18 ↗ | (On Diff #216146) | Seems not important at all, but EM_RISCV? I'd use something more common instead, probably. |
test/tools/llvm-objcopy/ELF/error-format.test | ||
---|---|---|
9 ↗ | (On Diff #216146) | Maybe worth a comment saying why you don't test llvm-objcopy too? |
test/tools/llvm-objcopy/ELF/error-format.test | ||
---|---|---|
18 ↗ | (On Diff #216146) | I think this is probably not important... It just adds some variety for unimportant fields.. |
test/tools/llvm-objcopy/ELF/error-format.test | ||
---|---|---|
18 ↗ | (On Diff #216146) | OK, I have no strong opinion about this (just EM_RISCV made me wonder why it was used, but it is fine generally). |