This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy][test] Add a test to show that argv[0] is included in error/warning messages
ClosedPublic

Authored by MaskRay on Aug 20 2019, 7:43 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Aug 20 2019, 7:43 AM
grimar accepted this revision.Aug 20 2019, 7:51 AM

LGTM.

test/tools/llvm-objcopy/ELF/error-format.test
18 ↗(On Diff #216146)

Seems not important at all, but EM_RISCV? I'd use something more common instead, probably.

This revision is now accepted and ready to land.Aug 20 2019, 7:51 AM
jhenderson added inline comments.Aug 20 2019, 7:52 AM
test/tools/llvm-objcopy/ELF/error-format.test
9 ↗(On Diff #216146)

Maybe worth a comment saying why you don't test llvm-objcopy too?

MaskRay updated this revision to Diff 216151.Aug 20 2019, 8:01 AM

+ ## Currently llvm-objcopy does not issue warnings, so it is not tested.

MaskRay marked 2 inline comments as done.Aug 20 2019, 8:02 AM
MaskRay added inline comments.
test/tools/llvm-objcopy/ELF/error-format.test
18 ↗(On Diff #216146)

I think this is probably not important... It just adds some variety for unimportant fields..

grimar added inline comments.Aug 20 2019, 8:12 AM
test/tools/llvm-objcopy/ELF/error-format.test
18 ↗(On Diff #216146)

OK, I have no strong opinion about this (just EM_RISCV made me wonder why it was used, but it is fine generally).

This revision was automatically updated to reflect the committed changes.