Page MenuHomePhabricator

Remove minimum toolchain soft-error
ClosedPublic

Authored by jfb on Aug 13 2019, 4:46 PM.

Details

Summary

Back in January I changed the minimum toolchain version required to build clang and LLVM: D57264. Since then we've release LLVM 8, following our process it's therefore now a good time to remove the soft-error and officially deprecate older toolchains. I tried this out last Tursday night to see if any bots complained, and I saw no complaints. I also manually audited bots and didn't see any bot that should break, but their toolchain information is unreliable and some bots are offline.

Once this patch stick we'll move to C++14 as we've already agreed.

Diff Detail

Repository
rL LLVM

Event Timeline

jfb created this revision.Aug 13 2019, 4:46 PM
jfb edited the summary of this revision. (Show Details)Aug 13 2019, 4:47 PM
jfb added subscribers: jyknight, lhames.
chandlerc accepted this revision.Aug 13 2019, 5:07 PM

LGTM.

We should specifically call this out in release notes as well (before we forget) as a bunch of downstream people will discover it in LLVM 10.

This revision is now accepted and ready to land.Aug 13 2019, 5:07 PM
This revision was automatically updated to reflect the committed changes.