Page MenuHomePhabricator

[ARM] Select VFMA
ClosedPublic

Authored by samtebbs on Aug 6 2019, 8:00 AM.

Details

Summary

This patch adds patterns to select the MVE instructions VFMA.f16 and VFMA.f32.

Diff Detail

Event Timeline

samtebbs created this revision.Aug 6 2019, 8:00 AM

Remember to upload with context! It makes the reviews easier to read.

llvm/lib/Target/ARM/ARMInstrMVE.td
2604

I think this is near VADD? Do you mind moving it up to near VFMA, to keep things together.

2606

Also I think it's better to use MQPR, over QPR

llvm/test/CodeGen/ARM/vfma.ll
2 ↗(On Diff #213613)

Can you move this test to test/CodeGen/Thumb2/mve-vfma.ll? Just to be with the others

24 ↗(On Diff #213613)

These lines can go, as a little bit of a cleanup.

25 ↗(On Diff #213613)

As can the #1 on the end of these.

samtebbs updated this revision to Diff 213870.Aug 7 2019, 6:51 AM
samtebbs marked 5 inline comments as done.
samtebbs edited the summary of this revision. (Show Details)
dmgreen accepted this revision.Aug 7 2019, 1:14 PM

Nice one. LGTM

This revision is now accepted and ready to land.Aug 7 2019, 1:14 PM