Page MenuHomePhabricator

AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo
Needs ReviewPublic

Authored by tstellar on Jul 30 2019, 8:46 PM.

Details

Summary

This is a refactoring that will make future improvements to this pass easier.
This change should not change the behavior of the pass.

Event Timeline

tstellar created this revision.Jul 30 2019, 8:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 8:46 PM
vpykhtin accepted this revision.Aug 1 2019, 8:11 AM

LGTM, with tips :)

llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
634

This can be a member of CombineInfo, or even a constructor of it.

651

This can be a member of CombineInfo

This revision is now accepted and ready to land.Aug 1 2019, 8:11 AM
tstellar marked an inline comment as done.Aug 1 2019, 9:05 AM
tstellar added inline comments.
llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
634

The reason I didn't do it this way originally was because I would also need to pass in TTI and STI to the function or to the constructor for CombineInfo, but I don't mind turning it into a member function.

tstellar marked an inline comment as not done.Aug 5 2019, 8:32 AM
tstellar updated this revision to Diff 214012.Aug 7 2019, 2:59 PM

Make helper function members of CombineInfo class.

tstellar requested review of this revision.Wed, Sep 18, 8:56 PM

Ping.