Page MenuHomePhabricator

[clang] Revert "Remove __VERSION__"
ClosedPublic

Authored by saugustine on Jul 12 2019, 7:44 PM.

Details

Summary

This reverts commit 632a36bfcfc8273c1861f04ff6758d863c47c784.

Some targets such as Python 2.7.16 still use VERSION in
their builds. Without VERSION defined, the source code
has syntax errors.

Diff Detail

Event Timeline

saugustine created this revision.Jul 12 2019, 7:44 PM
lebedev.ri retitled this revision from Revert "Remove __VERSION__" to [clang] Revert "Remove __VERSION__".Jul 12 2019, 11:07 PM
lebedev.ri added a subscriber: cfe-commits.
sylvestre.ledru accepted this revision.Jul 12 2019, 11:28 PM

I went ahead and committed your revert in r365992. Thanks!

Next time, please remove the clang/ from your patch
arc could not apply it:

Committing 'D64687: [clang] Revert "Remove __VERSION__"'...
Revision includes changes to paths that do not exist:

    clang/docs/LanguageExtensions.rst
This revision is now accepted and ready to land.Jul 12 2019, 11:28 PM
MaskRay closed this revision.Jul 13 2019, 12:40 AM
MaskRay added a subscriber: MaskRay.

I went ahead and committed your revert in r365992. Thanks!

Next time, please remove the clang/ from your patch
arc could not apply it:

I think clang/ is there just because the patch was created from the llvm-project repository (mono-repo), not the clang repository (multi-repo)