This is an archive of the discontinued LLVM Phabricator instance.

Differential D64684

ELF: Simplify test. NFCI.
ClosedPublic

Authored by pcc on Jul 12 2019, 6:39 PM.

Details

Reviewers
ruiu
peter.smith
grimar
• espindola
Commits
rG311131dafc0e: ELF: Simplify test. NFCI.
rL366463: ELF: Simplify test. NFCI.
rLLD366463: ELF: Simplify test. NFCI.
Summary

Avoid splitting the test into multiple files and use zero for the value of
the symbol with addends at relocations so that it's clear what value is
being used at relocations.

Diff Detail

Event Timeline

pcc created this revision.Jul 12 2019, 6:39 PM
Herald added a reviewer: • espindola. · View Herald TranscriptJul 12 2019, 6:39 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: MaskRay, arichardson, javed.absar, emaste. · View Herald Transcript
Harbormaster completed remote builds in B34938: Diff 209661.Jul 12 2019, 6:40 PM
pcc added a child revision: D64685: ELF: Add support for remaining R_AARCH64_MOVW* relocations..Jul 12 2019, 6:40 PM
ruiu accepted this revision.Jul 16 2019, 2:49 AM

LGTM

This revision is now accepted and ready to land.Jul 16 2019, 2:49 AM
Closed by commit rL366463: ELF: Simplify test. NFCI. (authored by pcc). · Explain WhyJul 18 2019, 9:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
test/
ELF/
Inputs/
12 lines

Diff 209661

lld/test/ELF/Inputs/uabs_label.s

  • This file was deleted.
# Sample label to test R_AARCH64_MOVW_UABS relocations
.globl uabs_label
uabs_label = 0xF000E000D000C

lld/test/ELF/aarch64-relocs.s

# REQUIRES: aarch64 # REQUIRES: aarch64
# RUN: llvm-mc -filetype=obj -triple=aarch64-unknown-freebsd %s -o %t # RUN: llvm-mc -filetype=obj -triple=aarch64-unknown-freebsd %s -o %t
# RUN: llvm-mc -filetype=obj -triple=aarch64-unknown-freebsd %p/Inputs/uabs_label.s -o %t2.o # RUN: echo '.globl zero; zero = 0' | llvm-mc -filetype=obj -triple=aarch64-unknown-freebsd -o %t2.o
# RUN: ld.lld %t %t2.o -o %t2 # RUN: ld.lld %t %t2.o -o %t2
# RUN: llvm-objdump -d %t2 | FileCheck %s # RUN: llvm-objdump -d %t2 | FileCheck %s
.section .R_AARCH64_ADR_PREL_LO21,"ax",@progbits .section .R_AARCH64_ADR_PREL_LO21,"ax",@progbits
.globl _start .globl _start
_start: _start:
adr x1,msg adr x1,msg
msg: .asciz "Hello, world\n" msg: .asciz "Hello, world\n"
▲ Show 20 Lines • Show All 152 Lines • ▼ Show 20 Lines
# CHECK-EMPTY: # CHECK-EMPTY:
# CHECK-NEXT: ldst16: # CHECK-NEXT: ldst16:
# CHECK-NEXT: 210054: 71 c2 40 7d ldr h17, [x19, #96] # CHECK-NEXT: 210054: 71 c2 40 7d ldr h17, [x19, #96]
# CHECK-NEXT: 210058: 61 c2 40 79 ldrh w1, [x19, #96] # CHECK-NEXT: 210058: 61 c2 40 79 ldrh w1, [x19, #96]
# CHECK-NEXT: 21005c: 62 c6 40 79 ldrh w2, [x19, #98] # CHECK-NEXT: 21005c: 62 c6 40 79 ldrh w2, [x19, #98]
.section .R_AARCH64_MOVW_UABS,"ax",@progbits .section .R_AARCH64_MOVW_UABS,"ax",@progbits
movz1: movz1:
movk x12, #:abs_g0_nc:uabs_label movk x12, #:abs_g0_nc:zero+0xF000E000D000C
movk x13, #:abs_g1_nc:uabs_label movk x13, #:abs_g1_nc:zero+0xF000E000D000C
movk x14, #:abs_g2_nc:uabs_label movk x14, #:abs_g2_nc:zero+0xF000E000D000C
movz x15, #:abs_g3:uabs_label movz x15, #:abs_g3:zero+0xF000E000D000C
movk x16, #:abs_g3:uabs_label movk x16, #:abs_g3:zero+0xF000E000D000C
## 4222124650659840 == (0xF << 48) ## 4222124650659840 == (0xF << 48)
# CHECK: Disassembly of section .R_AARCH64_MOVW_UABS: # CHECK: Disassembly of section .R_AARCH64_MOVW_UABS:
# CHECK-EMPTY: # CHECK-EMPTY:
# CHECK-NEXT: movz1: # CHECK-NEXT: movz1:
# CHECK-NEXT: 8c 01 80 f2 movk x12, #12 # CHECK-NEXT: 8c 01 80 f2 movk x12, #12
# CHECK-NEXT: ad 01 a0 f2 movk x13, #13, lsl #16 # CHECK-NEXT: ad 01 a0 f2 movk x13, #13, lsl #16
# CHECK-NEXT: ce 01 c0 f2 movk x14, #14, lsl #32 # CHECK-NEXT: ce 01 c0 f2 movk x14, #14, lsl #32
# CHECK-NEXT: ef 01 e0 d2 mov x15, #4222124650659840 # CHECK-NEXT: ef 01 e0 d2 mov x15, #4222124650659840
# CHECK-NEXT: f0 01 e0 f2 movk x16, #15, lsl #48 # CHECK-NEXT: f0 01 e0 f2 movk x16, #15, lsl #48