Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

isBytewiseValue checks ConstantVector element by element
ClosedPublic
Actions

Authored by vitalybuka on Jul 1 2019, 1:18 PM.

Details

Reviewers

eugenis
pcc
jfb

Commits

rGb1bff76e22bd: isBytewiseValue checks ConstantVector element by element
rL365971: isBytewiseValue checks ConstantVector element by element

Summary

Vector of the same value with few undefs will sill be considered "Bytewise"

Diff Detail

Repository: rL LLVM

Event Timeline

vitalybuka created this revision.Jul 1 2019, 1:18 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 1:18 PM

Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript

Harbormaster completed remote builds in B34152: Diff 207396.Jul 1 2019, 1:19 PM

vitalybuka added a parent revision: D63967: Handle IntToPtr in isBytewiseValue.Jul 1 2019, 1:25 PM

vitalybuka retitled this revision from isBytewiseValue check ConstantVector element by element to isBytewiseValue checks ConstantVector element by element.

vitalybuka edited the summary of this revision. (Show Details)

vitalybuka added reviewers: eugenis, pcc.

vitalybuka added a child revision: D64052: Return Undef from isBytewiseValue for empty arrays or structs.Jul 1 2019, 6:07 PM

This seems correct. Any idea why it has not been done this way from the start?

In D64031#1581498, @eugenis wrote:

This seems correct. Any idea why it has not been done this way from the start?

vitalybuka added a reviewer: jfb.Jul 12 2019, 10:31 AM

Herald added a subscriber: dexonsmith. · View Herald TranscriptJul 12 2019, 10:31 AM

vitalybuka mentioned this in D51751: Merge clang's isRepeatedBytePattern with LLVM's isBytewiseValue.Jul 12 2019, 10:32 AM

jfb accepted this revision.Jul 12 2019, 10:37 AM

This revision is now accepted and ready to land.Jul 12 2019, 10:37 AM

Closed by commit rL365971: isBytewiseValue checks ConstantVector element by element (authored by vitalybuka). · Explain WhyJul 12 2019, 3:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

lib/

Analysis/

ValueTracking.cpp

7 lines

unittests/

Analysis/

ValueTrackingTest.cpp

2 lines

Diff 209623

View Options

llvm/trunk/lib/Analysis/ValueTracking.cpp