Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D64052

Return Undef from isBytewiseValue for empty arrays or structs
ClosedPublic
Actions

Authored by vitalybuka on Jul 1 2019, 6:06 PM.

Details

Reviewers
pcc
eugenis
efriedma
Commits
rG52096ee9a96e: Return Undef from isBytewiseValue for empty arrays or structs
rL365864: Return Undef from isBytewiseValue for empty arrays or structs

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka created this revision.Jul 1 2019, 6:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 6:06 PM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
vitalybuka added a parent revision: D64031: isBytewiseValue checks ConstantVector element by element.Jul 1 2019, 6:07 PM
Harbormaster completed remote builds in B34171: Diff 207449.Jul 1 2019, 6:07 PM
efriedma added a subscriber: efriedma.Jul 2 2019, 1:53 PM
efriedma added inline comments.
llvm/lib/Analysis/ValueTracking.cpp
3187 ↗(On Diff #207449)

Does this work recursively? For example, [5 x [0 x i32]]. It might be easier to just check the size of the type.

Actually, we should probably constant-fold [0 x i8] zeroinitializer etc., to [0 x i8] undef, since there isn't any actual data anyway. That would make this check unnecessary.

vitalybuka added a child revision: D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.Jul 2 2019, 4:17 PM
vitalybuka updated this revision to Diff 207664.Jul 2 2019, 5:15 PM

Use size instead of getNumElements

Harbormaster completed remote builds in B34231: Diff 207664.Jul 2 2019, 5:17 PM
vitalybuka marked 2 inline comments as done.Jul 2 2019, 5:21 PM
vitalybuka added inline comments.
llvm/lib/Analysis/ValueTracking.cpp
3187 ↗(On Diff #207449)

Yep, recursive did not work and size looks simpler.

eugenis added a comment.Jul 11 2019, 2:08 PM

This is not a lot of code, so LGTM, but I agree that constant folding would be even better.

efriedma accepted this revision.Jul 11 2019, 4:38 PM

LGTM

This revision is now accepted and ready to land.Jul 11 2019, 4:38 PM
Closed by commit rL365864: Return Undef from isBytewiseValue for empty arrays or structs (authored by vitalybuka). · Explain WhyJul 11 2019, 7:23 PM
This revision was automatically updated to reflect the committed changes.
vitalybuka marked an inline comment as done.
vitalybuka added a child revision: D64675: WIP: Disable optimization in emitStoresForConstant.Jul 12 2019, 4:22 PM
vitalybuka removed a child revision: D64675: WIP: Disable optimization in emitStoresForConstant.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
Analysis/
4 lines
unittests/
Analysis/
8 lines

Diff 209403

View Options

llvm/trunk/lib/Analysis/ValueTracking.cpp

Loading...
View Options

llvm/trunk/unittests/Analysis/ValueTrackingTest.cpp

Loading...