Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D63940

NFC: Pass DataLayout into isBytewiseValue
ClosedPublic
Actions

Authored by vitalybuka on Jun 28 2019, 10:22 AM.

Details

Reviewers
eugenis
pcc
Commits
rGd03bd1db5949: NFC: Pass DataLayout into isBytewiseValue
rL365709: NFC: Pass DataLayout into isBytewiseValue
rC365709: NFC: Pass DataLayout into isBytewiseValue
Summary

We will need to handle IntToPtr which I will submit in a separate patch as it's
not going to be NFC.

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka created this revision.Jun 28 2019, 10:22 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 28 2019, 10:22 AM
Herald added subscribers: llvm-commits, cfe-commits, hiraditya. · View Herald Transcript
vitalybuka added a parent revision: D63854: NFC: Convert large lambda into method.Jun 28 2019, 10:22 AM
Harbormaster completed remote builds in B34076: Diff 207092.Jun 28 2019, 10:23 AM
vitalybuka added a child revision: D63966: Add IsBytewiseValue unit test.Jun 28 2019, 5:12 PM
vitalybuka added reviewers: eugenis, pcc.Jun 28 2019, 5:21 PM
eugenis accepted this revision.Jul 10 2019, 2:26 PM

LGTM

This revision is now accepted and ready to land.Jul 10 2019, 2:26 PM
vitalybuka retitled this revision from [NFC] Pass DataLayout into isBytewiseValue to NFC: Pass DataLayout into isBytewiseValue.Jul 10 2019, 3:49 PM
Closed by commit rL365709: NFC: Pass DataLayout into isBytewiseValue (authored by vitalybuka). · Explain WhyJul 10 2019, 3:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cfe/
trunk/
lib/
CodeGen/
8 lines
llvm/
trunk/
include/
llvm/
Analysis/
2 lines
lib/
Analysis/
11 lines
Transforms/
Scalar/
8 lines
7 lines

Diff 209086

View Options

cfe/trunk/lib/CodeGen/CGDecl.cpp

Loading...
View Options

llvm/trunk/include/llvm/Analysis/ValueTracking.h

Loading...
View Options

llvm/trunk/lib/Analysis/ValueTracking.cpp

Loading...
View Options

llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp

Loading...
View Options

llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp

Loading...