[NewGVN] Add unary FNeg support to NewGVN pass

[fhahn]

LGTM, thanks.

llvm/test/Transforms/NewGVN/fpmath.ll

46 ↗

(On Diff #207065)

Can you update the test to check !1 points to the expected metadata?

[cameron.mcinally]

llvm/test/Transforms/NewGVN/fpmath.ll

46 ↗

(On Diff #207065)

Sorry, missed this comment. Will submit a follow-up patch ASAP.

[cameron.mcinally]

llvm/test/Transforms/NewGVN/fpmath.ll

46 ↗

(On Diff #207065)

Actually, I'm not sure how to do that well. Would you point me to an example, please?

The metadata string is at the end of the file. I could check for it at the very end of all the tests. Is that what you're suggesting?

If I check the metadata in this particular test, that would prevent new tests from being added after this test, since it would throw off the CHECK line order.

[fhahn]

llvm/test/Transforms/NewGVN/fpmath.ll

46 ↗

(On Diff #207065)

I think the most robust thing is to check it at the end of the file.

Ideally you would use a regex to match the ID in the CHECK lines for the operations and then check the value of the metadata at the bottom.

[cameron.mcinally]

llvm/test/Transforms/NewGVN/fpmath.ll

46 ↗

(On Diff #207065)

Submitted:

Author: mcinally
Date: Fri Jun 28 14:39:08 2019
New Revision: 364685

Just give me a heads up if you had something different in mind...

llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp

else if (isa<Argument>(V) || isa<GlobalVariable>(V)) {
     case Instruction::BitCast:
     case Instruction::AddrSpaceCast:
       E = createExpression(I);
       break;
     case Instruction::ICmp:
     case Instruction::FCmp:
       E = performSymbolicCmpEvaluation(I);
       break;
+    case Instruction::FNeg:
     case Instruction::Add:
     case Instruction::FAdd:
     case Instruction::Sub:
     case Instruction::FSub:
     case Instruction::Mul:
     case Instruction::FMul:
     case Instruction::UDiv:
     case Instruction::SDiv:

llvm/trunk/test/Transforms/NewGVN/fpmath.ll

; CHECK: %foo = fadd double %add1, %add1
   %add1 = fadd double %x, %y, !fpmath !0
   %add2 = fadd double %x, %y, !fpmath !1
   %foo = fadd double %add1, %add2
   ret double %foo
 }
 
 define double @test5(double %x) {
 ; CHECK: @test5(double %x)
-; CHECK: %neg1 = fneg double %x, !fpmath !0
-; CHECK: %neg2 = fneg double %x, !fpmath !1
-; CHECK: %foo = fadd double %neg1, %neg2
+; CHECK: %neg1 = fneg double %x, !fpmath !1
+; CHECK: %foo = fadd double %neg1, %neg1
   %neg1 = fneg double %x, !fpmath !0
   %neg2 = fneg double %x, !fpmath !1
   %foo = fadd double %neg1, %neg2
   ret double %foo
 }
 
 !0 = !{ float 5.0 }
 !1 = !{ float 2.5 }