Prazek (Piotr Padlewski)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2015, 5:19 PM (121 w, 6 d)

Recent Activity

Thu, Nov 16

Prazek accepted D40062: Update tests for llvm.invariant.group.barrier becoming mangled.

LGTM

Thu, Nov 16, 4:24 AM
Prazek accepted D39973: Let llvm.invariant.group.barrier accepts pointer to any address space.

LGTM

Thu, Nov 16, 4:24 AM

Tue, Nov 14

Prazek added a comment to D39973: Let llvm.invariant.group.barrier accepts pointer to any address space.

Firstly, are you sure that the invariant.group.barrier is the problem here? I didn't hear that it is used anywhere besides devirtualization, that is not turned on by default.
Here is my old path that was never reviewed:
https://reviews.llvm.org/D32673

Tue, Nov 14, 3:15 AM

Sep 14 2017

Prazek added a comment to D33852: Enable __declspec(selectany) on linux.

Thanks for help. I checked and docs build and looks legit. Sorry that it took so long.

Sep 14 2017, 10:35 AM
Prazek committed rL313278: Enable __declspec(selectany) on any platform.
Enable __declspec(selectany) on any platform
Sep 14 2017, 10:34 AM
Prazek closed D33852: Enable __declspec(selectany) on linux by committing rL313278: Enable __declspec(selectany) on any platform.
Sep 14 2017, 10:34 AM
Prazek updated the diff for D33852: Enable __declspec(selectany) on linux.

Fixed links

Sep 14 2017, 10:32 AM

Sep 5 2017

Prazek added inline comments to D33852: Enable __declspec(selectany) on linux.
Sep 5 2017, 2:21 PM

Aug 31 2017

Prazek added inline comments to D33852: Enable __declspec(selectany) on linux.
Aug 31 2017, 10:13 PM
Prazek updated the diff for D33852: Enable __declspec(selectany) on linux.
  • docs fixes
Aug 31 2017, 10:13 PM

Aug 30 2017

Prazek updated the diff for D33852: Enable __declspec(selectany) on linux.
  • docs fixes
Aug 30 2017, 11:01 PM
Prazek updated the diff for D33852: Enable __declspec(selectany) on linux.
  • docs fixes
Aug 30 2017, 10:57 PM
Prazek added inline comments to D33852: Enable __declspec(selectany) on linux.
Aug 30 2017, 10:56 AM

Aug 29 2017

Prazek updated the diff for D33852: Enable __declspec(selectany) on linux.
  • Add documentation
Aug 29 2017, 7:17 PM
Prazek added a comment to D33852: Enable __declspec(selectany) on linux.

Sorry for so late fixes, but it would be good to put it in 5.0

I do not think this should be in 5.0, as I believe we're only accepting regression fixes at this point.

This is a regression. __declspec(selectany) works completely fine on linux with 4.0. Without it clang-5.0 will be useless for any major windows project compiled on linux.

edit:
here is a regression: https://reviews.llvm.org/D32083

This is also adding new functionality that has had zero testing because it removes *all* target-specific checking for the attribute. Under the previous functionality (changed in D32083), this still required some mention of microsoft something (it went from requiring microsoft extensions to be enabled to instead require a Windows target) -- that's been entirely removed from this patch so now you can use this attribute for all target architectures, so it's not purely fixing a regression. Given how late we are in the release cycle, I am uncomfortable with this going in to 5.0, but I'd have no problems letting it bake for a bit and putting it into 5.1 (or 5.0.1, however we're naming bug releases these days).

Aug 29 2017, 7:13 PM

Aug 28 2017

Prazek added a comment to D33852: Enable __declspec(selectany) on linux.

Sorry for so late fixes, but it would be good to put it in 5.0

I do not think this should be in 5.0, as I believe we're only accepting regression fixes at this point.

Aug 28 2017, 9:35 AM

Aug 26 2017

Prazek updated the diff for D33852: Enable __declspec(selectany) on linux.

remove empty line

Aug 26 2017, 11:19 PM
Prazek updated the diff for D33852: Enable __declspec(selectany) on linux.

Enable it on every platform

Aug 26 2017, 11:19 PM
Prazek added a comment to D33852: Enable __declspec(selectany) on linux.

Sorry for so late fixes, but it would be good to put it in 5.0

Aug 26 2017, 11:17 PM

Jul 19 2017

Prazek added inline comments to D33852: Enable __declspec(selectany) on linux.
Jul 19 2017, 9:05 PM

Jun 27 2017

Prazek updated the diff for D33470: [clang-tidy] Add misc-default-numerics.

fixed broken test

Jun 27 2017, 3:53 PM · Restricted Project
Prazek updated the diff for D33470: [clang-tidy] Add misc-default-numerics.

Small fix

Jun 27 2017, 3:43 PM · Restricted Project
Prazek updated the diff for D33470: [clang-tidy] Add misc-default-numerics.
  • fixed docs
  • fixes
  • Last fixes?
Jun 27 2017, 3:04 PM · Restricted Project
Prazek added a comment to D33470: [clang-tidy] Add misc-default-numerics.

Once you fix the typo in the check, can you run it over some large C++ code bases to see if it finds any results?

I tried it on LLVM code base (after fixing bug with the numeric_limits name) and it didn't find anything suspisious.
Unfortunatelly I don't have enough time to try it on different codebases, but I am weiling to fix any bug with this check if it would happen in the future.
The release 5.0 is near, so I would like to push it upstream. Does it sound good to you?

My concern is: does this find any actual issues in real world code? This seems like such a highly specific check -- not many people use numeric_limits in the first place, let alone on non-builtin types, so does it justify running this check when someone batch-includes all of the misc checks?

I don't think this check is going to trigger a ton of false positives. I am wondering more the opposite: will this check ever trigger on anything other than compiler test cases?

Jun 27 2017, 2:55 PM · Restricted Project

Jun 24 2017

Prazek added a comment to D33470: [clang-tidy] Add misc-default-numerics.

Once you fix the typo in the check, can you run it over some large C++ code bases to see if it finds any results?

Jun 24 2017, 3:12 AM · Restricted Project
Prazek updated the diff for D33470: [clang-tidy] Add misc-default-numerics.
  • fixed docs
  • fixes
Jun 24 2017, 3:09 AM · Restricted Project
Prazek abandoned D27806: [clang-tidy] Add obvious-invalid-range.
Jun 24 2017, 2:59 AM
Prazek abandoned D27815: [clang-tidy] Add obvious module for obvious bugs.
Jun 24 2017, 2:59 AM

Jun 13 2017

Prazek updated the diff for D33889: Mark intrinsics as norecurse.
  • fixes
Jun 13 2017, 11:19 AM
Prazek added a comment to D32006: Mark invariant.group.barrier as inaccessiblememonly.

friendly ping 3

Jun 13 2017, 4:15 AM
Prazek added inline comments to D33852: Enable __declspec(selectany) on linux.
Jun 13 2017, 4:14 AM

Jun 6 2017

Prazek added a comment to D32006: Mark invariant.group.barrier as inaccessiblememonly.

friendly ping2

Jun 6 2017, 8:42 AM
Prazek added a comment to D32673: [CaptureTracking] Handle capturing of invariant.group.barrier.

friendly ping

Jun 6 2017, 8:42 AM

Jun 5 2017

Prazek added inline comments to D33889: Mark intrinsics as norecurse.
Jun 5 2017, 9:39 AM
Prazek added inline comments to D33852: Enable __declspec(selectany) on linux.
Jun 5 2017, 9:25 AM
Prazek created D33889: Mark intrinsics as norecurse.
Jun 5 2017, 4:32 AM

Jun 4 2017

Prazek added a comment to D33852: Enable __declspec(selectany) on linux.

I fired bug about the crash: https://bugs.llvm.org/show_bug.cgi?id=33300

Jun 4 2017, 6:42 AM
Prazek updated the diff for D33852: Enable __declspec(selectany) on linux.
  • Fixes
Jun 4 2017, 6:31 AM

Jun 3 2017

Prazek added a comment to D33852: Enable __declspec(selectany) on linux.

It seems that this is separate issue - we don't generate comdat for MachO. Indeed we should warn on not supported declspec for macho.

Jun 3 2017, 2:41 PM

Jun 2 2017

Prazek added a comment to D33852: Enable __declspec(selectany) on linux.

OK, I will try to make it work on linux and windows only

Jun 2 2017, 4:40 PM
Prazek added a comment to D33841: [clang-tidy] redundant keyword check.

extern on function definition is also redundant, right?

Jun 2 2017, 4:34 PM · Restricted Project
Prazek added a comment to D33841: [clang-tidy] redundant keyword check.

Feature request: removing "void" from int main(void)

Jun 2 2017, 4:31 PM · Restricted Project
Prazek retitled D33852: Enable __declspec(selectany) on linux from Enable __declspec(selectany) on linux) to Enable __declspec(selectany) on linux.
Jun 2 2017, 3:06 PM
Prazek created D33852: Enable __declspec(selectany) on linux.
Jun 2 2017, 2:58 PM
Prazek removed a reviewer for D33829: [clang-tidy] avoid reserved names check: Prazek.
Jun 2 2017, 10:41 AM · Restricted Project

Jun 1 2017

Prazek committed rL304455: Fixed broken test (strict-vtable-pointers).
Fixed broken test (strict-vtable-pointers)
Jun 1 2017, 12:08 PM
Prazek committed rL304448: Emit invariant.group.barrier when using union field.
Emit invariant.group.barrier when using union field
Jun 1 2017, 11:40 AM
Prazek closed D31830: Emit invariant.group.barrier when using union field by committing rL304448: Emit invariant.group.barrier when using union field.
Jun 1 2017, 11:39 AM
Prazek committed rL304397: Fixed warnings.
Fixed warnings
Jun 1 2017, 2:25 AM
Prazek updated the diff for D31830: Emit invariant.group.barrier when using union field.

Extra test

Jun 1 2017, 1:35 AM
Prazek committed rL304394: Emit available_externally vtables opportunistically.
Emit available_externally vtables opportunistically
Jun 1 2017, 1:04 AM
Prazek closed D33437: Emit available_externally vtables opportunistically by committing rL304394: Emit available_externally vtables opportunistically.
Jun 1 2017, 1:04 AM

May 29 2017

Prazek updated the diff for D33437: Emit available_externally vtables opportunistically.

changed assert

May 29 2017, 2:28 PM
Prazek updated the diff for D33437: Emit available_externally vtables opportunistically.
  • Final changes
May 29 2017, 10:51 AM
Prazek added inline comments to D33437: Emit available_externally vtables opportunistically.
May 29 2017, 10:51 AM
Prazek added a comment to D32006: Mark invariant.group.barrier as inaccessiblememonly.

friendly ping

May 29 2017, 10:23 AM
Prazek added a comment to D32673: [CaptureTracking] Handle capturing of invariant.group.barrier.

friendly ping42

May 29 2017, 10:22 AM
Prazek added inline comments to D33437: Emit available_externally vtables opportunistically.
May 29 2017, 10:19 AM
Prazek updated the diff for D31830: Emit invariant.group.barrier when using union field.

Add test

May 29 2017, 10:13 AM

May 27 2017

Prazek added inline comments to D31830: Emit invariant.group.barrier when using union field.
May 27 2017, 8:04 AM
Prazek updated the diff for D31830: Emit invariant.group.barrier when using union field.
  • changed to QualType, now it is much cleaner
May 27 2017, 8:03 AM
Prazek added a comment to D33437: Emit available_externally vtables opportunistically.

Thanks for the comments :)

May 27 2017, 3:46 AM
Prazek updated the diff for D33437: Emit available_externally vtables opportunistically.
  • Addressing John's comments
May 27 2017, 3:45 AM

May 25 2017

Prazek added a comment to D33537: [clang-tidy] Exception Escape Checker.

How is that compared to https://reviews.llvm.org/D19201 and the clang patch mentioned in this patch?

May 25 2017, 1:44 PM · Restricted Project
Prazek added a reviewer for D32006: Mark invariant.group.barrier as inaccessiblememonly: mehdi_amini.
May 25 2017, 3:09 AM
Prazek added a reviewer for D32673: [CaptureTracking] Handle capturing of invariant.group.barrier: mehdi_amini.
May 25 2017, 3:08 AM
Prazek updated the diff for D33470: [clang-tidy] Add misc-default-numerics.
  • Thanks for the review Aaron, that is much better.
May 25 2017, 2:40 AM · Restricted Project

May 24 2017

Prazek updated the diff for D33470: [clang-tidy] Add misc-default-numerics.
  • fixed docs
May 24 2017, 5:13 AM · Restricted Project
Prazek added inline comments to D33470: [clang-tidy] Add misc-default-numerics.
May 24 2017, 5:11 AM · Restricted Project

May 23 2017

Prazek added a project to D33470: [clang-tidy] Add misc-default-numerics: Restricted Project.
May 23 2017, 3:42 PM · Restricted Project
Prazek created D33470: [clang-tidy] Add misc-default-numerics.
May 23 2017, 3:41 PM · Restricted Project
Prazek added a comment to D32673: [CaptureTracking] Handle capturing of invariant.group.barrier.

Is there anyone who could take a look at this small patch? I haven't got any response for almost 3 weeks.

May 23 2017, 6:31 AM
Prazek updated the diff for D33437: Emit available_externally vtables opportunistically.

Removed debug print

May 23 2017, 6:30 AM
Prazek created D33437: Emit available_externally vtables opportunistically.
May 23 2017, 5:04 AM

May 21 2017

Prazek accepted D19201: [clang-tidy] misc-throw-with-noexcept.

LGTM, but wait if Aaron will accept it.

May 21 2017, 1:43 AM
Prazek added a comment to D19201: [clang-tidy] misc-throw-with-noexcept.

As an FYI, there is a related check being implemented in clang currently; we probably should not duplicate this effort. See https://reviews.llvm.org/D33333.

May 21 2017, 1:42 AM
Prazek added a comment to D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier.

Could you add similar tests as the ones that Stanislaw provied in his patch?
Like the one with checking if throw is catched, or the conditional noexcept (by a macro, etc)

May 21 2017, 1:33 AM
Prazek added a comment to D33235: Mark invariant.group as experimental.

Thanks Davide!

May 21 2017, 1:17 AM
Prazek added a dependent revision for D32006: Mark invariant.group.barrier as inaccessiblememonly: D33235: Mark invariant.group as experimental.
May 21 2017, 1:16 AM
Prazek added a dependency for D33235: Mark invariant.group as experimental: D32006: Mark invariant.group.barrier as inaccessiblememonly.
May 21 2017, 1:16 AM

May 20 2017

Prazek added a comment to D32006: Mark invariant.group.barrier as inaccessiblememonly.

ping2

May 20 2017, 3:57 AM
Prazek added inline comments to D19201: [clang-tidy] misc-throw-with-noexcept.
May 20 2017, 3:23 AM
Prazek added inline comments to D19201: [clang-tidy] misc-throw-with-noexcept.
May 20 2017, 2:53 AM
Prazek added inline comments to D32423: Constant fold barriers of null and undef.
May 20 2017, 2:48 AM
Prazek added a comment to D32673: [CaptureTracking] Handle capturing of invariant.group.barrier.

ping3

May 20 2017, 2:42 AM
Prazek added a comment to D31994: Simplify idempotent invariant.group.barriers.

ping2

May 20 2017, 2:42 AM
Prazek added a reviewer for D31830: Emit invariant.group.barrier when using union field: mehdi_amini.

Ping

May 20 2017, 2:20 AM
Prazek committed rL303488: [Devirtualization] insert placement new barrier with -O0.
[Devirtualization] insert placement new barrier with -O0
May 20 2017, 2:09 AM
Prazek closed D32401: [Devirtualization] insert placement new barrier with -O0 by committing rL303488: [Devirtualization] insert placement new barrier with -O0.
May 20 2017, 2:09 AM
Prazek updated the diff for D33235: Mark invariant.group as experimental.
  • fixes
May 20 2017, 2:06 AM

May 19 2017

Prazek added a comment to D32401: [Devirtualization] insert placement new barrier with -O0.

Is everyone ok with sending this patch?

May 19 2017, 1:37 AM

May 17 2017

Prazek abandoned D27767: NFC Changes from modernize-use-auto.
May 17 2017, 10:54 AM

May 16 2017

Prazek created D33235: Mark invariant.group as experimental.
May 16 2017, 6:12 AM
Prazek added a comment to D32006: Mark invariant.group.barrier as inaccessiblememonly.

ping

May 16 2017, 5:44 AM

May 14 2017

Prazek added a comment to D32673: [CaptureTracking] Handle capturing of invariant.group.barrier.

ping

May 14 2017, 9:01 AM
Prazek accepted D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls.

LGTM

May 14 2017, 9:01 AM · Restricted Project

May 11 2017

Prazek added a comment to D18738: Add new !unconditionally_dereferenceable load instruction metadata.

@sanjoy Since D20116 is in, is there any reason to avoid having a !speculatable on load instructions? It can be emulated anyway by defining a class of @load.x functions marked speculatable and their return value dereferenceable, so there is no loss of soundness.

May 11 2017, 10:41 AM

May 9 2017

Prazek added a comment to D32673: [CaptureTracking] Handle capturing of invariant.group.barrier.

ping

May 9 2017, 2:31 PM
Prazek committed rL302575: NFC: refactor replaceDominatedUsesWith.
NFC: refactor replaceDominatedUsesWith
May 9 2017, 12:53 PM
Prazek closed D32798: NFC: refactor replaceDominatedUsesWith by committing rL302575: NFC: refactor replaceDominatedUsesWith.
May 9 2017, 12:53 PM