[FileCheck] Fix fct param immediate comment style

[thopre]

Summary

Fix style of comments for immediate as function parameters in FileCheck
to use /*Foo=*/Value instead of Value /*Foo*/.

[probinson]

LGTM.

[thopre]

In D63539#1550144, @probinson wrote:

LGTM.

My apologies, just realize that all occurences at this point in the patch series are added by patches not yet approved so I've updated the patch series instead and am dropping this one. There are 2 occurences in the code base at the moment that will be gone when patch 8/12 gets approved, I don't feel it's worth doing a separate commit.

llvm/lib/Support/FileCheck.cpp

Expected<FileCheckExpression *> FileCheckPattern::parseNumericSubstitutionBlock(
   StringRef DefExpr = StringRef();
   DefinedNumericVariable = None;
   FileCheckExpressionFormat ExplicitFormat = FormatNone;
 
   // Parse format specifier.
   size_t FormatSpecEnd = Expr.find(',');
   if (FormatSpecEnd != StringRef::npos) {
     Expr = Expr.ltrim(SpaceChars);
-    if (stripFront(Expr, "%", false /*Optional*/))
+    if (stripFront(Expr, "%", /*Optional=*/false))
       return FileCheckErrorDiagnostic::get(
           SM, Expr, "invalid matching format specification in expression");
 
     // Check for unknown matching format specifier and set matching format in
     // class instance representing this expression.
     SMLoc fmtloc = SMLoc::getFromPointer(Expr.data());
     switch (popFront(Expr)) {
     case 'u':
       ExplicitFormat = FormatUnsigned;
       break;
     case 'x':
       ExplicitFormat = FormatLowHex;
       break;
     case 'X':
       ExplicitFormat = FormatCapHex;
       break;
     default:
       return FileCheckErrorDiagnostic::get(
           SM, fmtloc, "invalid format specifier in expression");
     }
 
     Expr = Expr.ltrim(SpaceChars);
-    if (stripFront(Expr, ",", false /*Optional*/))
+    if (stripFront(Expr, ",", /*Optional=*/false))
       return FileCheckErrorDiagnostic::get(
           SM, Expr, "invalid matching format specification in expression");
   }
 
   // Save variable definition expression if any.
   size_t DefEnd = Expr.find(':');
   if (DefEnd != StringRef::npos) {
     DefExpr = Expr.substr(0, DefEnd);

llvm/unittests/Support/FileCheckTest.cpp

TEST_F(FileCheckTest, FileCheckContext) {
   StringRef LocalVarStr = "LocalVar";
   StringRef LocalNumVarRef = bufferize(SM, "LocalNumVar");
   StringRef EmptyVarStr = "EmptyVar";
   StringRef UnknownVarStr = "UnknownVar";
   Expected<StringRef> LocalVar = Cxt.getPatternVarValue(LocalVarStr);
   FileCheckPattern P = FileCheckPattern(Check::CheckPlain, &Cxt, 1);
   Optional<FileCheckNumericVariable *> DefinedNumericVariable;
   Expected<FileCheckExpression *> Expression = P.parseNumericSubstitutionBlock(
-      LocalNumVarRef, DefinedNumericVariable, false /*Legacy*/,
-      1 /*LineNumber*/, &Cxt, SM);
+      LocalNumVarRef, DefinedNumericVariable, /*Legacy=*/false,
+      /*LineNumber=*/1, &Cxt, SM);
   EXPECT_TRUE(static_cast<bool>(LocalVar));
   EXPECT_EQ(*LocalVar, "FOO");
   Expected<StringRef> EmptyVar = Cxt.getPatternVarValue(EmptyVarStr);
   Expected<StringRef> UnknownVar = Cxt.getPatternVarValue(UnknownVarStr);
   EXPECT_TRUE(static_cast<bool>(Expression));
   Expected<uint64_t> ExpressionVal = (*Expression)->getAST()->eval();
   EXPECT_TRUE(static_cast<bool>(ExpressionVal));
   EXPECT_EQ(*ExpressionVal, 18U);
   EXPECT_TRUE(static_cast<bool>(EmptyVar));
   EXPECT_EQ(*EmptyVar, "");
   EXPECT_TRUE(errorToBool(UnknownVar.takeError()));
 
   // Clear local variables and check they become absent.
   Cxt.clearLocalVars();
   LocalVar = Cxt.getPatternVarValue(LocalVarStr);
   EXPECT_TRUE(errorToBool(LocalVar.takeError()));
   // Check a numeric expression's evaluation fails if called after clearing of
   // local variables, if it was created before. This is important because local
   // variable clearing due to --enable-var-scope happens after numeric
   // expressions are linked to the numeric variables they use.
   EXPECT_TRUE(errorToBool((*Expression)->getAST()->eval().takeError()));
   P = FileCheckPattern(Check::CheckPlain, &Cxt, 2);
   Expression = P.parseNumericSubstitutionBlock(
-      LocalNumVarRef, DefinedNumericVariable, false /*Legacy*/,
-      2 /*LineNumber*/, &Cxt, SM);
+      LocalNumVarRef, DefinedNumericVariable, /*Legacy=*/false,
+      /*LineNumber=*/2, &Cxt, SM);
   EXPECT_TRUE(errorToBool(Expression.takeError()));
   EmptyVar = Cxt.getPatternVarValue(EmptyVarStr);
   EXPECT_TRUE(errorToBool(EmptyVar.takeError()));
 
   // Redefine global variables and check variables are defined again.
   GlobalDefines.emplace_back(std::string("$GlobalVar=BAR"));
   GlobalDefines.emplace_back(std::string("#$GlobalNumVar=36"));
   EXPECT_FALSE(errorToBool(Cxt.defineCmdlineVariables(GlobalDefines, SM)));
   StringRef GlobalVarStr = "$GlobalVar";
   StringRef GlobalNumVarRef = bufferize(SM, "$GlobalNumVar");
   Expected<StringRef> GlobalVar = Cxt.getPatternVarValue(GlobalVarStr);
   EXPECT_TRUE(static_cast<bool>(GlobalVar));
   EXPECT_EQ(*GlobalVar, "BAR");
   P = FileCheckPattern(Check::CheckPlain, &Cxt, 3);
   Expression = P.parseNumericSubstitutionBlock(
-      GlobalNumVarRef, DefinedNumericVariable, false /*Legacy*/,
-      3 /*LineNumber*/, &Cxt, SM);
+      GlobalNumVarRef, DefinedNumericVariable, /*Legacy=*/false,
+      /*LineNumber=*/3, &Cxt, SM);
   EXPECT_TRUE(static_cast<bool>(Expression));
   ExpressionVal = (*Expression)->getAST()->eval();
   EXPECT_TRUE(static_cast<bool>(ExpressionVal));
   EXPECT_EQ(*ExpressionVal, 36U);
 
   // Clear local variables and check global variables remain defined.
   Cxt.clearLocalVars();
   EXPECT_FALSE(errorToBool(Cxt.getPatternVarValue(GlobalVarStr).takeError()));
   P = FileCheckPattern(Check::CheckPlain, &Cxt, 4);
   Expression = P.parseNumericSubstitutionBlock(
-      GlobalNumVarRef, DefinedNumericVariable, false /*Legacy*/,
-      4 /*LineNumber*/, &Cxt, SM);
+      GlobalNumVarRef, DefinedNumericVariable, /*Legacy=*/false,
+      /*LineNumber=*/4, &Cxt, SM);
   EXPECT_TRUE(static_cast<bool>(Expression));
   ExpressionVal = (*Expression)->getAST()->eval();
   EXPECT_TRUE(static_cast<bool>(ExpressionVal));
   EXPECT_EQ(*ExpressionVal, 36U);
 }
 } // namespace