This is an archive of the discontinued LLVM Phabricator instance.

[DAGCombiner] Replace two unchecked dyn_casts with casts.
AbandonedPublic

Authored by craig.topper on Jun 1 2019, 9:48 PM.

Details

Summary

The results of the dyn_casts were immediately dereferenced on the next line
so they had better not be null.

I don't think there's any way for these dyn_casts to fail, so use a cast
of adding null check.

[CFLGraph] Add FAdd to visitConstantExpr.

This looks like an oversight as all the other binary operators are present.

Accidentally noticed while auditing places that need FNeg handling.

Not sure how to test this.

Event Timeline

craig.topper created this revision.Jun 1 2019, 9:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2019, 9:48 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
craig.topper abandoned this revision.Jun 1 2019, 9:49 PM

This was created incorrectly. Forgot rebase after last commit before running arcanist.