Details
Details
- Reviewers
filcab gbedwell kcc probinson wristow phosek vitalybuka jdoerfert - Commits
- rCRT363038: [compiler-rt] Update comments in asan header to doxygen format; NFC.
rG012ae4cc40f9: [compiler-rt] Update comments in asan header to doxygen format; NFC.
rL363038: [compiler-rt] Update comments in asan header to doxygen format; NFC.
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
I think adding all these comments and updating the format is a great thing!
Minor comments to consider:
- I thought we used backslash instead of @ now but I might be wrong. The coding standard uses backslashs, if compiler-rt is not using @ all over the place you should change it.
- Mention in the commit message that you also add descriptions to undocumented functions.
- Mention in the commit message that you improved spelling, grammar, and formatting as well.
I'm not a compiler-rt person but if there is no objection in the next few days, you should go ahead (LGTM).
Comment Actions
Sounds good, yes '@' is not used at all in compiler-rt doxygen comments, I have replaced with '\'. Thanks!