Page MenuHomePhabricator

pgousseau (pierre gousseau)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2015, 2:44 AM (296 w, 23 h)

Recent Activity

Wed, Oct 7

pgousseau requested review of D88957: [cmake] Fix cmake warning in standalone compiler-rt builds..
Wed, Oct 7, 4:51 AM · Restricted Project

Aug 24 2020

pgousseau added inline comments to D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..
Aug 24 2020, 3:30 AM · Restricted Project
pgousseau updated the diff for D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..
  • Always use MWAITX_DAG
  • Remove uneeded Glue
Aug 24 2020, 3:13 AM · Restricted Project

Aug 21 2020

pgousseau updated the diff for D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..

Updated the patch to handle the case described in PR42064 where a separate basic block demands the use of a base pointer.
In that case we do the codegen of mwaitx during custom insertion.

Aug 21 2020, 5:20 AM · Restricted Project

Jul 30 2020

pgousseau requested review of D84945: [compiler-rt] Normalize some in/out doxygen parameter in interface headers. NFC..
Jul 30 2020, 7:00 AM · Restricted Project

Apr 8 2020

pgousseau added a comment to D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

It looks like you're not actually interested in the compiled output, but just whether warnings occurred; in that case you'd be better off with -verify -fsyntax-only and // expected-no-diagnostics.

Apr 8 2020, 7:34 AM · Restricted Project

Apr 7 2020

pgousseau updated the diff for D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

Fix false negative test introduce while attempting to add label check.

Apr 7 2020, 7:00 AM · Restricted Project
pgousseau reopened D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

Reopening to fix false negative test.

Apr 7 2020, 7:00 AM · Restricted Project
pgousseau added inline comments to D77393: [X86] Fix implicit sign conversion warnings in X86 headers..
Apr 7 2020, 4:17 AM · Restricted Project
pgousseau updated the diff for D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

Added label

Apr 7 2020, 3:45 AM · Restricted Project

Apr 3 2020

pgousseau updated the diff for D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

Renaming test and including x86intrin.h instead.

Apr 3 2020, 9:07 AM · Restricted Project
pgousseau created D77393: [X86] Fix implicit sign conversion warnings in X86 headers..
Apr 3 2020, 6:57 AM · Restricted Project

Jan 28 2020

pgousseau added a comment to D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..

Is this subject to the same problem as PR42064?

Jan 28 2020, 9:35 AM · Restricted Project

Jan 27 2020

pgousseau created D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..
Jan 27 2020, 7:16 AM · Restricted Project

Sep 25 2019

pgousseau committed rL372854: Request access for pgousseau.
Request access for pgousseau
Sep 25 2019, 5:15 AM

Sep 13 2019

pgousseau committed rG1ae9e6918d94: [compiler-rt] Add ubsan interface header. (authored by pgousseau).
[compiler-rt] Add ubsan interface header.
Sep 13 2019, 1:23 AM
pgousseau committed rL371822: [compiler-rt] Add ubsan interface header..
[compiler-rt] Add ubsan interface header.
Sep 13 2019, 1:22 AM
pgousseau closed D67503: [compiler-rt] Add ubsan interface header..
Sep 13 2019, 1:22 AM · Restricted Project, Restricted Project

Sep 12 2019

pgousseau created D67503: [compiler-rt] Add ubsan interface header..
Sep 12 2019, 8:33 AM · Restricted Project, Restricted Project

Jun 11 2019

pgousseau committed rG012ae4cc40f9: [compiler-rt] Update comments in asan header to doxygen format; NFC. (authored by pgousseau).
[compiler-rt] Update comments in asan header to doxygen format; NFC.
Jun 11 2019, 1:59 AM
pgousseau committed rL363038: [compiler-rt] Update comments in asan header to doxygen format; NFC..
[compiler-rt] Update comments in asan header to doxygen format; NFC.
Jun 11 2019, 1:59 AM
pgousseau closed D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..
Jun 11 2019, 1:58 AM · Restricted Project, Restricted Project

Jun 3 2019

pgousseau added a comment to D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..

I think adding all these comments and updating the format is a great thing!

Minor comments to consider:

  • I thought we used backslash instead of @ now but I might be wrong. The coding standard uses backslashs, if compiler-rt is not using @ all over the place you should change it.
  • Mention in the commit message that you also add descriptions to undocumented functions.
  • Mention in the commit message that you improved spelling, grammar, and formatting as well.

I'm not a compiler-rt person but if there is no objection in the next few days, you should go ahead (LGTM).

Jun 3 2019, 3:11 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..

Replaced doxygen's '@' character by '\'

Jun 3 2019, 3:11 AM · Restricted Project, Restricted Project

May 31 2019

pgousseau added a comment to D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..

Ping!

May 31 2019, 3:29 AM · Restricted Project, Restricted Project
pgousseau added reviewers for D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC.: phosek, vitalybuka.
May 31 2019, 3:29 AM · Restricted Project, Restricted Project

May 22 2019

pgousseau created D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..
May 22 2019, 4:35 AM · Restricted Project, Restricted Project

Apr 12 2019

pgousseau committed rG1e39fc1faa5d: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and… (authored by pgousseau).
[asan] Add gcc 8's driver option -fsanitize=pointer-compare and…
Apr 12 2019, 7:14 AM
pgousseau committed rL358285: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and….
[asan] Add gcc 8's driver option -fsanitize=pointer-compare and…
Apr 12 2019, 7:13 AM
pgousseau committed rC358285: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and….
[asan] Add gcc 8's driver option -fsanitize=pointer-compare and…
Apr 12 2019, 7:13 AM
pgousseau closed D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..
Apr 12 2019, 7:13 AM · Restricted Project, Restricted Project
pgousseau added inline comments to D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..
Apr 12 2019, 7:12 AM · Restricted Project, Restricted Project

Apr 10 2019

pgousseau added a comment to D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..

Ping!

Apr 10 2019, 5:04 AM · Restricted Project, Restricted Project

Apr 2 2019

pgousseau committed rG0b9527119f7e: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4. (authored by pgousseau).
[Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.
Apr 2 2019, 8:19 AM
pgousseau committed rC357480: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..
[Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.
Apr 2 2019, 8:19 AM
pgousseau committed rL357480: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..
[Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.
Apr 2 2019, 8:19 AM
pgousseau closed D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..
Apr 2 2019, 8:19 AM · Restricted Project

Mar 28 2019

pgousseau added a comment to D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..

This is fine for PS4, I'm just curious whether anyone knows if there's a predicate that means something like "target does not use GNU tools" so we don't have to itemize Fuschia and PS4 this way.

Mar 28 2019, 8:28 AM · Restricted Project
pgousseau committed rGa833c2bd3e8b: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid… (authored by pgousseau).
[asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid…
Mar 28 2019, 3:52 AM
pgousseau committed rL357157: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid….
[asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid…
Mar 28 2019, 3:52 AM
pgousseau closed D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 28 2019, 3:52 AM · Restricted Project
pgousseau added inline comments to D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 28 2019, 3:52 AM · Restricted Project

Mar 27 2019

pgousseau updated the diff for D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..

Update patch to reflect changes to the llvm side of the patch.

Mar 27 2019, 8:15 AM · Restricted Project, Restricted Project
pgousseau added a comment to D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..

What is exactly going to be checked by -fsanitize=pointer-compare and -fsanitize=pointer-subtract?
Why this needs to be done in AddressSanitizer?
Is this going just checheck that pointers are from the same allocation?

Mar 27 2019, 8:12 AM · Restricted Project
pgousseau added inline comments to D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 27 2019, 8:10 AM · Restricted Project
pgousseau updated the diff for D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..

Use backend option directly rather than introducing new parameters.
Add missing ALL check to test.

Mar 27 2019, 8:09 AM · Restricted Project

Mar 26 2019

pgousseau added a comment to D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..

Ping!

Mar 26 2019, 5:08 AM · Restricted Project
pgousseau created D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..
Mar 26 2019, 5:03 AM · Restricted Project

Mar 11 2019

pgousseau updated the summary of D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 11 2019, 10:14 AM · Restricted Project
pgousseau created D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..
Mar 11 2019, 10:13 AM · Restricted Project, Restricted Project
pgousseau created D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 11 2019, 10:09 AM · Restricted Project

Mar 4 2019

pgousseau added a comment to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

The intricate initialization-order workarounds apparently don't work in all build modes, so I've updated this code to have constexpr functions and initializations in rL355278.

Mar 4 2019, 3:23 AM · Restricted Project, Restricted Project

Mar 1 2019

pgousseau committed rGae5303d01026: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different… (authored by pgousseau).
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different…
Mar 1 2019, 2:05 AM
pgousseau committed rC355190: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different….
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different…
Mar 1 2019, 2:04 AM
pgousseau committed rL355190: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different….
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different…
Mar 1 2019, 2:04 AM
pgousseau closed D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Mar 1 2019, 2:04 AM · Restricted Project, Restricted Project

Feb 28 2019

pgousseau added inline comments to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 28 2019, 9:04 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Change hash_value() declaration's location as suggested.

Feb 28 2019, 9:03 AM · Restricted Project, Restricted Project
pgousseau added inline comments to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 28 2019, 7:50 AM · Restricted Project, Restricted Project

Feb 27 2019

pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

move hash_value declaration to clang's namespace to solve lldb cmake bot build error.

Feb 27 2019, 10:13 AM · Restricted Project, Restricted Project
pgousseau reopened D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Reopening because of buildbot failure http://green.lab.llvm.org/green/job/lldb-cmake/20537/

Feb 27 2019, 10:00 AM · Restricted Project, Restricted Project

Feb 26 2019

pgousseau committed rG40ad3d2aa4b0: revert r354873 as this breaks lldb builds. (authored by pgousseau).
revert r354873 as this breaks lldb builds.
Feb 26 2019, 5:50 AM
pgousseau committed rC354875: revert r354873 as this breaks lldb builds..
revert r354873 as this breaks lldb builds.
Feb 26 2019, 5:50 AM
pgousseau committed rL354875: revert r354873 as this breaks lldb builds..
revert r354873 as this breaks lldb builds.
Feb 26 2019, 5:50 AM
pgousseau added a comment to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

reverted at r354875 at this break lldb build.

Feb 26 2019, 5:50 AM · Restricted Project, Restricted Project
pgousseau committed rG44fad947a571: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different… (authored by pgousseau).
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different…
Feb 26 2019, 5:34 AM
pgousseau committed rL354873: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different….
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different…
Feb 26 2019, 5:34 AM
pgousseau committed rC354873: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different….
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different…
Feb 26 2019, 5:34 AM
pgousseau closed D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 26 2019, 5:33 AM · Restricted Project, Restricted Project
pgousseau added a comment to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

I think this looks good now. Thanks !

Feb 26 2019, 5:33 AM · Restricted Project, Restricted Project

Feb 25 2019

pgousseau added inline comments to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 25 2019, 7:36 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Keep enum SanitizerOrdinal as it was inside SanitizerKind namespace, fix comment.

Feb 25 2019, 7:34 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Fix bad use of reference as pointed out, aliased SanitizerKind to SanitizerMasks<> instead.

Feb 25 2019, 4:07 AM · Restricted Project, Restricted Project

Feb 22 2019

pgousseau added inline comments to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 22 2019, 4:19 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Rework FIXME comment.

Feb 22 2019, 3:26 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Fix odr violation issue using static data member of a class template as suggested.

Feb 22 2019, 2:41 AM · Restricted Project, Restricted Project

Feb 21 2019

pgousseau added a comment to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

More explicitly something like:

in Sanitizer.h:

template <typename T = void> struct SanitizerMasks {
  static const SanitizerMask SomeMask;
  /* and so on for each mask*/
};

template <typename T> const SanitizerMask SanitizerMasks<T>::SomeMask = the definition;

And then you can write SanitizerMasks<>::SomeMask when you want to use this mask.

Feb 21 2019, 9:14 AM · Restricted Project, Restricted Project
pgousseau added a comment to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

I think what you would really want to do is mark the masks as inline constexpr, but sadly inline variables are C++17 only. I have seen some ways to emulate inline variables but I am not sure whether it is worth doing so in this case.

Yes thanks for the advice.
I have tried moving the definitions to the cpp file but ran into initialization order fiasco issue because of SanitizerArgs.cpp global definitions.
If using a constexpr SanitizerMask ctor then that would work around the initialization fiasco issue hopefully?
Although I am not having much luck using constexpr ctor in VS2015 because of the array member, so might have to revert back to lo/hi mask members?

I would prefer to avoid doing this. What is the problem with constexpr ?

Feb 21 2019, 8:14 AM · Restricted Project, Restricted Project
pgousseau added a comment to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

I think what you would really want to do is mark the masks as inline constexpr, but sadly inline variables are C++17 only. I have seen some ways to emulate inline variables but I am not sure whether it is worth doing so in this case.

Feb 21 2019, 6:00 AM · Restricted Project, Restricted Project

Feb 20 2019

pgousseau added a comment to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Wait no, can you really define the SanitizerMasks in the header ? Isn't that an odr violation ?

Feb 20 2019, 7:12 AM · Restricted Project, Restricted Project
pgousseau added inline comments to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 20 2019, 5:24 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Applied suggested changes.

Feb 20 2019, 5:17 AM · Restricted Project, Restricted Project

Feb 19 2019

pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Updated to use an array as suggested.

Feb 19 2019, 10:04 AM · Restricted Project, Restricted Project

Feb 18 2019

pgousseau added inline comments to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 18 2019, 10:18 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Updated patch to not use APInt for representing the mask as it feels like a hammer solution.

Feb 18 2019, 9:45 AM · Restricted Project, Restricted Project

Feb 11 2019

pgousseau added a reviewer for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.: kcc.
Feb 11 2019, 2:08 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Move num bits constant inside class.

Feb 11 2019, 2:07 AM · Restricted Project, Restricted Project

Feb 7 2019

pgousseau created D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 7 2019, 11:01 AM · Restricted Project, Restricted Project

Jan 24 2019

pgousseau committed rC352042: Test commit: fix typo..
Test commit: fix typo.
Jan 24 2019, 3:44 AM
pgousseau committed rL352042: Test commit: fix typo..
Test commit: fix typo.
Jan 24 2019, 3:44 AM

Dec 18 2018

pgousseau committed rL349508: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or….
[Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or…
Dec 18 2018, 9:07 AM
pgousseau committed rC349508: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or….
[Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or…
Dec 18 2018, 9:06 AM
pgousseau closed D55712: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or -nodefaultlibs on PS4..
Dec 18 2018, 9:06 AM
pgousseau added a comment to D55712: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or -nodefaultlibs on PS4..

I missed that filcab had said ok internally. Go ahead Pierre.

Dec 18 2018, 8:42 AM

Dec 14 2018

pgousseau created D55712: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or -nodefaultlibs on PS4..
Dec 14 2018, 10:15 AM

Jun 6 2018

pgousseau committed rC334096: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4..
[Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.
Jun 6 2018, 7:08 AM
pgousseau committed rL334096: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4..
[Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.
Jun 6 2018, 7:08 AM
pgousseau closed D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4..
Jun 6 2018, 7:08 AM
pgousseau updated the diff for D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4..

Updated patch with requested changes.

Jun 6 2018, 7:02 AM

May 25 2018

pgousseau created D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4..
May 25 2018, 8:17 AM