Page MenuHomePhabricator

pgousseau (pierre gousseau)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2015, 2:44 AM (379 w, 5 d)

Recent Activity

Apr 5 2022

pgousseau committed rGa3d5f1cf5d88: [x86] Fix infinite loop inside DAG combiner with lzcnt feature. (authored by pgousseau).
[x86] Fix infinite loop inside DAG combiner with lzcnt feature.
Apr 5 2022, 9:32 AM · Restricted Project, Restricted Project
pgousseau closed D122900: [x86] Fix infinite loop inside DAG combiner lzcnt's optimization..
Apr 5 2022, 9:32 AM · Restricted Project, Restricted Project
pgousseau added a comment to D122900: [x86] Fix infinite loop inside DAG combiner lzcnt's optimization..

Fixed! thanks

Apr 5 2022, 5:34 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D122900: [x86] Fix infinite loop inside DAG combiner lzcnt's optimization..

Remove unneeded Ret value check.

Apr 5 2022, 5:33 AM · Restricted Project, Restricted Project

Apr 4 2022

pgousseau updated the diff for D122900: [x86] Fix infinite loop inside DAG combiner lzcnt's optimization..

Remove unused parameter.

Apr 4 2022, 11:10 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D122900: [x86] Fix infinite loop inside DAG combiner lzcnt's optimization..

@RKSimon suggested the transformation might be caused by unneeded trunc/zext operations.
It is causing the DAG combiner to needlessly sink them under the OR operations so I have removed them where possible and this fixes the infinite loop.
The instructions generated end up being reordered is some cases but I think it is equivalent.

Apr 4 2022, 11:04 AM · Restricted Project, Restricted Project

Apr 1 2022

pgousseau added a comment to D122900: [x86] Fix infinite loop inside DAG combiner lzcnt's optimization..

Do you know which commit introduced the problem, or which transforms conflict?
This looks like a pretty heavy hammer.

Thank you Roman for reviewing!
The regression appeared after https://github.com/llvm/llvm-project/commit/8a156d1c2795189389fadbf33702384f522f2506 (thank you @wristow for finding it)
As @RKSimon found out, the IR does not get generated anymore from the original C++ test case but the issue is still present.
I am hopeful we can reintroduce the optimization (at a later codegen stage maybe?) but I would like to do some performance analysis first to see if it is still a win.

That change might have exposed the bug from source/IR, but the backend loop has existed since at least the 10.0 release based on a godbolt check:
https://godbolt.org/z/Tfnaevboz

Then i think just fixing it may be better than removing some chunks of code.

Apr 1 2022, 9:56 AM · Restricted Project, Restricted Project
pgousseau updated subscribers of D122900: [x86] Fix infinite loop inside DAG combiner lzcnt's optimization..

Do you know which commit introduced the problem, or which transforms conflict?
This looks like a pretty heavy hammer.

Apr 1 2022, 7:11 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D122900: [x86] Fix infinite loop inside DAG combiner lzcnt's optimization..

Added a regression test.

Apr 1 2022, 6:10 AM · Restricted Project, Restricted Project
pgousseau requested review of D122900: [x86] Fix infinite loop inside DAG combiner lzcnt's optimization..
Apr 1 2022, 5:57 AM · Restricted Project, Restricted Project

Feb 2 2022

pgousseau abandoned D118159: [CMake][MSVC] Add include path to crt headers when enabling sanitizers..

Abandoned in favour of https://reviews.llvm.org/D118624

Feb 2 2022, 9:59 AM · Restricted Project
pgousseau committed rG83b74544c658: [MSVC] Workaround missing search path for sanitizer headers. (authored by pgousseau).
[MSVC] Workaround missing search path for sanitizer headers.
Feb 2 2022, 3:00 AM
pgousseau closed D118624: [MSVC] Workaround missing search path for sanitizer headers..
Feb 2 2022, 3:00 AM · Restricted Project

Feb 1 2022

pgousseau updated the diff for D118624: [MSVC] Workaround missing search path for sanitizer headers..

Add comment as suggested.

Feb 1 2022, 10:46 AM · Restricted Project
pgousseau added inline comments to D118624: [MSVC] Workaround missing search path for sanitizer headers..
Feb 1 2022, 4:03 AM · Restricted Project
pgousseau updated the diff for D118624: [MSVC] Workaround missing search path for sanitizer headers..

Hoist up __has_include ifdef guard as per comment.

Feb 1 2022, 2:07 AM · Restricted Project

Jan 31 2022

pgousseau added a comment to D118159: [CMake][MSVC] Add include path to crt headers when enabling sanitizers..

I have made an alternative patch at https://reviews.llvm.org/D118624 to avoid adding all internal crt sources to the header search paths. Not ideal either, let me know what you think, thanks!

Jan 31 2022, 9:13 AM · Restricted Project
pgousseau requested review of D118624: [MSVC] Workaround missing search path for sanitizer headers..
Jan 31 2022, 9:08 AM · Restricted Project

Jan 28 2022

pgousseau committed rG14e8bedc9807: [tblgen] Disable lsan weak hook when building with msvc (authored by pgousseau).
[tblgen] Disable lsan weak hook when building with msvc
Jan 28 2022, 2:03 AM
pgousseau closed D118162: [tblgen] Disable lsan weak hook when building with msvc.
Jan 28 2022, 2:03 AM · Restricted Project

Jan 27 2022

pgousseau added inline comments to D118162: [tblgen] Disable lsan weak hook when building with msvc.
Jan 27 2022, 4:17 AM · Restricted Project
pgousseau updated the diff for D118162: [tblgen] Disable lsan weak hook when building with msvc.

Updating patch following comments, using __GNUC__ instead of !_WIN32 which was wrong.

Jan 27 2022, 4:14 AM · Restricted Project

Jan 26 2022

pgousseau added a comment to D118162: [tblgen] Disable lsan weak hook when building with msvc.

I'm a bit confused as to why this change is needed. My understanding is that __SANITIZE_ADDRESS__ is only defined when the user passes -fsanitize=address (so they explicitly opted in). So isn't the issue here that the user asked for something unsupported and the solution is for them to not pass that compiler argument on Windows? Alternatively, should the fix be to require __has_feature(leak_sanitizer) to return true instead of using ||?

(I'm a bit worried that we're carving out an exception for something that's feature testable and when the feature eventually gets supported on Windows, nobody will remember to go remove the special exceptions.)

Jan 26 2022, 5:48 AM · Restricted Project
pgousseau added a reviewer for D118162: [tblgen] Disable lsan weak hook when building with msvc: rnk.
Jan 26 2022, 4:15 AM · Restricted Project
pgousseau added inline comments to D118159: [CMake][MSVC] Add include path to crt headers when enabling sanitizers..
Jan 26 2022, 3:58 AM · Restricted Project

Jan 25 2022

pgousseau requested review of D118162: [tblgen] Disable lsan weak hook when building with msvc.
Jan 25 2022, 9:41 AM · Restricted Project
pgousseau requested review of D118159: [CMake][MSVC] Add include path to crt headers when enabling sanitizers..
Jan 25 2022, 9:24 AM · Restricted Project

Nov 12 2021

pgousseau accepted D113692: [NFC][llvm] Remove uses of blacklist in llvm/test/Instrumentation.

LGTM!

Nov 12 2021, 1:48 AM · Restricted Project

Jul 28 2021

pgousseau accepted D106978: sanitizer_common: avoid compiler-interted memset in deadlock detector.

Lgtm! Thank you for the quick fix!

Jul 28 2021, 11:13 AM · Restricted Project
pgousseau added inline comments to D106546: sanitizer_common: add deadlock detection to the Mutex2.
Jul 28 2021, 10:55 AM · Restricted Project

Jun 9 2021

pgousseau accepted D103953: Sanitizers.h - remove MathExtras.h include dependency.

LGTM!

Jun 9 2021, 4:12 AM · Restricted Project

Feb 24 2021

pgousseau closed D95859: [asan] Avoid putting globals in a comdat section..

Thank you vitalybuka eugenis for reviewing! I have pushed the change at https://reviews.llvm.org/rG27830bc2b1b8
Sorry I forgot to add the reviewers and phabricator url to the commit message -_-

Feb 24 2021, 4:16 AM · Restricted Project
pgousseau committed rG27830bc2b1b8: [asan] Avoid putting globals in a comdat section when targetting elf. (authored by pgousseau).
[asan] Avoid putting globals in a comdat section when targetting elf.
Feb 24 2021, 4:07 AM

Feb 23 2021

pgousseau added a comment to D95859: [asan] Avoid putting globals in a comdat section..

I guess odr-indicator=1 is for reliable ODR violation detection and odr-indicator=0 of smaller binary size.

Thank you for the comment, yes, this change can potentially break the assumption that odr-indicator=0 reduces binary size, as it will prevent certain linker (eg bfd 2.30), to dead strip unused asan globals’ metadata. Do I understand your point correctly?

But I think correct semantic should take priority over binary size optimizations, please let me know your thoughts on this.

Sanitizers don't mind false-negatives if it can noticeably help with some performance metrics. But I can't reproduce expected size regression.

Feb 23 2021, 2:24 AM · Restricted Project

Feb 17 2021

pgousseau added a comment to D95859: [asan] Avoid putting globals in a comdat section..

I guess odr-indicator=1 is for reliable ODR violation detection and odr-indicator=0 of smaller binary size.

Feb 17 2021, 4:40 AM · Restricted Project

Feb 16 2021

pgousseau added a comment to D95859: [asan] Avoid putting globals in a comdat section..

Ping

Feb 16 2021, 4:25 AM · Restricted Project

Feb 9 2021

pgousseau added a comment to D95859: [asan] Avoid putting globals in a comdat section..

Ping

Feb 9 2021, 5:23 AM · Restricted Project

Feb 3 2021

pgousseau updated the diff for D95859: [asan] Avoid putting globals in a comdat section..

fix lint issue

Feb 3 2021, 2:45 AM · Restricted Project

Feb 2 2021

pgousseau requested review of D95859: [asan] Avoid putting globals in a comdat section..
Feb 2 2021, 2:52 AM · Restricted Project

Oct 7 2020

pgousseau requested review of D88957: [cmake] Fix cmake warning in standalone compiler-rt builds..
Oct 7 2020, 4:51 AM · Restricted Project

Aug 24 2020

pgousseau added inline comments to D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..
Aug 24 2020, 3:30 AM · Restricted Project
pgousseau updated the diff for D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..
  • Always use MWAITX_DAG
  • Remove uneeded Glue
Aug 24 2020, 3:13 AM · Restricted Project

Aug 21 2020

pgousseau updated the diff for D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..

Updated the patch to handle the case described in PR42064 where a separate basic block demands the use of a base pointer.
In that case we do the codegen of mwaitx during custom insertion.

Aug 21 2020, 5:20 AM · Restricted Project

Jul 30 2020

pgousseau requested review of D84945: [compiler-rt] Normalize some in/out doxygen parameter in interface headers. NFC..
Jul 30 2020, 7:00 AM · Restricted Project

Apr 8 2020

pgousseau added a comment to D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

It looks like you're not actually interested in the compiled output, but just whether warnings occurred; in that case you'd be better off with -verify -fsyntax-only and // expected-no-diagnostics.

Apr 8 2020, 7:34 AM · Restricted Project

Apr 7 2020

pgousseau updated the diff for D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

Fix false negative test introduce while attempting to add label check.

Apr 7 2020, 7:00 AM · Restricted Project
pgousseau reopened D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

Reopening to fix false negative test.

Apr 7 2020, 7:00 AM · Restricted Project
pgousseau added inline comments to D77393: [X86] Fix implicit sign conversion warnings in X86 headers..
Apr 7 2020, 4:17 AM · Restricted Project
pgousseau updated the diff for D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

Added label

Apr 7 2020, 3:45 AM · Restricted Project

Apr 3 2020

pgousseau updated the diff for D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

Renaming test and including x86intrin.h instead.

Apr 3 2020, 9:07 AM · Restricted Project
pgousseau created D77393: [X86] Fix implicit sign conversion warnings in X86 headers..
Apr 3 2020, 6:57 AM · Restricted Project

Jan 28 2020

pgousseau added a comment to D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..

Is this subject to the same problem as PR42064?

Jan 28 2020, 9:35 AM · Restricted Project

Jan 27 2020

pgousseau created D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer..
Jan 27 2020, 7:16 AM · Restricted Project

Sep 25 2019

pgousseau committed rL372854: Request access for pgousseau.
Request access for pgousseau
Sep 25 2019, 5:15 AM

Sep 13 2019

pgousseau committed rG1ae9e6918d94: [compiler-rt] Add ubsan interface header. (authored by pgousseau).
[compiler-rt] Add ubsan interface header.
Sep 13 2019, 1:23 AM
pgousseau committed rL371822: [compiler-rt] Add ubsan interface header..
[compiler-rt] Add ubsan interface header.
Sep 13 2019, 1:22 AM
pgousseau closed D67503: [compiler-rt] Add ubsan interface header..
Sep 13 2019, 1:22 AM · Restricted Project, Restricted Project

Sep 12 2019

pgousseau created D67503: [compiler-rt] Add ubsan interface header..
Sep 12 2019, 8:33 AM · Restricted Project, Restricted Project

Jun 11 2019

pgousseau committed rG012ae4cc40f9: [compiler-rt] Update comments in asan header to doxygen format; NFC. (authored by pgousseau).
[compiler-rt] Update comments in asan header to doxygen format; NFC.
Jun 11 2019, 1:59 AM
pgousseau committed rL363038: [compiler-rt] Update comments in asan header to doxygen format; NFC..
[compiler-rt] Update comments in asan header to doxygen format; NFC.
Jun 11 2019, 1:59 AM
pgousseau closed D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..
Jun 11 2019, 1:58 AM · Restricted Project, Restricted Project

Jun 3 2019

pgousseau added a comment to D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..

I think adding all these comments and updating the format is a great thing!

Minor comments to consider:

  • I thought we used backslash instead of @ now but I might be wrong. The coding standard uses backslashs, if compiler-rt is not using @ all over the place you should change it.
  • Mention in the commit message that you also add descriptions to undocumented functions.
  • Mention in the commit message that you improved spelling, grammar, and formatting as well.

I'm not a compiler-rt person but if there is no objection in the next few days, you should go ahead (LGTM).

Jun 3 2019, 3:11 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..

Replaced doxygen's '@' character by '\'

Jun 3 2019, 3:11 AM · Restricted Project, Restricted Project

May 31 2019

pgousseau added a comment to D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..

Ping!

May 31 2019, 3:29 AM · Restricted Project, Restricted Project
pgousseau added reviewers for D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC.: phosek, vitalybuka.
May 31 2019, 3:29 AM · Restricted Project, Restricted Project

May 22 2019

pgousseau created D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC..
May 22 2019, 4:35 AM · Restricted Project, Restricted Project

Apr 12 2019

pgousseau committed rG1e39fc1faa5d: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and… (authored by pgousseau).
[asan] Add gcc 8's driver option -fsanitize=pointer-compare and…
Apr 12 2019, 7:14 AM
pgousseau committed rL358285: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and….
[asan] Add gcc 8's driver option -fsanitize=pointer-compare and…
Apr 12 2019, 7:13 AM
pgousseau committed rC358285: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and….
[asan] Add gcc 8's driver option -fsanitize=pointer-compare and…
Apr 12 2019, 7:13 AM
pgousseau closed D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..
Apr 12 2019, 7:13 AM · Restricted Project, Restricted Project
pgousseau added inline comments to D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..
Apr 12 2019, 7:12 AM · Restricted Project, Restricted Project

Apr 10 2019

pgousseau added a comment to D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..

Ping!

Apr 10 2019, 5:04 AM · Restricted Project, Restricted Project

Apr 2 2019

pgousseau committed rG0b9527119f7e: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4. (authored by pgousseau).
[Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.
Apr 2 2019, 8:19 AM
pgousseau committed rC357480: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..
[Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.
Apr 2 2019, 8:19 AM
pgousseau committed rL357480: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..
[Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.
Apr 2 2019, 8:19 AM
pgousseau closed D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..
Apr 2 2019, 8:19 AM · Restricted Project

Mar 28 2019

pgousseau added a comment to D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..

This is fine for PS4, I'm just curious whether anyone knows if there's a predicate that means something like "target does not use GNU tools" so we don't have to itemize Fuschia and PS4 this way.

Mar 28 2019, 8:28 AM · Restricted Project
pgousseau committed rGa833c2bd3e8b: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid… (authored by pgousseau).
[asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid…
Mar 28 2019, 3:52 AM
pgousseau committed rL357157: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid….
[asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid…
Mar 28 2019, 3:52 AM
pgousseau closed D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 28 2019, 3:52 AM · Restricted Project
pgousseau added inline comments to D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 28 2019, 3:52 AM · Restricted Project

Mar 27 2019

pgousseau updated the diff for D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..

Update patch to reflect changes to the llvm side of the patch.

Mar 27 2019, 8:15 AM · Restricted Project, Restricted Project
pgousseau added a comment to D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..

What is exactly going to be checked by -fsanitize=pointer-compare and -fsanitize=pointer-subtract?
Why this needs to be done in AddressSanitizer?
Is this going just checheck that pointers are from the same allocation?

Mar 27 2019, 8:12 AM · Restricted Project
pgousseau added inline comments to D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 27 2019, 8:10 AM · Restricted Project
pgousseau updated the diff for D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..

Use backend option directly rather than introducing new parameters.
Add missing ALL check to test.

Mar 27 2019, 8:09 AM · Restricted Project

Mar 26 2019

pgousseau added a comment to D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..

Ping!

Mar 26 2019, 5:08 AM · Restricted Project
pgousseau created D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4..
Mar 26 2019, 5:03 AM · Restricted Project

Mar 11 2019

pgousseau updated the summary of D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 11 2019, 10:14 AM · Restricted Project
pgousseau created D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..
Mar 11 2019, 10:13 AM · Restricted Project, Restricted Project
pgousseau created D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 11 2019, 10:09 AM · Restricted Project

Mar 4 2019

pgousseau added a comment to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

The intricate initialization-order workarounds apparently don't work in all build modes, so I've updated this code to have constexpr functions and initializations in rL355278.

Mar 4 2019, 3:23 AM · Restricted Project, Restricted Project

Mar 1 2019

pgousseau committed rGae5303d01026: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different… (authored by pgousseau).
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different…
Mar 1 2019, 2:05 AM
pgousseau committed rC355190: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different….
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different…
Mar 1 2019, 2:04 AM
pgousseau committed rL355190: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different….
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different…
Mar 1 2019, 2:04 AM
pgousseau closed D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Mar 1 2019, 2:04 AM · Restricted Project, Restricted Project

Feb 28 2019

pgousseau added inline comments to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 28 2019, 9:04 AM · Restricted Project, Restricted Project
pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Change hash_value() declaration's location as suggested.

Feb 28 2019, 9:03 AM · Restricted Project, Restricted Project
pgousseau added inline comments to D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..
Feb 28 2019, 7:50 AM · Restricted Project, Restricted Project

Feb 27 2019

pgousseau updated the diff for D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

move hash_value declaration to clang's namespace to solve lldb cmake bot build error.

Feb 27 2019, 10:13 AM · Restricted Project, Restricted Project
pgousseau reopened D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC..

Reopening because of buildbot failure http://green.lab.llvm.org/green/job/lldb-cmake/20537/

Feb 27 2019, 10:00 AM · Restricted Project, Restricted Project