Page MenuHomePhabricator

Save the induction binary operator in IVDescriptors for non FP induction variables.
ClosedPublic

Authored by Whitney on Apr 30 2019, 11:36 AM.

Details

Summary

Currently InductionBinOps are only saved for FP induction variables, the PR extends it with non FP induction variable, so user of IVDescriptors can query the InductionBinOps for integer induction variables.

The changes in hasUnsafeAlgebra() and getUnsafeAlgebraInst() are required for the existing LIT test cases to pass. As described in the comment of the two functions, one of the requirement to return true is it is a FP induction variable. The checks was not needed because InductionBinOp was not set on non FP cases before.

https://reviews.llvm.org/D60565 depends on the patch.

Diff Detail

Repository
rL LLVM

Event Timeline

Whitney created this revision.Apr 30 2019, 11:36 AM
Whitney updated this revision to Diff 197419.Apr 30 2019, 12:54 PM

clang-format

Whitney updated this revision to Diff 198904.May 9 2019, 2:17 PM

Any comments?

This revision is now accepted and ready to land.May 13 2019, 2:28 PM
This revision was automatically updated to reflect the committed changes.