Page MenuHomePhabricator

Whitney (Whitney)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 29 2019, 6:22 PM (20 w, 11 h)

Recent Activity

Mon, Jun 17

Whitney added inline comments to D63446: Expand cloneLoopWithPreheader() to support cloning loop nest.
Mon, Jun 17, 1:41 PM · Restricted Project
Whitney updated the diff for D63446: Expand cloneLoopWithPreheader() to support cloning loop nest.

Addressed all review comments from Michael.

Mon, Jun 17, 1:41 PM · Restricted Project
Whitney created D63446: Expand cloneLoopWithPreheader() to support cloning loop nest.
Mon, Jun 17, 10:56 AM · Restricted Project
Whitney committed rG15b7f5b72d2a: PHINode: introduce setIncomingValueForBlock() function, and use it. (authored by Whitney).
PHINode: introduce setIncomingValueForBlock() function, and use it.
Mon, Jun 17, 7:37 AM
Whitney updated the diff for D63338: PHINode: introduce setIncomingValueForBlock() function, and use it..

Added the assert. Thanks for the reviews.

Mon, Jun 17, 7:19 AM · Restricted Project

Fri, Jun 14

Whitney added inline comments to D63338: PHINode: introduce setIncomingValueForBlock() function, and use it..
Fri, Jun 14, 9:55 AM · Restricted Project
Whitney updated the diff for D63338: PHINode: introduce setIncomingValueForBlock() function, and use it..
Fri, Jun 14, 9:55 AM · Restricted Project
Whitney added inline comments to D63338: PHINode: introduce setIncomingValueForBlock() function, and use it..
Fri, Jun 14, 9:28 AM · Restricted Project
Whitney created D63338: PHINode: introduce setIncomingValueForBlock() function, and use it..
Fri, Jun 14, 9:00 AM · Restricted Project

Mon, Jun 10

Whitney committed rG05bf5f9328e2: [DA] Add an option to control delinearization validity checks (authored by Whitney).
[DA] Add an option to control delinearization validity checks
Mon, Jun 10, 8:28 AM

Thu, Jun 6

Whitney committed rG03e8369a7280: [DA] Add an option to control delinearization validity checks (authored by Whitney).
[DA] Add an option to control delinearization validity checks
Thu, Jun 6, 8:11 AM

Wed, Jun 5

Whitney committed rG2d0896c1cb90: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step… (authored by Whitney).
[LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step…
Wed, Jun 5, 1:43 PM
Whitney committed rG590b1aee609d: Revert "Title: [LOOPINFO] Extend Loop object to add utilities to get the loop" (authored by Whitney).
Revert "Title: [LOOPINFO] Extend Loop object to add utilities to get the loop"
Wed, Jun 5, 8:32 AM
Whitney added a reverting change for rGd34797dfc26c: Title: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds…: rG590b1aee609d: Revert "Title: [LOOPINFO] Extend Loop object to add utilities to get the loop".
Wed, Jun 5, 8:32 AM
Whitney committed rGd34797dfc26c: Title: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds… (authored by Whitney).
Title: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds…
Wed, Jun 5, 7:32 AM

Tue, Jun 4

Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Tue, Jun 4, 10:29 AM · Restricted Project

Mon, Jun 3

Whitney added a comment to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

If there are no further comments or concerns, I will commit this patch on this Wed.

Mon, Jun 3, 11:00 AM · Restricted Project

Wed, May 29

Whitney retitled D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable. from [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch. to [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Wed, May 29, 11:29 AM · Restricted Project
Whitney added a comment to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

@fhahn Thanks for your review. Do you think this is better now? Is there some areas you would like me to look into more?

Wed, May 29, 6:23 AM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Wed, May 29, 6:21 AM · Restricted Project

Tue, May 28

Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Tue, May 28, 1:49 PM · Restricted Project

Sat, May 25

Whitney updated the diff for D62418: [MustExecute] Improve MustExecute to correctly handle loop nest.

Addressed all review comments.

Sat, May 25, 9:41 AM · Restricted Project

Fri, May 24

Whitney created D62418: [MustExecute] Improve MustExecute to correctly handle loop nest.
Fri, May 24, 12:32 PM · Restricted Project

Wed, May 22

Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Wed, May 22, 2:32 PM · Restricted Project

May 17 2019

Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 17 2019, 1:35 PM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 17 2019, 1:34 PM · Restricted Project

May 16 2019

Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 16 2019, 2:37 PM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

rebase

May 16 2019, 2:10 PM · Restricted Project

May 15 2019

Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 15 2019, 11:57 AM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 15 2019, 11:57 AM · Restricted Project

May 14 2019

Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 14 2019, 5:39 PM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 14 2019, 5:39 PM · Restricted Project

May 13 2019

Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 13 2019, 6:40 PM · Restricted Project
Whitney added a comment to D61329: Save the induction binary operator in IVDescriptors for non FP induction variables..

Any comments?

May 13 2019, 2:21 PM · Restricted Project

May 12 2019

Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 12 2019, 11:39 AM · Restricted Project

May 9 2019

Whitney updated the diff for D61329: Save the induction binary operator in IVDescriptors for non FP induction variables..
May 9 2019, 2:18 PM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 9 2019, 2:13 PM · Restricted Project

May 2 2019

Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 2 2019, 12:14 PM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 2 2019, 6:50 AM · Restricted Project

May 1 2019

Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 1 2019, 3:53 PM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 1 2019, 10:46 AM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
May 1 2019, 7:35 AM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

Addressed all the easier review comments first.

May 1 2019, 7:34 AM · Restricted Project

Apr 30 2019

Whitney updated the diff for D61329: Save the induction binary operator in IVDescriptors for non FP induction variables..

clang-format

Apr 30 2019, 12:54 PM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 30 2019, 12:18 PM · Restricted Project
Whitney created D61329: Save the induction binary operator in IVDescriptors for non FP induction variables..
Apr 30 2019, 11:36 AM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 30 2019, 1:33 AM · Restricted Project

Apr 25 2019

Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 25 2019, 8:00 AM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

Addressed all review comments I got so far.

Apr 25 2019, 8:00 AM · Restricted Project

Apr 24 2019

Whitney added a comment to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

I have addressed all review comments given so far. Please let me know if I missed any or if there are areas which require more changes. Thanks.

Apr 24 2019, 9:50 AM · Restricted Project

Apr 22 2019

Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 22 2019, 8:00 PM · Restricted Project

Apr 16 2019

Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 16 2019, 12:08 PM · Restricted Project
Whitney added a comment to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

Right, that's the plan. The only user in this patch is loop interchange. The next user will be loop fusion. And we expect more and more passes which need to get loop information to use this common interface.

Apr 16 2019, 11:38 AM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 16 2019, 11:31 AM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 16 2019, 11:30 AM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 16 2019, 8:17 AM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 16 2019, 8:17 AM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 16 2019, 7:25 AM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 16 2019, 7:24 AM · Restricted Project

Apr 12 2019

Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 12 2019, 9:01 AM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 12 2019, 9:01 AM · Restricted Project

Apr 11 2019

Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 11 2019, 5:14 PM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

Edit comments.

Apr 11 2019, 5:10 PM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 11 2019, 1:46 PM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 11 2019, 1:40 PM · Restricted Project
Whitney updated the diff for D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

Addressed the easier comments first.

Apr 11 2019, 10:33 AM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 11 2019, 10:33 AM · Restricted Project
Whitney added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 11 2019, 10:16 AM · Restricted Project
Whitney created D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 11 2019, 7:12 AM · Restricted Project

Feb 8 2019

Whitney added a comment to D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).

@nemanjai That will be great, thanks!

Feb 8 2019, 5:27 AM · Restricted Project

Feb 7 2019

Whitney added inline comments to D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).
Feb 7 2019, 5:15 PM · Restricted Project

Feb 4 2019

Herald added a project to D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)): Restricted Project.

ping

Feb 4 2019, 10:25 AM · Restricted Project

Jan 30 2019

Whitney added a comment to D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).

@evandro Added a test for AArch64.

Jan 30 2019, 1:59 PM · Restricted Project
Whitney updated the diff for D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).
Jan 30 2019, 1:55 PM · Restricted Project
Whitney added a comment to D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).

@fhahn We have also consider adding to SimplifyLibCalls.cpp. Since pow(X, 0.25) was proposed as an IR transform in D49306, but it was not clearly justifiable as a canonicalization, and pow(X, 0.25) is implemented in DAGCombiner, we decided that it would be best to put pow(X, 0.75) in DAGCombiner as well.

Jan 30 2019, 1:08 PM · Restricted Project
Whitney added a comment to D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).

@evandro Why do we want to add new cases in test/Transforms/InstCombine/pow-sqrt.ll? Am I right that InstCombine tests opt? This new changes happen in llc.

Jan 30 2019, 11:53 AM · Restricted Project

Jan 29 2019

Whitney created D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).
Jan 29 2019, 6:40 PM · Restricted Project