This is an archive of the discontinued LLVM Phabricator instance.

[llvm-shlib] Fix cross-compilation for LLVM-C
ClosedPublic

Authored by smeenai on Mar 29 2019, 7:36 PM.

Details

Summary

When we're cross-compiling, build and use a native llvm-nm instead of
attempting to use the one from the target's build tree.

A nice follow-up would be to add a cache variable to allow specifying a
path to an external native llvm-nm instead of building one ourselves,
similar to LLVM_TABLEGEN and LLVM_CONFIG_PATH.

Event Timeline

smeenai created this revision.Mar 29 2019, 7:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2019, 7:36 PM
phosek accepted this revision.Mar 29 2019, 8:05 PM

LGTM

This revision is now accepted and ready to land.Mar 29 2019, 8:05 PM
Wallbraker accepted this revision.Apr 1 2019, 2:28 PM

I can't comment to much on the cmake as my cmake-fu is weak, but from what I can tell it looks good.

This revision was automatically updated to reflect the committed changes.