Page MenuHomePhabricator

Wallbraker (Jakob Bornecrantz)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 23 2015, 11:13 AM (186 w, 3 d)

Recent Activity

Mon, Jun 24

Wallbraker added a comment to D63717: [LLVM-C] Add LLVM-C.dll to Windows installer package.

Thanks for the review!

Mon, Jun 24, 1:05 PM · Restricted Project
Wallbraker updated the summary of D63717: [LLVM-C] Add LLVM-C.dll to Windows installer package.
Mon, Jun 24, 7:49 AM · Restricted Project
Wallbraker created D63717: [LLVM-C] Add LLVM-C.dll to Windows installer package.
Mon, Jun 24, 7:45 AM · Restricted Project

Apr 1 2019

Wallbraker accepted D60025: [llvm-shlib] Fix cross-compilation for LLVM-C.

I can't comment to much on the cmake as my cmake-fu is weak, but from what I can tell it looks good.

Apr 1 2019, 2:29 PM · Restricted Project

Jan 29 2019

Wallbraker added a comment to D56781: Use response file when generating LLVM-C.dll.

Thank you for testing and your feedback!

Jan 29 2019, 3:09 PM · Restricted Project
Wallbraker updated the diff for D56781: Use response file when generating LLVM-C.dll.

Typo fixed, I only see one llvm-shlib/CMakeLists.txt file.

Jan 29 2019, 11:09 AM · Restricted Project
Wallbraker added a comment to D56781: Use response file when generating LLVM-C.dll.

Ugh, I see some types, let me respin.

Jan 29 2019, 11:04 AM · Restricted Project
Wallbraker added a comment to D56781: Use response file when generating LLVM-C.dll.

This should fix it, doing a build now.

Jan 29 2019, 10:52 AM · Restricted Project
Wallbraker updated the diff for D56781: Use response file when generating LLVM-C.dll.

Refactor loop

Jan 29 2019, 10:52 AM · Restricted Project
Wallbraker reopened D56781: Use response file when generating LLVM-C.dll.
Jan 29 2019, 8:37 AM · Restricted Project
Wallbraker updated the diff for D56781: Use response file when generating LLVM-C.dll.

Okay, I have updated the patch now with the suggestions from @stella.stamenova, thanks! Please try it out, I'm currently running a build myself using ninja to make sure that it still works.

Jan 29 2019, 8:37 AM · Restricted Project

Jan 25 2019

Wallbraker added a comment to D56774: Build LLVM-C.dll by default on windows and enable in release package.

Thanks! As I don't have commit access I will need somebody to land this, thanks!

Jan 25 2019, 4:49 AM

Jan 24 2019

Wallbraker added inline comments to D56774: Build LLVM-C.dll by default on windows and enable in release package.
Jan 24 2019, 5:49 AM
Wallbraker reopened D56774: Build LLVM-C.dll by default on windows and enable in release package.

@hans @serge-sans-paille I'm re-opening this again as the fixes have landed. Build tested the latest master with the change on.

Jan 24 2019, 5:11 AM
Wallbraker updated the diff for D56774: Build LLVM-C.dll by default on windows and enable in release package.
Jan 24 2019, 5:10 AM

Jan 22 2019

Wallbraker added a comment to D56781: Use response file when generating LLVM-C.dll.

@serge-sans-paille I do not, so that would be greatly appreciated.

Jan 22 2019, 5:26 AM · Restricted Project

Jan 17 2019

Wallbraker updated the diff for D56781: Use response file when generating LLVM-C.dll.

Thanks, this should fix all concerns raised, I tested this as well and seems to work.

Jan 17 2019, 2:41 AM · Restricted Project

Jan 16 2019

Wallbraker added a comment to D56781: Use response file when generating LLVM-C.dll.

@hans @serge-sans-paille So I built the package and has verified that the LLVM-C.dll is included in the package but I could not find the LLVM-C.lib file tho. After some hours of digging through the multitude of *.cmake files I have to admit defeat on how to get that in there, any pointers would be very much welcome.

Jan 16 2019, 2:42 PM · Restricted Project
Wallbraker updated the diff for D56781: Use response file when generating LLVM-C.dll.

Have now tested this patch and confirmed that it is working for me at least. Needed to make the libs argument optional or the python script would error out. I did not see any sign of $(Configuration) in my scripts.

Jan 16 2019, 7:36 AM · Restricted Project
Wallbraker updated the diff for D56781: Use response file when generating LLVM-C.dll.

Should address all of the comments, haven't done anything the $(Configuration) @hans saw in the error message. Well setup something to test this.

Jan 16 2019, 6:46 AM · Restricted Project
Wallbraker updated the diff for D56781: Use response file when generating LLVM-C.dll.

And remove the parentheses.

Jan 16 2019, 6:46 AM · Restricted Project
Wallbraker added a comment to D56781: Use response file when generating LLVM-C.dll.

Not tested, will address last comment and then setup something I can test this on.

Jan 16 2019, 6:39 AM · Restricted Project
Wallbraker added a comment to D56781: Use response file when generating LLVM-C.dll.

I actually tried the patch and got

Jan 16 2019, 6:35 AM · Restricted Project
Wallbraker updated the diff for D56781: Use response file when generating LLVM-C.dll.

Updated changes with comments from @serge-sans-paille, thanks!

Jan 16 2019, 6:26 AM · Restricted Project
Wallbraker created D56781: Use response file when generating LLVM-C.dll.
Jan 16 2019, 5:49 AM · Restricted Project
Wallbraker updated subscribers of D56774: Build LLVM-C.dll by default on windows and enable in release package.

No I don't have commit access, so please feel free to commit. Will this land before the branch point and also make it out in that release?

Jan 16 2019, 3:31 AM
Wallbraker created D56774: Build LLVM-C.dll by default on windows and enable in release package.
Jan 16 2019, 1:31 AM

Aug 27 2018

Wallbraker added inline comments to D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 27 2018, 10:37 AM
Wallbraker added a comment to D47179: [LLVM-C] Add Bindings For Named Metadata.

The C-API changes looks good to me and the logic makes sense. Just one nit.

Aug 27 2018, 10:19 AM

Aug 22 2018

Wallbraker created D51141: [C-API][DIBuilder] Use NameLen in LLVMDIBuilderCreateParameterVariable.
Aug 22 2018, 4:31 PM

Aug 9 2018

Wallbraker resigned from D19641: Add an alternative to LLVMMDNode that will only accept metadata as argument..
Aug 9 2018, 3:20 AM
Wallbraker resigned from D27616: Add LLVM-C interface for Windows x64 SEH instructions.

This can be closed, as changes has landed in a different review. See D45100.

Aug 9 2018, 3:18 AM

Aug 7 2018

Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Can this please please please be pushed ASAP so it can go in to the 7.0 release?

ask @hans if he can merge it to 7.0 branch :)

I'd prefer not to merge it. Since this is a new feature that's been in the pipe for over a year, I don't think we should rush it in now. It would be better to let it land safely on trunk, get any kinks worked out and then have it be part of the next release.

We should also check whether this will become part of the installer automatically, you can see how its built in utils/release/build_llvm_package.bat, or if that needs some update.

Aug 7 2018, 11:06 AM
Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Can this please please please be pushed ASAP so it can go in to the 7.0 release?

Aug 7 2018, 3:50 AM

Aug 6 2018

Wallbraker added a comment to D30356: Add LLVM-C interface for Windows x64 SEH instructions.

See D45100.

Aug 6 2018, 7:31 AM
Wallbraker abandoned D30356: Add LLVM-C interface for Windows x64 SEH instructions.

This has is already in the C API now, so closing.

Aug 6 2018, 7:27 AM
Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

That should be all of the comments done.

Aug 6 2018, 6:41 AM
Wallbraker updated the diff for D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Updated with @bhelyer changes and updated to latest master.

Aug 6 2018, 6:39 AM

Jul 8 2018

Wallbraker updated the diff for D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Another update of the commit for llvm master.

Jul 8 2018, 9:23 AM

Apr 6 2018

Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Added people who seems to be doing stuff with cmake on windows.

Apr 6 2018, 9:02 AM
Wallbraker updated the summary of D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.
Apr 6 2018, 9:02 AM
Wallbraker updated the diff for D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Updated the diff to master, haven't build tested yet.

Apr 6 2018, 8:46 AM
Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Thanks for testing again @Memnarch, I'm going to update this changeset soon and then try to get it included in LLVM Weekly.

Apr 6 2018, 7:08 AM

Oct 20 2017

Wallbraker updated the diff for D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

This is a NFC update to the patch, bringing it up to master. As I wrote above I can't test it, but should work just fine.

Oct 20 2017, 9:49 AM
Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

No sorry, I moved and started a new job. And don't have access to the windows machine for a while.

Oct 20 2017, 9:20 AM

Sep 21 2017

Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Ping?

Sep 21 2017, 2:17 PM

Sep 14 2017

Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

I don't have commit access so I need somebody to commit this for me, it has been like a month since I got the first LGTM on this review.

Sep 14 2017, 5:59 AM

Sep 7 2017

Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

That looks much better. When in doubt, you can always download the revisions from the most recent(or any other diff) to make those changes based on those.

Sep 7 2017, 9:42 AM
Wallbraker updated the diff for D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

This should not have any other changes, I think. Problem is I do not know which revision the old one was based on.

Sep 7 2017, 8:30 AM
Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

I have updated the commit to use for locating the libs CMAKE_CFG_INTDIR and should fix the issue @Memnarch saw. I only have build tools installed so I don't know if I can test it under a Visual Studio like environment.

Cheers, Jakob.

Can you check your diff? Expected changes in "tools/llvm-shlib/CMakeLists.txt" only but all files are modified with other changes(compare the new diff with the previous one)

Sep 7 2017, 7:46 AM
Wallbraker updated the diff for D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

I have updated the commit to use for locating the libs CMAKE_CFG_INTDIR and should fix the issue @Memnarch saw. I only have build tools installed so I don't know if I can test it under a Visual Studio like environment.

Sep 7 2017, 6:14 AM

Aug 10 2017

Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Thanks for the review, I do not have commit access so somebody needs to commit this for me.

Aug 10 2017, 3:03 PM

Jul 22 2017

Wallbraker updated the diff for D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

I don't think this should be added as a new tool. We support generating LLVM-C.dylib on Darwin via the tools/llvm-shlib tool. It would be better if this were added there instead of completely separate.

Jul 22 2017, 6:24 AM

Jul 17 2017

Wallbraker added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Ping?

Jul 17 2017, 9:19 AM

Jul 6 2017

Wallbraker created D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.
Jul 6 2017, 11:15 AM

Apr 23 2017

Wallbraker requested changes to D32368: LLVM C DIBuilder Creation APIs.

Hey cool that you are doing this work, finally!

Apr 23 2017, 2:24 PM

Apr 10 2017

Wallbraker added inline comments to D31898: Introduce libLTO C APIs to target the "resolution-based" new LTO API.
Apr 10 2017, 3:04 PM

Feb 28 2017

Wallbraker updated the diff for D30356: Add LLVM-C interface for Windows x64 SEH instructions.

Only spotted one case of a Value not being cloned. Others use DeclareBB.

Feb 28 2017, 7:17 PM
Wallbraker added a comment to D30356: Add LLVM-C interface for Windows x64 SEH instructions.

I think that's the last of the changes needed for the echo.cpp files, can we agree on something for the LLVMBuildCallInPad function and have somebody that knows more of what the IR should look like comment on the IR file.

Feb 28 2017, 5:06 PM
Wallbraker updated the diff for D30356: Add LLVM-C interface for Windows x64 SEH instructions.

Last update from Bernard.

Feb 28 2017, 4:58 PM

Feb 26 2017

Wallbraker updated the summary of D30356: Add LLVM-C interface for Windows x64 SEH instructions.
Feb 26 2017, 3:59 PM
Wallbraker added inline comments to D30356: Add LLVM-C interface for Windows x64 SEH instructions.
Feb 26 2017, 3:56 PM
Wallbraker updated the diff for D30356: Add LLVM-C interface for Windows x64 SEH instructions.

Fixes for Core.[cpp|h] files.

Feb 26 2017, 3:56 PM
Wallbraker added inline comments to D30356: Add LLVM-C interface for Windows x64 SEH instructions.
Feb 26 2017, 12:57 PM
Wallbraker updated the diff for D30356: Add LLVM-C interface for Windows x64 SEH instructions.

Added the CloneValue call and it now passes the test again. I had to add
ConstantTokenNone and ConstantNullPointer to the clone_constant_imple
function.

Feb 26 2017, 4:04 AM

Feb 25 2017

Wallbraker added inline comments to D30356: Add LLVM-C interface for Windows x64 SEH instructions.
Feb 25 2017, 9:17 AM
Wallbraker updated the diff for D30356: Add LLVM-C interface for Windows x64 SEH instructions.

Adding newline to end of file.

Feb 25 2017, 6:33 AM
Wallbraker updated the diff for D30356: Add LLVM-C interface for Windows x64 SEH instructions.
Feb 25 2017, 6:31 AM
Wallbraker added a comment to D30356: Add LLVM-C interface for Windows x64 SEH instructions.
Feb 25 2017, 6:29 AM
Wallbraker updated the diff for D30356: Add LLVM-C interface for Windows x64 SEH instructions.

Updated diff from Bernard.

Feb 25 2017, 6:03 AM

Feb 24 2017

Wallbraker created D30356: Add LLVM-C interface for Windows x64 SEH instructions.
Feb 24 2017, 2:35 PM

Feb 15 2017

Wallbraker requested changes to D27616: Add LLVM-C interface for Windows x64 SEH instructions.
Feb 15 2017, 4:35 AM

Aug 18 2016

Wallbraker accepted D23655: [ELF] - Fix for PR28976 - Corrupted section contents when using linker scripts.

This works for my test case as well, nice work! :D

Aug 18 2016, 6:51 AM

Aug 16 2016

Wallbraker accepted D23565: [ELF] Linkerscript: fix relocation offsets.

This commit compiles, fixes my test case and my full code now links correctly! Awesome thanks.

Aug 16 2016, 11:27 AM · lld
Wallbraker added a comment to D23565: [ELF] Linkerscript: fix relocation offsets.

This change gives me linking errors when I try to compile it on git head.

Aug 16 2016, 10:18 AM · lld

Aug 3 2016

Wallbraker updated subscribers of D22683: [ELF] Symbol assignment within input section list.
Aug 3 2016, 5:35 PM · lld

Jun 8 2016

Wallbraker requested changes to D19181: Map Attribute in the C API..

I would like to see something that adds the integer and string attributes that @jyknight brought up, so we know they work before we commit to this API.

Jun 8 2016, 3:40 AM

May 23 2016

Wallbraker added a comment to D20417: Extract renaming from D19181.

Considering how long the other Attribute review is taking just remove the function all together, and put it in once we actually have the finished interface down.

May 23 2016, 2:58 AM

Apr 28 2016

Wallbraker added a comment to D19181: Map Attribute in the C API..

I kind of prefer the AttributeSet approach, but don't feel to strongly about it.

Apr 28 2016, 2:38 AM
Wallbraker requested changes to D19641: Add an alternative to LLVMMDNode that will only accept metadata as argument..

I strongly feel that we should just add new function and then remove the old ones the release after.

Apr 28 2016, 2:33 AM

Apr 25 2016

Wallbraker accepted D19448: Introducing LLVMMetadataRef.

Looks good to me!

Apr 25 2016, 4:06 PM
Wallbraker added a comment to D19448: Introducing LLVMMetadataRef.

So they are completely redoing[1] the debug info interface which this is a precursor for, so I dunno how much benefit this will give us right now.

Apr 25 2016, 2:50 PM

Apr 21 2016

Wallbraker accepted D19173: Add utility function to manipulate attributes on CallSite. NFC.

I don't know that much about llvm internals, but this seems to make sense.

Apr 21 2016, 11:52 AM
Wallbraker added a comment to D19190: [ELF] - Implemented PROVIDE linker script command..

As I was reading this patch and comments I had some concerns about the different behavior between bfd and gold and that error messages would not provide enough information. The patch seem to address these concern so I'm happy with this patch.

Apr 21 2016, 8:49 AM

Apr 19 2016

Wallbraker requested changes to D19181: Map Attribute in the C API..

I thought we came to the conclusion that we should add new functions and not change ABI on the old ones. Yes this will mean copies of the functions but its only for a release.

Apr 19 2016, 4:49 PM
Wallbraker accepted D19081: Add LLVMGetAttrKindIDInContext in the C API in order to facilitate migration away from LLVMAttribute.

Looks good, thanks!

Apr 19 2016, 2:35 PM

Apr 17 2016

Wallbraker added a comment to D19088: [Draft] Possible mapping of DIBuilder in the C API.

I'm not sure that this is worth the effort and code churn.

Apr 17 2016, 7:28 AM
Wallbraker requested changes to D19081: Add LLVMGetAttrKindIDInContext in the C API in order to facilitate migration away from LLVMAttribute.

Maybe not the links but put in the comment that its function/arg/return attributes that this functions returns, and mention that they are listed in the language reference.

Apr 17 2016, 6:12 AM

Apr 13 2016

Wallbraker requested changes to D19081: Add LLVMGetAttrKindIDInContext in the C API in order to facilitate migration away from LLVMAttribute.

About the code:
The function requires documentation. Is there a list of attributes somewhere? What does it return on failure? How long are the values returned valid? Per context, per thread, per process, per release?

Apr 13 2016, 11:22 PM
Wallbraker added a comment to D18749: Add LLVMGetAttrKindIDInContext in the C API in order to facilitate migration away from LLVMAttribute.

Whelp that was a bit fast.

Apr 13 2016, 10:03 PM

Apr 7 2016

Wallbraker added a comment to D18727: Add support for attribute in the C API.
In D18727#391285, @rnk wrote:

First, you're breaking compatibility here with old programs using LLVMAttribute. We should ask Jeurgen about that. If we decide that LLVM's underlying attribute handling has changed so drastically that we're OK with a break, then we should delete the LLVMAttribute enum.

Apr 7 2016, 8:14 AM

Apr 5 2016

Wallbraker added a reviewer for D18749: Add LLVMGetAttrKindIDInContext in the C API in order to facilitate migration away from LLVMAttribute: rafael.
Apr 5 2016, 7:57 AM
Wallbraker added a comment to D18749: Add LLVMGetAttrKindIDInContext in the C API in order to facilitate migration away from LLVMAttribute.

I want a second opinion on this issue.

Apr 5 2016, 7:56 AM
Wallbraker added a comment to D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.

Looks good, thanks for all the work!

Apr 5 2016, 4:19 AM

Apr 4 2016

Wallbraker added a comment to D18749: Add LLVMGetAttrKindIDInContext in the C API in order to facilitate migration away from LLVMAttribute.

Will this for "uwtable" return the same value as LLVMAttribute.UWtable?

Apr 4 2016, 5:23 AM

Apr 3 2016

Wallbraker added inline comments to D18727: Add support for attribute in the C API.
Apr 3 2016, 4:31 PM
Wallbraker accepted D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 3 2016, 5:08 AM
Wallbraker requested changes to D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 3 2016, 4:47 AM
Wallbraker added a comment to D18727: Add support for attribute in the C API.

You should put the unrelated commits in another one, they are good clean ups.

Apr 3 2016, 3:41 AM
Wallbraker requested changes to D18733: Add support for attribute for call and invoke instruction in the C API.

Can we please have one release with the new and old functions. Removing and adding replacement functions in the same release makes the upgrade path much harder. I can not upgrade the LLVM version I use because it breaks my build (build bots, other users and so on). And I can not change my code without breaking anything that still uses the old version (build bots, other users and so on). This is all made worse that the symbols are still there but their semantics have change, so it will just be hard to debug black magic errors.

Apr 3 2016, 3:18 AM