Page MenuHomePhabricator

Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation
ClosedPublic

Authored by NeHuang on Mar 14 2019, 1:08 PM.

Details

Summary

Did experiments on power 9 machine, checked the outputs for NaN & Infinity+ cases with corresponding DCMX bit set. Confirmed the DCMX mask bit for NaN and infinity+ are reversely set, which is not consistent with the document description.

Fixed the issue and created test cases to cover the two cases.

Diff Detail

Repository
rL LLVM

Event Timeline

NeHuang created this revision.Mar 14 2019, 1:08 PM

The implementation change seems reasonable. I encode the instruction manually and it is correct. LGTM.

stefanp accepted this revision.Mar 29 2019, 3:58 AM

LGTM

This revision is now accepted and ready to land.Mar 29 2019, 3:58 AM
amyk accepted this revision.Mar 29 2019, 7:46 AM

Looks good, thank you for fixing and adding the test case.

@stefanp Victor doesn't have commit access yet. Can you commit this for him?

Thanks all for the review!

@nemanjai
I will commit this for Victor.

This revision was automatically updated to reflect the committed changes.