Page MenuHomePhabricator

Yi-Hong.Lyu (Yi-Hong Lyu)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2019, 2:01 PM (36 w, 6 d)

Recent Activity

Fri, Oct 18

Yi-Hong.Lyu added a comment to D67904: [ARM][MVE] validForTailPredication insts.
Fri, Oct 18, 9:06 AM · Restricted Project

Thu, Oct 10

Yi-Hong.Lyu committed rG2fbfb04ffef4: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed" (authored by Yi-Hong.Lyu).
[PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed"
Thu, Oct 10, 10:34 PM
Yi-Hong.Lyu closed D68344: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed".
Thu, Oct 10, 10:33 PM · Restricted Project
Yi-Hong.Lyu committed rL374515: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed".
[PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed"
Thu, Oct 10, 10:33 PM

Sun, Oct 6

Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Address Roman and Nemanja' comments

Sun, Oct 6, 11:43 PM · Restricted Project
Yi-Hong.Lyu added an edge to rG6088f8439884: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators: D68534: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Sun, Oct 6, 11:34 PM
Yi-Hong.Lyu added 1 commit(s) for D68534: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators: rG6088f8439884: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Sun, Oct 6, 11:34 PM · Restricted Project
Yi-Hong.Lyu committed rG6088f8439884: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators (authored by Yi-Hong.Lyu).
[NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators
Sun, Oct 6, 11:29 PM
Yi-Hong.Lyu added 1 commit(s) for D68534: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators: rL373876: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Sun, Oct 6, 11:29 PM · Restricted Project
Yi-Hong.Lyu added an edge to rL373876: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators: D68534: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Sun, Oct 6, 11:29 PM
Yi-Hong.Lyu closed D68534: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Commited by https://reviews.llvm.org/rL373876

Sun, Oct 6, 11:29 PM · Restricted Project
Yi-Hong.Lyu committed rL373876: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
[NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators
Sun, Oct 6, 10:27 PM

Fri, Oct 4

Yi-Hong.Lyu added a comment to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Test cases are posted here https://reviews.llvm.org/D68534. I would need approval to commit the NFC patch.

Fri, Oct 4, 8:16 PM · Restricted Project
Yi-Hong.Lyu created D68534: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Fri, Oct 4, 8:16 PM · Restricted Project

Thu, Oct 3

Yi-Hong.Lyu added a comment to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

ping ...

Thu, Oct 3, 11:43 AM · Restricted Project

Wed, Oct 2

Yi-Hong.Lyu committed rGc7be06797436: [PowerPC] Fix SH field overflow issue (authored by Yi-Hong.Lyu).
[PowerPC] Fix SH field overflow issue
Wed, Oct 2, 1:28 PM
Yi-Hong.Lyu committed rL373519: [PowerPC] Fix SH field overflow issue.
[PowerPC] Fix SH field overflow issue
Wed, Oct 2, 1:27 PM
Yi-Hong.Lyu closed D66991: [PowerPC] Fix SH field overflow issue.
Wed, Oct 2, 1:27 PM · Restricted Project
Yi-Hong.Lyu created D68344: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed".
Wed, Oct 2, 10:06 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Address Jonsong and Nemanja's comments

Wed, Oct 2, 7:16 AM · Restricted Project

Tue, Oct 1

Yi-Hong.Lyu added a comment to rL373122: For P0784R7: add support for explicit destructor calls and.

Our buildbot http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt seem broken by this patch either.

Tue, Oct 1, 1:41 PM

Mon, Sep 30

Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Mon, Sep 30, 12:40 AM · Restricted Project

Fri, Sep 27

Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Fri, Sep 27, 10:10 AM · Restricted Project

Thu, Sep 26

Yi-Hong.Lyu updated the diff for D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.

Address Amy's comment

Thu, Sep 26, 9:06 PM · Restricted Project
Yi-Hong.Lyu added a comment to D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.

ping ...

Thu, Sep 26, 10:51 AM · Restricted Project
Yi-Hong.Lyu added a comment to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

To see how my transformation affect AArch64 and X86 tests. Please use History to compare Diff 5 (221979) and Diff 6 (221983)

Thu, Sep 26, 10:35 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Add the option -cgp-icmp-eq2icmp-st to enable transformation on AArch64/X86 tests (complete addressing Roman's comments)

Thu, Sep 26, 10:35 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
  1. Address Lei's comments
  2. Add tests for other arches - x86, aarch6 by following Roman 's comments
Thu, Sep 26, 10:26 AM · Restricted Project

Mon, Sep 23

Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Mon, Sep 23, 12:13 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Reduce the MIR test cases (Address Jinsong's comments)

Mon, Sep 23, 12:08 PM · Restricted Project

Sun, Sep 22

Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Address Jinsong's comments

Sun, Sep 22, 1:31 PM · Restricted Project
Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Sun, Sep 22, 1:22 PM · Restricted Project

Sep 18 2019

Yi-Hong.Lyu abandoned D61976: [PowerPC] Reorder CSR reloads in epilogue to follow the same order as CSR saves in the prologue.
Sep 18 2019, 11:08 AM · Restricted Project
Yi-Hong.Lyu updated the summary of D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.
Sep 18 2019, 10:49 AM · Restricted Project
Yi-Hong.Lyu updated the summary of D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.
Sep 18 2019, 10:49 AM · Restricted Project
Yi-Hong.Lyu created D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.
Sep 18 2019, 10:49 AM · Restricted Project

Sep 17 2019

Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Sep 17 2019, 10:20 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Address Jinsong's comment

Sep 17 2019, 10:11 PM · Restricted Project

Sep 8 2019

Yi-Hong.Lyu added a comment to D66991: [PowerPC] Fix SH field overflow issue.

ping

Sep 8 2019, 8:32 PM · Restricted Project

Aug 31 2019

Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Address Stefan's comments

Aug 31 2019, 8:37 PM · Restricted Project
Yi-Hong.Lyu updated the summary of D66991: [PowerPC] Fix SH field overflow issue.
Aug 31 2019, 2:29 PM · Restricted Project

Aug 29 2019

Yi-Hong.Lyu created D66991: [PowerPC] Fix SH field overflow issue.
Aug 29 2019, 9:57 PM · Restricted Project

Jul 23 2019

Yi-Hong.Lyu committed rG41a010a4ef16: [PowerPC] Remove redundant load immediate instructions (authored by Yi-Hong.Lyu).
[PowerPC] Remove redundant load immediate instructions
Jul 23 2019, 12:15 PM
Yi-Hong.Lyu committed rL366840: [PowerPC] Remove redundant load immediate instructions.
[PowerPC] Remove redundant load immediate instructions
Jul 23 2019, 12:11 PM
Yi-Hong.Lyu closed D64220: [PowerPC] Remove redundant load immediate instructions.
Jul 23 2019, 12:11 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D64220: [PowerPC] Remove redundant load immediate instructions.

Address Stefan's review comments

Jul 23 2019, 10:31 AM · Restricted Project

Jul 17 2019

Yi-Hong.Lyu updated subscribers of D64220: [PowerPC] Remove redundant load immediate instructions.
Jul 17 2019, 7:58 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D64220: [PowerPC] Remove redundant load immediate instructions.

Added LLVM IR testcases as requested.

Jul 17 2019, 7:42 AM · Restricted Project

Jul 4 2019

Yi-Hong.Lyu created D64220: [PowerPC] Remove redundant load immediate instructions.
Jul 4 2019, 1:02 PM · Restricted Project

May 22 2019

Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Relax the restriction so we can handle comparisons between two virtual registers equivalently. I rebase the patch to TOT so history would not work. Please review this commit directly.

May 22 2019, 9:11 AM · Restricted Project
Yi-Hong.Lyu created D62261: [PowerPC][NFC] Add test for comparison between two virtual registers.
May 22 2019, 9:05 AM · Restricted Project

May 21 2019

Yi-Hong.Lyu added a comment to D61966: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the same order as CSR saves in the prologue.

It was commited to the wrong place and correct here https://reviews.llvm.org/rG00e85f753583

May 21 2019, 1:31 PM · Restricted Project
Yi-Hong.Lyu added a comment to rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….

Done here https://reviews.llvm.org/rG00e85f753583. Sorry for the inconvenience

May 21 2019, 1:31 PM
Yi-Hong.Lyu committed rG00e85f753583: Move csr-save-restore-order.ll to the right place (authored by Yi-Hong.Lyu).
Move csr-save-restore-order.ll to the right place
May 21 2019, 1:28 PM
Yi-Hong.Lyu committed rL361306: Move csr-save-restore-order.ll to the right place.
Move csr-save-restore-order.ll to the right place
May 21 2019, 1:28 PM
Yi-Hong.Lyu added a comment to rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….

My fault. Should I reverse the commit and commit the right patch again or just create another patch to move it?

May 21 2019, 1:06 PM
Yi-Hong.Lyu closed D61966: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the same order as CSR saves in the prologue.

Forgot adding Differential Revision: in the end of commit https://github.com/llvm/llvm-project/commit/6e19543a2a2013bd357eb15e383b435cd0cbb810. Close it manually.

May 21 2019, 12:57 PM · Restricted Project
Yi-Hong.Lyu committed rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the… (authored by Yi-Hong.Lyu).
[PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the…
May 21 2019, 12:42 PM
Yi-Hong.Lyu committed rL361299: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….
[PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the…
May 21 2019, 12:40 PM

May 17 2019

Yi-Hong.Lyu added inline comments to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
May 17 2019, 10:37 AM · Restricted Project

May 15 2019

Yi-Hong.Lyu created D61976: [PowerPC] Reorder CSR reloads in epilogue to follow the same order as CSR saves in the prologue.
May 15 2019, 7:24 PM · Restricted Project
Yi-Hong.Lyu created D61966: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the same order as CSR saves in the prologue.
May 15 2019, 3:11 PM · Restricted Project

May 9 2019

Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Rebase the master (NFC testcases merged). Since it is a rebased one, please see the latest commit for review

May 9 2019, 9:38 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Change according to comments

May 9 2019, 5:17 AM · Restricted Project
Yi-Hong.Lyu created D61723: [PowerPC] Add tests to show opportunity to make ICMP_EQ use CR result of ICMP_S(L|G)T dominators. NFC.
May 9 2019, 3:51 AM · Restricted Project

May 8 2019

Yi-Hong.Lyu added inline comments to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
May 8 2019, 6:55 AM · Restricted Project

Apr 11 2019

Yi-Hong.Lyu retitled D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators from [PowerPC] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators to [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Apr 11 2019, 8:43 AM · Restricted Project

Apr 10 2019

Yi-Hong.Lyu created D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Apr 10 2019, 5:05 AM · Restricted Project

Mar 27 2019

Yi-Hong.Lyu added a comment to D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

The implementation change seems reasonable. I encode the instruction manually and it is correct. LGTM.

Mar 27 2019, 12:10 PM · Restricted Project

Mar 21 2019

Yi-Hong.Lyu added a comment to D58685: [PowerPC] Remove UseVSXReg.

I think I addressed all the comments above. This is a gentle ping ...

Mar 21 2019, 11:08 AM · Restricted Project

Mar 18 2019

Yi-Hong.Lyu added inline comments to D58685: [PowerPC] Remove UseVSXReg.
Mar 18 2019, 9:33 PM · Restricted Project

Mar 12 2019

Yi-Hong.Lyu added a reviewer for D58685: [PowerPC] Remove UseVSXReg: stefanp.
Mar 12 2019, 3:18 AM · Restricted Project

Mar 5 2019

Yi-Hong.Lyu updated the diff for D58685: [PowerPC] Remove UseVSXReg.

Add default in the switch to address Jinsong's comment

Mar 5 2019, 1:20 PM · Restricted Project

Mar 4 2019

Yi-Hong.Lyu added inline comments to D58685: [PowerPC] Remove UseVSXReg.
Mar 4 2019, 12:59 PM · Restricted Project
Yi-Hong.Lyu added a comment to D58685: [PowerPC] Remove UseVSXReg.

I export LLVM_VERIFY_MACHINEINSTRS=1 and run the LIT/LNT tests with my patch and it pass either.

Mar 4 2019, 11:53 AM · Restricted Project
Yi-Hong.Lyu retitled D58685: [PowerPC] Remove UseVSXReg from [NFC][PowerPC] Remove UseVSXReg to [PowerPC] Remove UseVSXReg.
Mar 4 2019, 9:13 AM · Restricted Project

Mar 3 2019

Yi-Hong.Lyu added a comment to D58685: [PowerPC] Remove UseVSXReg.

By the way, this patch passes Bootstrap, SPEC 2006, SPEC 2017, llvm-on-power/Benchmarks/ tests on power8/power9

Mar 3 2019, 2:32 AM · Restricted Project
Yi-Hong.Lyu added a comment to D58685: [PowerPC] Remove UseVSXReg.

I think using f0 here is OK. Take another instruction lxsdx for example:

$ echo '0x7c 0xe5 0xfc 0x98' | ./build/release/bin/llvm-mc --disassemble -triple powerpc64-unknown-linux-gnu -mcpu=pwr7 -ppc-asm-full-reg-names
        .text
        lxsdx f7, r5, r31

According to the spec, lxsdx will output to VSX[XT]. It uses vsfrc since it only uses first dword (VSX[XT].dword[1] is undefined). That's our intention to print f7 instead of vs7 here. Go back the this case, lxsibzx has the same situation as lxsdx. Besides, XXSPLTWs only uses in the pattern xxspltw XT,XB, 1[1] so it is well-defined to use f0 here (f0.word[1] = vs0.word[1]).

Mar 3 2019, 2:26 AM · Restricted Project

Mar 1 2019

Yi-Hong.Lyu added a comment to rL355133: Add a module pass for order file instrumentation.

This commit seems cause failure of clang-ppc64be-linux (http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/30804), clang-ppc64be-linux-multistage (http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/16234), clang-ppc64be-linux-lnt (http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/25016)

Mar 1 2019, 7:45 AM

Feb 26 2019

Yi-Hong.Lyu retitled D58685: [PowerPC] Remove UseVSXReg from [NFC][PPC] Remove UseVSXReg to [NFC][PowerPC] Remove UseVSXReg.
Feb 26 2019, 10:03 AM · Restricted Project
Yi-Hong.Lyu created D58685: [PowerPC] Remove UseVSXReg.
Feb 26 2019, 10:03 AM · Restricted Project

Feb 13 2019

Yi-Hong.Lyu added a comment to rL353817: tsan: add fiber support.

This patch seems cause failure of buildbot http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/9150

Feb 13 2019, 8:33 AM

Feb 8 2019

Yi-Hong.Lyu added a comment to rL353385: tsan: Implement pthread_exit() interceptor for Thread sanitizer.

This commit seems cause failure in http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/29842

Feb 8 2019, 7:58 AM

Feb 5 2019

Yi-Hong.Lyu added a comment to rL353131: [WebAssembly] Make disassembler always emit most canonical name..

This commit cause failure on clang-ppc64be-linux-lnt

Feb 5 2019, 2:07 PM