Page MenuHomePhabricator

Yi-Hong.Lyu (Yi-Hong Lyu)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2019, 2:01 PM (11 w, 19 h)

Recent Activity

Thu, Apr 11

Yi-Hong.Lyu retitled D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators from [PowerPC] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators to [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Thu, Apr 11, 8:43 AM · Restricted Project

Wed, Apr 10

Yi-Hong.Lyu created D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Wed, Apr 10, 5:05 AM · Restricted Project

Wed, Mar 27

Yi-Hong.Lyu added a comment to D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

The implementation change seems reasonable. I encode the instruction manually and it is correct. LGTM.

Wed, Mar 27, 12:10 PM · Restricted Project

Mar 21 2019

Yi-Hong.Lyu added a comment to D58685: [PowerPC] Remove UseVSXReg.

I think I addressed all the comments above. This is a gentle ping ...

Mar 21 2019, 11:08 AM · Restricted Project

Mar 18 2019

Yi-Hong.Lyu added inline comments to D58685: [PowerPC] Remove UseVSXReg.
Mar 18 2019, 9:33 PM · Restricted Project

Mar 12 2019

Yi-Hong.Lyu added a reviewer for D58685: [PowerPC] Remove UseVSXReg: stefanp.
Mar 12 2019, 3:18 AM · Restricted Project

Mar 5 2019

Yi-Hong.Lyu updated the diff for D58685: [PowerPC] Remove UseVSXReg.

Add default in the switch to address Jinsong's comment

Mar 5 2019, 1:20 PM · Restricted Project

Mar 4 2019

Yi-Hong.Lyu added inline comments to D58685: [PowerPC] Remove UseVSXReg.
Mar 4 2019, 12:59 PM · Restricted Project
Yi-Hong.Lyu added a comment to D58685: [PowerPC] Remove UseVSXReg.

I export LLVM_VERIFY_MACHINEINSTRS=1 and run the LIT/LNT tests with my patch and it pass either.

Mar 4 2019, 11:53 AM · Restricted Project
Yi-Hong.Lyu retitled D58685: [PowerPC] Remove UseVSXReg from [NFC][PowerPC] Remove UseVSXReg to [PowerPC] Remove UseVSXReg.
Mar 4 2019, 9:13 AM · Restricted Project

Mar 3 2019

Yi-Hong.Lyu added a comment to D58685: [PowerPC] Remove UseVSXReg.

By the way, this patch passes Bootstrap, SPEC 2006, SPEC 2017, llvm-on-power/Benchmarks/ tests on power8/power9

Mar 3 2019, 2:32 AM · Restricted Project
Yi-Hong.Lyu added a comment to D58685: [PowerPC] Remove UseVSXReg.

I think using f0 here is OK. Take another instruction lxsdx for example:

$ echo '0x7c 0xe5 0xfc 0x98' | ./build/release/bin/llvm-mc --disassemble -triple powerpc64-unknown-linux-gnu -mcpu=pwr7 -ppc-asm-full-reg-names
        .text
        lxsdx f7, r5, r31

According to the spec, lxsdx will output to VSX[XT]. It uses vsfrc since it only uses first dword (VSX[XT].dword[1] is undefined). That's our intention to print f7 instead of vs7 here. Go back the this case, lxsibzx has the same situation as lxsdx. Besides, XXSPLTWs only uses in the pattern xxspltw XT,XB, 1[1] so it is well-defined to use f0 here (f0.word[1] = vs0.word[1]).

Mar 3 2019, 2:26 AM · Restricted Project

Mar 1 2019

Yi-Hong.Lyu added a comment to rL355133: Add a module pass for order file instrumentation.

This commit seems cause failure of clang-ppc64be-linux (http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/30804), clang-ppc64be-linux-multistage (http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/16234), clang-ppc64be-linux-lnt (http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/25016)

Mar 1 2019, 7:45 AM

Feb 26 2019

Yi-Hong.Lyu retitled D58685: [PowerPC] Remove UseVSXReg from [NFC][PPC] Remove UseVSXReg to [NFC][PowerPC] Remove UseVSXReg.
Feb 26 2019, 10:03 AM · Restricted Project
Yi-Hong.Lyu created D58685: [PowerPC] Remove UseVSXReg.
Feb 26 2019, 10:03 AM · Restricted Project

Feb 13 2019

Yi-Hong.Lyu added a comment to rL353817: tsan: add fiber support.

This patch seems cause failure of buildbot http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/9150

Feb 13 2019, 8:33 AM

Feb 8 2019

Yi-Hong.Lyu added a comment to rL353385: tsan: Implement pthread_exit() interceptor for Thread sanitizer.

This commit seems cause failure in http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/29842

Feb 8 2019, 7:58 AM

Feb 5 2019

Yi-Hong.Lyu added a comment to rL353131: [WebAssembly] Make disassembler always emit most canonical name..

This commit cause failure on clang-ppc64be-linux-lnt

Feb 5 2019, 2:07 PM