User Details
- User Since
- Feb 5 2019, 2:01 PM (215 w, 21 h)
Apr 17 2020
Apr 15 2020
ping
Apr 8 2020
Ping ...
Apr 2 2020
Add a test ConsumeAfterOnePositional
Apr 1 2020
Test vim
Address Mark and clang-tidy's comments
Address clang-tidy's warning and rename local variable for readability.
Feb 6 2020
Please add tests
Jan 28 2020
Jan 23 2020
Jan 22 2020
Jan 21 2020
Jan 20 2020
Jan 8 2020
Nov 11 2019
Nov 8 2019
Pushed here https://github.com/llvm/llvm-project/commit/a3db9c08ebdf1f39ed89f4a7afa09fc153cf98c5. Close it manually since I misuse r as in Differential Revision.
BTW, all comments are addressed and updated accordingly before push
Nov 7 2019
Oct 30 2019
ping ...
Oct 28 2019
Oct 24 2019
Seems this commit broke the buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806
Seems this commit broke the buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6795
Address Nemanja's comments
Seems this commit broke the build http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6794/
Oct 23 2019
Address Roman's comments
Oct 18 2019
Oct 10 2019
Oct 6 2019
Pushed https://reviews.llvm.org/D68534. Rebase the patch to TOT and address Roman and Nemanja' comments
Oct 4 2019
Test cases are posted here https://reviews.llvm.org/D68534. I would need approval to commit the NFC patch.
Oct 3 2019
ping ...
Oct 2 2019
Address Jonsong and Nemanja's comments
Oct 1 2019
Our buildbot http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt seem broken by this patch either.
Sep 30 2019
Sep 27 2019
Sep 26 2019
Address Amy's comment
ping ...
To see how my transformation affect AArch64 and X86 tests. Please use History to compare Diff 5 (221979) and Diff 6 (221983)
Add the option -cgp-icmp-eq2icmp-st to enable transformation on AArch64/X86 tests (complete addressing Roman's comments)
- Address Lei's comments
- Add tests for other arches - X86, AArch64 by following Roman 's comments
Sep 23 2019
Reduce the MIR test cases (Address Jinsong's comments)
Sep 22 2019
Address Jinsong's comments
Sep 18 2019
Sep 17 2019
Address Jinsong's comment
Sep 8 2019
ping
Aug 31 2019
Address Stefan's comments
Aug 29 2019
Jul 23 2019
Address Stefan's review comments
Jul 17 2019
Added LLVM IR testcases as requested.
Jul 4 2019
May 22 2019
Relax the restriction so we can handle comparisons between two virtual registers equivalently. I rebase the patch to TOT so history would not work. Please review this commit directly.
May 21 2019
It was commited to the wrong place and correct here https://reviews.llvm.org/rG00e85f753583
Done here https://reviews.llvm.org/rG00e85f753583. Sorry for the inconvenience
My fault. Should I reverse the commit and commit the right patch again or just create another patch to move it?
Forgot adding Differential Revision: in the end of commit https://github.com/llvm/llvm-project/commit/6e19543a2a2013bd357eb15e383b435cd0cbb810. Close it manually.
May 17 2019
May 15 2019
May 9 2019
Rebase the master (NFC testcases merged). Since it is a rebased one, please see the latest commit for review
Change according to comments
May 8 2019
Apr 11 2019
Apr 10 2019
Mar 27 2019
The implementation change seems reasonable. I encode the instruction manually and it is correct. LGTM.
Mar 21 2019
I think I addressed all the comments above. This is a gentle ping ...