Page MenuHomePhabricator

Yi-Hong.Lyu (Yi-Hong Lyu)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2019, 2:01 PM (215 w, 21 h)

Recent Activity

Apr 17 2020

Yi-Hong.Lyu committed rG54cfc6944e26: [CommandLine] Fix cl::ConsumeAfter support with more than one positional… (authored by Yi-Hong.Lyu).
[CommandLine] Fix cl::ConsumeAfter support with more than one positional…
Apr 17 2020, 2:41 AM
Yi-Hong.Lyu closed D77242: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.
Apr 17 2020, 2:40 AM · Restricted Project
Yi-Hong.Lyu abandoned D77288: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.
Apr 17 2020, 2:40 AM · Restricted Project

Apr 15 2020

Yi-Hong.Lyu added a comment to D77242: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.

ping

Apr 15 2020, 12:36 PM · Restricted Project

Apr 8 2020

Yi-Hong.Lyu added a comment to D77242: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.

Ping ...

Apr 8 2020, 9:45 AM · Restricted Project

Apr 2 2020

Yi-Hong.Lyu updated the diff for D77242: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.

Add a test ConsumeAfterOnePositional

Apr 2 2020, 12:28 PM · Restricted Project

Apr 1 2020

Yi-Hong.Lyu updated the diff for D77288: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.

Test vim

Apr 1 2020, 11:57 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D77288: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.

Address Mark and clang-tidy's comments

Apr 1 2020, 11:23 PM · Restricted Project
Yi-Hong.Lyu created D77288: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.
Apr 1 2020, 10:50 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D77242: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.
Apr 1 2020, 9:46 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D77242: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.

Address clang-tidy's warning and rename local variable for readability.

Apr 1 2020, 5:26 PM · Restricted Project
Yi-Hong.Lyu created D77242: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument.
Apr 1 2020, 2:04 PM · Restricted Project

Feb 6 2020

Yi-Hong.Lyu requested changes to D74087: [Sema] Fix Sema checkArgCount function.

Please add tests

Feb 6 2020, 3:46 AM · Restricted Project

Jan 28 2020

Yi-Hong.Lyu accepted D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.
Jan 28 2020, 6:14 PM · Restricted Project, Restricted Project

Jan 23 2020

Yi-Hong.Lyu accepted D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Jan 23 2020, 7:07 AM · Restricted Project, Restricted Project
Yi-Hong.Lyu requested changes to D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Jan 23 2020, 1:33 AM · Restricted Project, Restricted Project

Jan 22 2020

Yi-Hong.Lyu accepted D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Jan 22 2020, 12:05 PM · Restricted Project, Restricted Project

Jan 21 2020

Yi-Hong.Lyu requested changes to D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Jan 21 2020, 10:10 AM · Restricted Project, Restricted Project

Jan 20 2020

Yi-Hong.Lyu requested changes to D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.
Jan 20 2020, 11:50 AM · Restricted Project, Restricted Project

Jan 8 2020

Yi-Hong.Lyu added inline comments to D69835: Add options for PPC to enable/disable using non-volatile CR.
Jan 8 2020, 10:11 AM · Restricted Project

Nov 11 2019

Yi-Hong.Lyu committed rG6bbfafd03782: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators (authored by Yi-Hong.Lyu).
[CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators
Nov 11 2019, 9:36 AM
Yi-Hong.Lyu closed D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Nov 11 2019, 9:36 AM · Restricted Project

Nov 8 2019

Yi-Hong.Lyu committed rGa3db9c08ebdf: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit… (authored by Yi-Hong.Lyu).
[PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit…
Nov 8 2019, 7:40 AM
Yi-Hong.Lyu closed D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.

Pushed here https://github.com/llvm/llvm-project/commit/a3db9c08ebdf1f39ed89f4a7afa09fc153cf98c5. Close it manually since I misuse r as in Differential Revision.

Nov 8 2019, 7:40 AM · Restricted Project
Yi-Hong.Lyu added a comment to D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.

BTW, all comments are addressed and updated accordingly before push

Nov 8 2019, 7:40 AM · Restricted Project

Nov 7 2019

Yi-Hong.Lyu added inline comments to D69835: Add options for PPC to enable/disable using non-volatile CR.
Nov 7 2019, 6:45 AM · Restricted Project

Oct 30 2019

Yi-Hong.Lyu added a comment to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

ping ...

Oct 30 2019, 8:03 PM · Restricted Project

Oct 28 2019

Yi-Hong.Lyu added a comment to D68877: [AArch64][SVE] Implement masked load intrinsics.
Oct 28 2019, 8:26 AM · Restricted Project

Oct 24 2019

Yi-Hong.Lyu added a comment to D68340: Add AIX toolchain and basic linker functionality.

Seems this commit broke the buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806

Oct 24 2019, 1:28 PM · Restricted Project
Yi-Hong.Lyu added a comment to D69112: [NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup.

Seems this commit broke the buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6795

Oct 24 2019, 1:17 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.

Address Nemanja's comments

Oct 24 2019, 1:01 PM · Restricted Project
Yi-Hong.Lyu added a comment to D67161: [clang,ARM] Initial ACLE intrinsics for MVE..

Seems this commit broke the build http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6794/

Oct 24 2019, 10:21 AM · Restricted Project

Oct 23 2019

Yi-Hong.Lyu added inline comments to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Oct 23 2019, 1:04 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Address Roman's comments

Oct 23 2019, 12:54 PM · Restricted Project

Oct 18 2019

Yi-Hong.Lyu added a comment to D67904: [ARM][MVE] validForTailPredication insts.
Oct 18 2019, 9:06 AM · Restricted Project

Oct 10 2019

Yi-Hong.Lyu committed rG2fbfb04ffef4: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed" (authored by Yi-Hong.Lyu).
[PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed"
Oct 10 2019, 10:34 PM
Yi-Hong.Lyu closed D68344: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed".
Oct 10 2019, 10:33 PM · Restricted Project
Yi-Hong.Lyu committed rL374515: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed".
[PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed"
Oct 10 2019, 10:33 PM

Oct 6 2019

Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Pushed https://reviews.llvm.org/D68534. Rebase the patch to TOT and address Roman and Nemanja' comments

Oct 6 2019, 11:43 PM · Restricted Project
Yi-Hong.Lyu committed rG6088f8439884: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators (authored by Yi-Hong.Lyu).
[NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators
Oct 6 2019, 11:29 PM
Yi-Hong.Lyu closed D68534: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Commited by https://reviews.llvm.org/rL373876 and rG6088f84398847152ad97eb1bc0b139a28e879b48

Oct 6 2019, 11:29 PM · Restricted Project
Yi-Hong.Lyu committed rL373876: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
[NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators
Oct 6 2019, 10:27 PM

Oct 4 2019

Yi-Hong.Lyu added a comment to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Test cases are posted here https://reviews.llvm.org/D68534. I would need approval to commit the NFC patch.

Oct 4 2019, 8:16 PM · Restricted Project
Yi-Hong.Lyu created D68534: [NFC][CGP] Tests for making ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Oct 4 2019, 8:16 PM · Restricted Project

Oct 3 2019

Yi-Hong.Lyu added a comment to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

ping ...

Oct 3 2019, 11:43 AM · Restricted Project

Oct 2 2019

Yi-Hong.Lyu committed rGc7be06797436: [PowerPC] Fix SH field overflow issue (authored by Yi-Hong.Lyu).
[PowerPC] Fix SH field overflow issue
Oct 2 2019, 1:28 PM
Yi-Hong.Lyu committed rL373519: [PowerPC] Fix SH field overflow issue.
[PowerPC] Fix SH field overflow issue
Oct 2 2019, 1:27 PM
Yi-Hong.Lyu closed D66991: [PowerPC] Fix SH field overflow issue.
Oct 2 2019, 1:27 PM · Restricted Project
Yi-Hong.Lyu created D68344: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed".
Oct 2 2019, 10:06 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Address Jonsong and Nemanja's comments

Oct 2 2019, 7:16 AM · Restricted Project

Oct 1 2019

Yi-Hong.Lyu added a comment to rL373122: For P0784R7: add support for explicit destructor calls and.

Our buildbot http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt seem broken by this patch either.

Oct 1 2019, 1:41 PM

Sep 30 2019

Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Sep 30 2019, 12:40 AM · Restricted Project

Sep 27 2019

Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Sep 27 2019, 10:10 AM · Restricted Project

Sep 26 2019

Yi-Hong.Lyu updated the diff for D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.

Address Amy's comment

Sep 26 2019, 9:06 PM · Restricted Project
Yi-Hong.Lyu added a comment to D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.

ping ...

Sep 26 2019, 10:51 AM · Restricted Project
Yi-Hong.Lyu added a comment to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

To see how my transformation affect AArch64 and X86 tests. Please use History to compare Diff 5 (221979) and Diff 6 (221983)

Sep 26 2019, 10:35 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Add the option -cgp-icmp-eq2icmp-st to enable transformation on AArch64/X86 tests (complete addressing Roman's comments)

Sep 26 2019, 10:35 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
  1. Address Lei's comments
  2. Add tests for other arches - X86, AArch64 by following Roman 's comments
Sep 26 2019, 10:26 AM · Restricted Project

Sep 23 2019

Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Sep 23 2019, 12:13 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Reduce the MIR test cases (Address Jinsong's comments)

Sep 23 2019, 12:08 PM · Restricted Project

Sep 22 2019

Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Address Jinsong's comments

Sep 22 2019, 1:31 PM · Restricted Project
Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Sep 22 2019, 1:22 PM · Restricted Project

Sep 18 2019

Yi-Hong.Lyu abandoned D61976: [PowerPC] Reorder CSR reloads in epilogue to follow the same order as CSR saves in the prologue.
Sep 18 2019, 11:08 AM · Restricted Project
Yi-Hong.Lyu updated the summary of D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.
Sep 18 2019, 10:49 AM · Restricted Project
Yi-Hong.Lyu updated the summary of D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.
Sep 18 2019, 10:49 AM · Restricted Project
Yi-Hong.Lyu created D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.
Sep 18 2019, 10:49 AM · Restricted Project

Sep 17 2019

Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Sep 17 2019, 10:20 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Address Jinsong's comment

Sep 17 2019, 10:11 PM · Restricted Project

Sep 8 2019

Yi-Hong.Lyu added a comment to D66991: [PowerPC] Fix SH field overflow issue.

ping

Sep 8 2019, 8:32 PM · Restricted Project

Aug 31 2019

Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Address Stefan's comments

Aug 31 2019, 8:37 PM · Restricted Project
Yi-Hong.Lyu updated the summary of D66991: [PowerPC] Fix SH field overflow issue.
Aug 31 2019, 2:29 PM · Restricted Project

Aug 29 2019

Yi-Hong.Lyu created D66991: [PowerPC] Fix SH field overflow issue.
Aug 29 2019, 9:57 PM · Restricted Project

Jul 23 2019

Yi-Hong.Lyu committed rG41a010a4ef16: [PowerPC] Remove redundant load immediate instructions (authored by Yi-Hong.Lyu).
[PowerPC] Remove redundant load immediate instructions
Jul 23 2019, 12:15 PM
Yi-Hong.Lyu committed rL366840: [PowerPC] Remove redundant load immediate instructions.
[PowerPC] Remove redundant load immediate instructions
Jul 23 2019, 12:11 PM
Yi-Hong.Lyu closed D64220: [PowerPC] Remove redundant load immediate instructions.
Jul 23 2019, 12:11 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D64220: [PowerPC] Remove redundant load immediate instructions.

Address Stefan's review comments

Jul 23 2019, 10:31 AM · Restricted Project

Jul 17 2019

Yi-Hong.Lyu updated subscribers of D64220: [PowerPC] Remove redundant load immediate instructions.
Jul 17 2019, 7:58 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D64220: [PowerPC] Remove redundant load immediate instructions.

Added LLVM IR testcases as requested.

Jul 17 2019, 7:42 AM · Restricted Project

Jul 4 2019

Yi-Hong.Lyu created D64220: [PowerPC] Remove redundant load immediate instructions.
Jul 4 2019, 1:02 PM · Restricted Project

May 22 2019

Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Relax the restriction so we can handle comparisons between two virtual registers equivalently. I rebase the patch to TOT so history would not work. Please review this commit directly.

May 22 2019, 9:11 AM · Restricted Project
Yi-Hong.Lyu created D62261: [PowerPC][NFC] Add test for comparison between two virtual registers.
May 22 2019, 9:05 AM · Restricted Project, Restricted Project

May 21 2019

Yi-Hong.Lyu added a comment to D61966: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the same order as CSR saves in the prologue.

It was commited to the wrong place and correct here https://reviews.llvm.org/rG00e85f753583

May 21 2019, 1:31 PM · Restricted Project
Yi-Hong.Lyu added a comment to rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….

Done here https://reviews.llvm.org/rG00e85f753583. Sorry for the inconvenience

May 21 2019, 1:31 PM
Yi-Hong.Lyu committed rG00e85f753583: Move csr-save-restore-order.ll to the right place (authored by Yi-Hong.Lyu).
Move csr-save-restore-order.ll to the right place
May 21 2019, 1:28 PM
Yi-Hong.Lyu committed rL361306: Move csr-save-restore-order.ll to the right place.
Move csr-save-restore-order.ll to the right place
May 21 2019, 1:28 PM
Yi-Hong.Lyu added a comment to rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….

My fault. Should I reverse the commit and commit the right patch again or just create another patch to move it?

May 21 2019, 1:06 PM
Yi-Hong.Lyu closed D61966: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the same order as CSR saves in the prologue.

Forgot adding Differential Revision: in the end of commit https://github.com/llvm/llvm-project/commit/6e19543a2a2013bd357eb15e383b435cd0cbb810. Close it manually.

May 21 2019, 12:57 PM · Restricted Project
Yi-Hong.Lyu committed rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the… (authored by Yi-Hong.Lyu).
[PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the…
May 21 2019, 12:42 PM
Yi-Hong.Lyu committed rL361299: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….
[PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the…
May 21 2019, 12:40 PM

May 17 2019

Yi-Hong.Lyu added inline comments to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
May 17 2019, 10:37 AM · Restricted Project

May 15 2019

Yi-Hong.Lyu created D61976: [PowerPC] Reorder CSR reloads in epilogue to follow the same order as CSR saves in the prologue.
May 15 2019, 7:24 PM · Restricted Project
Yi-Hong.Lyu created D61966: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the same order as CSR saves in the prologue.
May 15 2019, 3:11 PM · Restricted Project

May 9 2019

Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Rebase the master (NFC testcases merged). Since it is a rebased one, please see the latest commit for review

May 9 2019, 9:38 AM · Restricted Project
Yi-Hong.Lyu updated the diff for D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Change according to comments

May 9 2019, 5:17 AM · Restricted Project
Yi-Hong.Lyu created D61723: [PowerPC] Add tests to show opportunity to make ICMP_EQ use CR result of ICMP_S(L|G)T dominators. NFC.
May 9 2019, 3:51 AM · Restricted Project

May 8 2019

Yi-Hong.Lyu added inline comments to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
May 8 2019, 6:55 AM · Restricted Project

Apr 11 2019

Yi-Hong.Lyu retitled D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators from [PowerPC] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators to [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Apr 11 2019, 8:43 AM · Restricted Project

Apr 10 2019

Yi-Hong.Lyu created D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Apr 10 2019, 5:05 AM · Restricted Project

Mar 27 2019

Yi-Hong.Lyu added a comment to D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

The implementation change seems reasonable. I encode the instruction manually and it is correct. LGTM.

Mar 27 2019, 12:10 PM · Restricted Project

Mar 21 2019

Yi-Hong.Lyu added a comment to D58685: [PowerPC] Remove UseVSXReg.

I think I addressed all the comments above. This is a gentle ping ...

Mar 21 2019, 11:08 AM · Restricted Project