Page MenuHomePhabricator

[NFC][PowerPC] Custom PowerPC specific machine-scheduler
ClosedPublic

Authored by steven.zhang on Mar 12 2019, 7:26 PM.

Details

Summary

This patch lays the groundwork for extending the generic machine scheduler by providing a PPC-specific implementation. There are no functional changes as this is an incremental patch that simply provides the necessary overrides which just encapsulate the behavior of the generic scheduler. Subsequent patches will add specific behavior.

Diff Detail

Repository
rL LLVM

Event Timeline

steven.zhang created this revision.Mar 12 2019, 7:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2019, 7:26 PM
jsji accepted this revision.Mar 25 2019, 11:53 AM

LGTM, except for some minor comments change.
Thanks for extending this, it will allow us to tune MachineScheduler specifically for PowerPC going forward.

llvm/lib/Target/PowerPC/PPCMachineScheduler.h
1 ↗(On Diff #190372)

Why an empty first line?

21 ↗(On Diff #190372)

Maybe add "pre RA" in comment too, as "post RA" in below?

21 ↗(On Diff #190372)

Doxgen comment instead? //' -> ///'

28 ↗(On Diff #190372)

Doxgen comment instead?

This revision is now accepted and ready to land.Mar 25 2019, 11:53 AM

Thank you for the review comments. I have addressed all the comments.

This revision was automatically updated to reflect the committed changes.