This is an archive of the discontinued LLVM Phabricator instance.

[Remarks] Refactor remark diagnostic emission in a RemarkStreamer
ClosedPublic

Authored by thegameg on Mar 5 2019, 1:43 PM.

Diff Detail

Repository
rC Clang

Event Timeline

thegameg created this revision.Mar 5 2019, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2019, 1:43 PM
JDevlieghere requested changes to this revision.Mar 5 2019, 3:39 PM
JDevlieghere added inline comments.
clang/lib/CodeGen/CodeGenAction.cpp
279 ↗(On Diff #189396)

This doesn't seem to "set a remark streamer", but rather create one. Shouldn't the method name reflect that, maybe something like createRemarkStreamer? Or is this a pattern used in the LLVMContext?

llvm/include/llvm/IR/LLVMContext.h
258 ↗(On Diff #189396)

You should probably mention that if a RemarkStreamer is set, it will be replaced.

llvm/include/llvm/IR/RemarkStreamer.h
1 ↗(On Diff #189396)

Old license

llvm/lib/IR/RemarkStreamer.cpp
1 ↗(On Diff #189396)

Old license

This revision now requires changes to proceed.Mar 5 2019, 3:39 PM
thegameg updated this revision to Diff 189425.Mar 5 2019, 4:29 PM
thegameg marked 4 inline comments as done.

Thanks Jonas!

This revision is now accepted and ready to land.Mar 5 2019, 5:05 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2019, 6:31 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript