[Remarks] Refactor remark diagnostic emission in a RemarkStreamer

[thegameg]

Summary

This allows us to store more info about where we're emitting the remarks without cluttering LLVMContext.

[JDevlieghere]

clang/lib/CodeGen/CodeGenAction.cpp

279 ↗

(On Diff #189396)

This doesn't seem to "set a remark streamer", but rather create one. Shouldn't the method name reflect that, maybe something like createRemarkStreamer? Or is this a pattern used in the LLVMContext?

llvm/include/llvm/IR/LLVMContext.h

258 ↗

(On Diff #189396)

You should probably mention that if a RemarkStreamer is set, it will be replaced.

llvm/include/llvm/IR/RemarkStreamer.h

1 ↗

(On Diff #189396)

Old license

llvm/lib/IR/RemarkStreamer.cpp

1 ↗

(On Diff #189396)

Old license

[thegameg]

Thanks Jonas!

[JDevlieghere]

LGTM

lib/CodeGen/CodeGenAction.cpp

 #include "llvm/Bitcode/BitcodeReader.h"
 #include "llvm/CodeGen/MachineOptimizationRemarkEmitter.h"
 #include "llvm/IR/DebugInfo.h"
 #include "llvm/IR/DiagnosticInfo.h"
 #include "llvm/IR/DiagnosticPrinter.h"
 #include "llvm/IR/GlobalValue.h"
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/IR/Module.h"
+#include "llvm/IR/RemarkStreamer.h"
 #include "llvm/IRReader/IRReader.h"
 #include "llvm/Linker/Linker.h"
 #include "llvm/Pass.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/SourceMgr.h"
 #include "llvm/Support/Timer.h"
 #include "llvm/Support/ToolOutputFile.h"
 #include "llvm/Support/YAMLTraits.h"
void HandleTranslationUnit(ASTContext &C) override {
         OptRecordFile = llvm::make_unique<llvm::ToolOutputFile>(
             CodeGenOpts.OptRecordFile, EC, sys::fs::F_None);
         if (EC) {
           Diags.Report(diag::err_cannot_open_file) <<
             CodeGenOpts.OptRecordFile << EC.message();
           return;
         }
 
-        Ctx.setDiagnosticsOutputFile(
-            llvm::make_unique<yaml::Output>(OptRecordFile->os()));
+        Ctx.setRemarkStreamer(llvm::make_unique<RemarkStreamer>(
+            CodeGenOpts.OptRecordFile, OptRecordFile->os()));
 
         if (CodeGenOpts.getProfileUse() != CodeGenOptions::ProfileNone)
           Ctx.setDiagnosticsHotnessRequested(true);
       }
 
       // Link each LinkModule into our module.
       if (LinkInModules())
         return;