This is an archive of the discontinued LLVM Phabricator instance.

Use AIX version detection at LLVM run-time
ClosedPublic

Authored by hubert.reinterpretcast on Feb 28 2019, 3:59 PM.

Details

Summary

AIX compilers define macros based on the version of the operating system.

This patch implements updating of versionless AIX triples to include the host AIX version. Also, the host triple detection in the build system is adjusted to strip the AIX version information so that the run-time detection is preferred.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2019, 3:59 PM
xingxue accepted this revision.Mar 1 2019, 9:56 AM

LGTM, thanks.

This revision is now accepted and ready to land.Mar 1 2019, 9:56 AM
unittests/Support/Host.cpp
286

I am wondering if there is a more preferred way to suppress the warning. I don't think we're at the point of having maybe_unused available to us yet.

I'd be happy to commit this patch later this week, but I would appreciate suggestions on alternative methods to suppress the "unused" warning for the internal-linkage helper function.

ormris removed a subscriber: ormris.Mar 6 2019, 2:35 PM
This revision was automatically updated to reflect the committed changes.