Page MenuHomePhabricator

[build] Rename clang-headers to clang-resource-headers

Authored by smeenai on Feb 28 2019, 12:45 PM.



The current install-clang-headers target installs clang's resource
directory headers. This is different from the install-llvm-headers
target, which installs LLVM's API headers. We want to introduce the
corresponding target to clang, and the natural name for that new target
would be install-clang-headers. Rename the existing target to
install-clang-resource-headers to free up the install-clang-headers name
for the new target, following the discussion on cfe-dev [1].

I didn't find any bots on zorg referencing install-clang-headers. I'll
send out another PSA to cfe-dev to accompany this rename.


Diff Detail


Event Timeline

smeenai created this revision.Feb 28 2019, 12:45 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, Restricted Project, jdoerfert and 2 others. · View Herald Transcript
phosek accepted this revision.Feb 28 2019, 6:35 PM


This revision is now accepted and ready to land.Feb 28 2019, 6:35 PM

This looks good, but could you also add an entry in the ReleaseNotes for this.

This looks good, but could you also add an entry in the ReleaseNotes for this.

Will do – thanks for the reminder :)

smeenai updated this revision to Diff 188988.Mar 1 2019, 3:44 PM

Release notes

I added an entry to the release notes. The release notes change only covers the changes in this diff. My plan is to land this, wait for a few days (so that users of the target get broken in an obvious way), and then add the new install-clang-headers target (for installing the API headers); I'll update the release notes again as part of that change.

This revision was automatically updated to reflect the committed changes.