Page MenuHomePhabricator

[clang-tidy] bugprone-string-integer-assignment: Reduce false positives.
ClosedPublic

Authored by courbet on Feb 25 2019, 5:07 AM.

Diff Detail

Event Timeline

courbet created this revision.Feb 25 2019, 5:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2019, 5:07 AM
alexfh added inline comments.Feb 25 2019, 6:49 AM
clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp
55

What about <mask> & <expr>?

62

Please remove the debug output.

64

What about (x % 26) + 'a'?

courbet updated this revision to Diff 188165.Feb 25 2019, 7:04 AM
courbet marked 3 inline comments as done.
  • address review comments
Eugene.Zelenko edited projects, added Restricted Project; removed Restricted Project.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2019, 2:25 PM
courbet updated this revision to Diff 188316.Feb 25 2019, 11:54 PM
  • more tests
MyDeveloperDay added inline comments.
clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp
81

elide {} on small if statements

courbet updated this revision to Diff 188367.Feb 26 2019, 6:52 AM
courbet marked an inline comment as done.
  • cosmetics
JonasToth added inline comments.Feb 27 2019, 4:33 AM
clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp
59

unnecessary braces.

courbet updated this revision to Diff 188690.Feb 28 2019, 2:35 AM
courbet marked an inline comment as done.
  • rebase
  • -more cosmetics
This revision is now accepted and ready to land.Feb 28 2019, 5:28 AM
This revision was automatically updated to reflect the committed changes.