This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] Change "SHT_MIPS_DWARF" to "MIPS_DWARF"
ClosedPublic

Authored by MaskRay on Feb 21 2019, 2:30 AM.

Details

Summary

This is to be consistent with the display of other MIPS section types.
This string is also used by binutils-gdb/binutils/readelf.c:get_mips_section_type_name

Since we are here, reorder the two enum constatns because SHT_MIPS_DWARF < SHT_MIPS_ABIFLAGS.

Diff Detail

Event Timeline

MaskRay created this revision.Feb 21 2019, 2:30 AM

I'd normally ask for a test, but as D58457 has yet to land, I'll fix that up!

tools/llvm-readobj/ELFDumper.cpp
2863–2864

Is there a good reason to reorder this? For diff-ability, it would be better if the ordering is maintained.

MaskRay marked an inline comment as done.Feb 21 2019, 3:16 AM
MaskRay added inline comments.
tools/llvm-readobj/ELFDumper.cpp
2863–2864

Because SHT_MIPS_DWARF < SHT_MIPS_ABIFLAGS and it is the order used in several other places. I can update the description to mention this.

jhenderson accepted this revision.Feb 21 2019, 3:17 AM

Okay, LGTM.

This revision is now accepted and ready to land.Feb 21 2019, 3:17 AM
MaskRay updated this revision to Diff 187755.Feb 21 2019, 3:19 AM
MaskRay edited the summary of this revision. (Show Details)

.

This revision was automatically updated to reflect the committed changes.