The existing ELF symbol and section table testing doesn't test many of the corner-cases or valid values for various ELF properties, including things like binding, visibility, section type and so on. This patch adds a series of tests that test these and other related edge-cases.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Test cases look fine to me, but I would add descriptions about what test is about (where missing), like you did for elf-section-types.test
test/tools/llvm-readobj/elf-symbol-shndx.test | ||
---|---|---|
1 ↗ | (On Diff #187595) | I would add a test description at first. Because when you start the test from explaining the implementation |
Comment Actions
- Add more comments.
- Rebase to remove FIXMEs relating to SHT_MIPS_DWARF.
- Rebase to add required fields for verneed sections.
Comment Actions
LGTM
test/tools/llvm-readobj/elf-section-types.test | ||
---|---|---|
1 ↗ | (On Diff #187760) | nit: all regular maybe? (since machine-specific are tested in elf-machine-specific-section-types.test) |