Page MenuHomePhabricator

[clang][Index] Add a knob to index function parameters in declarations
ClosedPublic

Authored by kadircet on Feb 8 2019, 6:14 AM.

Details

Summary

Parameters in declarations are useful for clangd, so that we can
provide symbol information for them as well. It also helps clangd to be
consistent whether a function's definition is accessible or not.

Diff Detail

Repository
rL LLVM

Event Timeline

kadircet created this revision.Feb 8 2019, 6:14 AM
kadircet updated this revision to Diff 185962.Feb 8 2019, 6:20 AM
  • Also delete comment
hokein accepted this revision.Feb 8 2019, 6:30 AM

The change looks reasonable, I'd wait for a few days before commit in case anyone has concerns.

include/clang/Index/IndexingAction.h
47 ↗(On Diff #185962)

nit: Only meaningful when IndexFunctionLocals is true?

This revision is now accepted and ready to land.Feb 8 2019, 6:30 AM
akyrtzi accepted this revision.Feb 8 2019, 8:39 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2019, 5:02 AM