Page MenuHomePhabricator

Opt documentation bots out of toolchain check
ClosedPublic

Authored by jfb on Jan 31 2019, 9:01 PM.

Details

Summary

Documentation bot clang-tools-sphinx-docs is failing when I commit D57264 because the GCC version it uses is too old (it's on 4.9.2). This doesn't really matter for now, but really you should update it. Work around the issue for now with the cmake opt-out flag, and let bot maintainers update their toolchain asynchronously.

Diff Detail

Repository
rL LLVM

Event Timeline

jfb created this revision.Jan 31 2019, 9:01 PM
jfb added a comment.Jan 31 2019, 9:03 PM

I'll commit this now and see if the bots do what I expect. If so it'll unblock D57264. Bot maintainers still need to update their toolchains! We'll deprecated them eventually, and then the bots will break for real.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 31 2019, 9:03 PM
Closed by commit rL352836: Opt documentation bots out of toolchain check (authored by jfb, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2019, 9:03 PM
jfb added a comment.Jan 31 2019, 10:41 PM

Looking at:
http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs
Seems this change hasn't gotten picked up yet. I assume we need to re-sync that bot with the zorg repo?

jfb added a comment.Feb 1 2019, 9:14 PM
In D57564#1380084, @jfb wrote:

Looking at:
http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs
Seems this change hasn't gotten picked up yet. I assume we need to re-sync that bot with the zorg repo?

The reboot did the trick, the bot now has the flag.