This is an archive of the discontinued LLVM Phabricator instance.

Differential D57560

[clangd] Link libclangAST into clangd tool
AbandonedPublic

Authored by nridge on Jan 31 2019, 6:01 PM.

Download Raw Diff

Details

Reviewers

Diff Detail

Repository

rG LLVM Github Monorepo

Build Status

Buildable 27587
Build 27586: arc lint + arc unit

Event Timeline

nridge created this revision.Jan 31 2019, 6:01 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 31 2019, 6:01 PM

Herald added subscribers: kadircet, arphaman, jkorous and 4 others. · View Herald Transcript

Harbormaster completed remote builds in B27587: Diff 184659.Jan 31 2019, 6:01 PM

Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 31 2019, 6:01 PM

sammccall accepted this revision.Jan 31 2019, 6:06 PM

This revision is now accepted and ready to land.Jan 31 2019, 6:06 PM

Hm, herald is really wonky with lists as of late.
I did not notice this, and landed rL352841 already..

And it turns out that wasn't enough, so i have additionally committed rL352843.
All good after that (other than D57556).

Abandoning as this has been fixed.

Herald added a subscriber: cfe-commits. · View Herald TranscriptMar 30 2019, 7:04 PM

• msteinberg added a subscriber: • msteinberg.Nov 30 2021, 8:44 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2021, 8:44 AM

Herald added a subscriber: usaxena95. · View Herald Transcript

Revision Contents

Path

Size

clang-tools-extra/

clangd/

tool/

1 line

Diff 184659

clang-tools-extra/clangd/tool/CMakeLists.txt

	Show All 11 Lines

	set(CLANGD_XPC_LIBS "")			set(CLANGD_XPC_LIBS "")
	if(CLANGD_BUILD_XPC)			if(CLANGD_BUILD_XPC)
	list(APPEND CLANGD_XPC_LIBS "clangdXpcJsonConversions" "clangdXpcTransport")			list(APPEND CLANGD_XPC_LIBS "clangdXpcJsonConversions" "clangdXpcTransport")
	endif()			endif()

	target_link_libraries(clangd			target_link_libraries(clangd
	PRIVATE			PRIVATE
				clangAST
	clangBasic			clangBasic
	clangTidy			clangTidy
	clangDaemon			clangDaemon
	clangFormat			clangFormat
	clangFrontend			clangFrontend
	clangSema			clangSema
	clangTooling			clangTooling
	clangToolingCore			clangToolingCore
	${CLANGD_XPC_LIBS}			${CLANGD_XPC_LIBS}
	)			)