This is an archive of the discontinued LLVM Phabricator instance.

Differential D57556

Fix for -DBUILD_SHARED_LIBS=ON build after rL352803
AbandonedPublic

Authored by sbc100 on Jan 31 2019, 5:26 PM.

Details

Reviewers
thakis
asb
Summary

Looks like this dependency was added in rL352803:
https://reviews.llvm.org/D57345

Diff Detail

Event Timeline

sbc100 created this revision.Jan 31 2019, 5:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2019, 5:26 PM
Herald added subscribers: aheejin, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B27585: Diff 184651.Jan 31 2019, 5:26 PM
sbc100 added a reviewer: thakis.Jan 31 2019, 5:28 PM
asb accepted this revision.Jan 31 2019, 7:37 PM
asb added a subscriber: asb.

LGTM.

This revision is now accepted and ready to land.Jan 31 2019, 7:37 PM
lebedev.ri added a subscriber: lebedev.ri.Feb 1 2019, 12:47 AM

I'm also hitting this, please land the fix :)

lebedev.ri added a subscriber: cfe-commits.Feb 1 2019, 12:53 AM
lebedev.ri mentioned this in D57560: [clangd] Link libclangAST into clangd tool.Feb 1 2019, 12:59 AM
thakis accepted this revision.Feb 1 2019, 5:19 AM
MaskRay added a subscriber: MaskRay.Feb 1 2019, 6:55 AM

Sorry I didn't notice this. D57345 has been fixed in rC352872

sbc100 abandoned this revision.Feb 1 2019, 9:45 AM

Revision Contents

PathSize
tools/
libclang/
1 line

Diff 184651

tools/libclang/CMakeLists.txt

Show All 30 Linesset(SOURCES
CXType.h CXType.h
Index_Internal.h Index_Internal.h
../../include/clang-c/Index.h ../../include/clang-c/Index.h
) )
set(LIBS set(LIBS
clangAST clangAST
clangBasic clangBasic
clangDriver
clangFrontend clangFrontend
clangIndex clangIndex
clangLex clangLex
clangSema clangSema
clangSerialization clangSerialization
clangTooling clangTooling
) )
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines