This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add bulk memory target feature
ClosedPublic

Authored by tlively on Jan 30 2019, 8:06 PM.

Event Timeline

tlively created this revision.Jan 30 2019, 8:06 PM
aheejin accepted this revision.Jan 30 2019, 11:23 PM
aheejin added inline comments.
llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.td
60

Should we add NotHasBulkMemory for symmetry?

This revision is now accepted and ready to land.Jan 30 2019, 11:23 PM
tlively marked an inline comment as done.Jan 31 2019, 12:59 PM
tlively added inline comments.
llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.td
60

I don't anticipate needing it for anything, so I don't think so.

This revision was automatically updated to reflect the committed changes.

Hmm.. is it OK to make commits to cfe and llvm at the same time now? I thought you were supposed to break them up in the separate commits.

aheejin added a comment.EditedJan 31 2019, 5:49 PM

Hmm.. is it OK to make commits to cfe and llvm at the same time now? I thought you were supposed to break them up in the separate commits.

I guess it's now possible now with the llvm monorepo. I haven't switched yet though.

Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2019, 5:49 PM

Hmm.. is it OK to make commits to cfe and llvm at the same time now? I thought you were supposed to break them up in the separate commits.

I guess it's now possible now with the llvm monorepo. I haven't switched yet though.

‘git llvm push’ takes care of splitting the commit into two subversion commits automatically. I think it might commit them together atomically, too, but I’m not sure.

sbc100 added a comment.Feb 1 2019, 9:57 AM

I only see a single SVN revision number for this: r352793. I'm pretty sure its one commit. But I also see other people doing the same so I guess maybe its just OK to do that now

It's always been possible because clang and LLVM have always just been in different trunks in the same SVN repo. AFAIK it's never been disallowed but people rarely do it.