Page MenuHomePhabricator

binji (Ben Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 12 2014, 2:46 PM (361 w, 2 d)

Recent Activity

Feb 19 2019

binji added a comment to D58312: [WebAssembly] Generalize section ordering constraints.

I'm totally fine with specifying a mostly-linear ordering between sections, including between custom sections that are meaningful to the toolchain. But I think it also makes sense to allow for exceptions to that when it allows for simpler code, as is the case for the unspecified ordering between the producers section and relocation sections. This CL is about changing the mechanism to allow for this exception, not about changing the ordering of existing sections or changing our norm of specifying such orderings. Do you think we should disallow exceptions entirely?

Feb 19 2019, 2:29 PM · Restricted Project
binji added a comment to D58312: [WebAssembly] Generalize section ordering constraints.

Yeah, I'd still prefer to have a total order if that's not too much effort. The alternative introduces a lot of potential complexity into the consumer, since we'll have a combinatorial explosion of possibilities for where these sections can be located, many of which will likely be untested.

I definitely want to reduce overall complexity, not increase it. My assumption is that if consumer code would be simplified by guaranteeing that section A is before section B, then the DAG ordering should be updated to make that ordering required. Sections should only be unordered with respect to each other if consumers are truly agnostic to their order.

In this case, producer code was able to be simplified by loosening the ordering constraints with no corresponding complications in consumer code that I am aware of. @binji, does this seem reasonable? Are there potential complications that I am missing?

Feb 19 2019, 2:02 PM · Restricted Project
binji added a comment to D58312: [WebAssembly] Generalize section ordering constraints.

Yeah, I'd still prefer to have a total order if that's not too much effort. The alternative introduces a lot of potential complexity into the consumer, since we'll have a combinatorial explosion of possibilities for where these sections can be located, many of which will likely be untested.

Feb 19 2019, 11:18 AM · Restricted Project

Oct 29 2015

binji added a comment to D14190: [WebAssembly] Fix import statement.
Oct 29 2015, 5:18 PM
binji updated the diff for D14190: [WebAssembly] Fix import statement.
Oct 29 2015, 5:17 PM
binji retitled D14190: [WebAssembly] Fix import statement from to [WebAssembly] Fix import statement.
Oct 29 2015, 3:53 PM

Oct 17 2015

binji added a comment to D13837: WebAssembly: fix the syntax for comparisons.

lgtm

Oct 17 2015, 12:39 PM

Oct 16 2015

binji added a comment to D13821: WebAssembly: fix load/store syntax.

lgtm

Oct 16 2015, 11:29 AM

Jun 13 2014

binji retitled D4141: Implement predefined stdint macros from to Implement predefined stdint macros.
Jun 13 2014, 2:52 PM