Page MenuHomePhabricator

Revert removal of tidy plugin support from libclang
ClosedPublic

Authored by yvvan on Dec 7 2018, 12:15 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

yvvan created this revision.Dec 7 2018, 12:15 AM
yvvan updated this revision to Diff 177134.Dec 7 2018, 12:17 AM

I generated the wrong diff. This is the proper one.

nik added a comment.Dec 7 2018, 12:45 AM

+1 as this seems to fix the regression.

yvvan added a comment.Dec 7 2018, 12:46 AM

We can also add an extra variable for it if you care about build time

I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it because it slows down builds while not adding value.

yvvan added a comment.Dec 7 2018, 7:15 AM

I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it because it slows down builds while not adding value.

We use it with Qt Creator and you can see that we make additions/fixes in libclang from time to time.
With tidy checks selected it is slow indeed but there's always a choice whether to enable checks or not. And if you have very few checks enabled it performs quite fine. And we are still using libclang because we already have infrastructure on top of it which can't be just replaced with clangd (at least it requires quite some time).

bkramer accepted this revision.Dec 9 2018, 9:57 PM

I think that's a fair point for bringing it back for now. It's not supported though and we will get rid of it eventually.

This revision is now accepted and ready to land.Dec 9 2018, 9:57 PM
This revision was automatically updated to reflect the committed changes.