Page MenuHomePhabricator

nik (Nikolai Kosjar)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2017, 8:22 AM (109 w, 6 d)

Recent Activity

Fri, Jun 14

nik added a comment to D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal.

Any interest in having the *proposal* implemented?

Fri, Jun 14, 5:29 AM · Restricted Project
nik created D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal.
Fri, Jun 14, 5:24 AM · Restricted Project

Wed, Jun 12

nik committed rGf6efac67e18c: [clangd] Fix typo in GUARDED_BY() (authored by nik).
[clangd] Fix typo in GUARDED_BY()
Wed, Jun 12, 3:59 AM
nik committed rL363139: [clangd] Fix typo in GUARDED_BY().
[clangd] Fix typo in GUARDED_BY()
Wed, Jun 12, 3:58 AM
nik closed D63193: [clangd] Fix typo in GUARDED_BY().
Wed, Jun 12, 3:58 AM · Restricted Project, Restricted Project
nik created D63193: [clangd] Fix typo in GUARDED_BY().
Wed, Jun 12, 3:44 AM · Restricted Project, Restricted Project
nik committed rGf763102ad4e9: gitignore: Ignore Qt Creator project configuration files. NFC (authored by nik).
gitignore: Ignore Qt Creator project configuration files. NFC
Wed, Jun 12, 1:26 AM
nik committed rL363129: gitignore: Ignore Qt Creator project configuration files. NFC.
gitignore: Ignore Qt Creator project configuration files. NFC
Wed, Jun 12, 1:25 AM
nik committed rG6fab7d0ef239: [NFC] Test commit (authored by nik).
[NFC] Test commit
Wed, Jun 12, 12:48 AM
nik committed rL363127: [NFC] Test commit.
[NFC] Test commit
Wed, Jun 12, 12:48 AM

Tue, Jun 11

nik committed rGbe8d03a512a0: [clang-tidy] Fix invalid read on destruction (authored by nik).
[clang-tidy] Fix invalid read on destruction
Tue, Jun 11, 7:17 AM
nik committed rL363068: [clang-tidy] Fix invalid read on destruction.
[clang-tidy] Fix invalid read on destruction
Tue, Jun 11, 7:17 AM
nik closed D63129: [clang-tidy] Fix invalid read on destruction.
Tue, Jun 11, 7:17 AM · Restricted Project, Restricted Project
nik committed rG8edd8da4874d: [libclang] Allow skipping warnings from all included files (authored by nik).
[libclang] Allow skipping warnings from all included files
Tue, Jun 11, 7:12 AM
nik committed rL363067: [libclang] Allow skipping warnings from all included files.
[libclang] Allow skipping warnings from all included files
Tue, Jun 11, 7:12 AM
nik closed D48116: [libclang] Allow skipping warnings from all included files.
Tue, Jun 11, 7:12 AM · Restricted Project, Restricted Project
nik added reviewers for D63129: [clang-tidy] Fix invalid read on destruction: gribozavr, alexfh.
Tue, Jun 11, 3:56 AM · Restricted Project, Restricted Project
nik created D63129: [clang-tidy] Fix invalid read on destruction.
Tue, Jun 11, 3:53 AM · Restricted Project, Restricted Project

Thu, Jun 6

nik added a comment to D61487: [clang-tidy] Make the plugin honor NOLINT.

Thanks Dmitri!

Thu, Jun 6, 6:13 AM · Restricted Project, Restricted Project
nik abandoned D61486: [Basic] Introduce active dummy DiagnosticBuilder.
Thu, Jun 6, 6:12 AM · Restricted Project
nik added a comment to D61486: [Basic] Introduce active dummy DiagnosticBuilder.

Is this patch still needed?

Thu, Jun 6, 6:12 AM · Restricted Project
nik committed rG60e1296a9a36: [clang-tidy] Make the plugin honor NOLINT (authored by nik).
[clang-tidy] Make the plugin honor NOLINT
Thu, Jun 6, 6:11 AM
nik committed rL362702: [clang-tidy] Make the plugin honor NOLINT.
[clang-tidy] Make the plugin honor NOLINT
Thu, Jun 6, 6:11 AM
nik closed D61487: [clang-tidy] Make the plugin honor NOLINT.
Thu, Jun 6, 6:11 AM · Restricted Project, Restricted Project
nik added inline comments to D61487: [clang-tidy] Make the plugin honor NOLINT.
Thu, Jun 6, 1:59 AM · Restricted Project, Restricted Project
nik updated the diff for D61487: [clang-tidy] Make the plugin honor NOLINT.

Addressed inline comments.

Thu, Jun 6, 1:59 AM · Restricted Project, Restricted Project

Wed, Jun 5

Herald added a project to D55391: Don't add unnecessary compiler flags to llvm-config output: Restricted Project.
Wed, Jun 5, 6:36 AM · Restricted Project

Tue, Jun 4

nik added a comment to D48116: [libclang] Allow skipping warnings from all included files.

Ping.

Tue, Jun 4, 2:56 AM · Restricted Project, Restricted Project

Mon, May 27

nik added a comment to D48116: [libclang] Allow skipping warnings from all included files.

Ping.

Mon, May 27, 10:11 AM · Restricted Project, Restricted Project
nik added a comment to D61487: [clang-tidy] Make the plugin honor NOLINT.

Ping :)

Mon, May 27, 10:11 AM · Restricted Project, Restricted Project

Wed, May 22

nik added a comment to D61487: [clang-tidy] Make the plugin honor NOLINT.

As I've commented on, this change is not finished. However, I've addressed the inline comments nevertheless.

Wed, May 22, 7:31 AM · Restricted Project, Restricted Project
nik updated the diff for D61487: [clang-tidy] Make the plugin honor NOLINT.

Addressed comments.

Wed, May 22, 7:31 AM · Restricted Project, Restricted Project

Tue, May 21

nik added a comment to D48116: [libclang] Allow skipping warnings from all included files.

Jan?

Tue, May 21, 2:30 AM · Restricted Project, Restricted Project
nik committed rG2eebf4d939b6: [libclang] visit c++14 lambda capture init expressions (authored by nik).
[libclang] visit c++14 lambda capture init expressions
Tue, May 21, 2:19 AM
nik committed rL361234: [libclang] visit c++14 lambda capture init expressions.
[libclang] visit c++14 lambda capture init expressions
Tue, May 21, 2:19 AM
nik committed rC361234: [libclang] visit c++14 lambda capture init expressions.
[libclang] visit c++14 lambda capture init expressions
Tue, May 21, 2:19 AM
nik closed D60672: [libclang] visit c++14 lambda capture init expressions.
Tue, May 21, 2:19 AM · Restricted Project
nik added a comment to D60672: [libclang] visit c++14 lambda capture init expressions.

Are you sure you have compiled this patch? If I comment out the visit of the InitExpr in CIndex.cpp again, then I get the same failure as you...

Tue, May 21, 1:36 AM · Restricted Project
nik added a comment to D61487: [clang-tidy] Make the plugin honor NOLINT.

Ping.

Tue, May 21, 1:06 AM · Restricted Project, Restricted Project
nik committed rG295c19e948d2: [Preamble] Reuse preamble even if an unsaved file does not exist (authored by nik).
[Preamble] Reuse preamble even if an unsaved file does not exist
Tue, May 21, 12:28 AM
nik committed rL361226: [Preamble] Reuse preamble even if an unsaved file does not exist.
[Preamble] Reuse preamble even if an unsaved file does not exist
Tue, May 21, 12:27 AM
nik committed rC361226: [Preamble] Reuse preamble even if an unsaved file does not exist.
[Preamble] Reuse preamble even if an unsaved file does not exist
Tue, May 21, 12:27 AM
nik closed D41005: Reuse preamble even if an unsaved file does not exist.
Tue, May 21, 12:27 AM · Restricted Project

May 15 2019

nik added a comment to D61487: [clang-tidy] Make the plugin honor NOLINT.

Ping. alexfh?

May 15 2019, 4:41 AM · Restricted Project, Restricted Project

May 10 2019

nik added a comment to D48116: [libclang] Allow skipping warnings from all included files.

Sorry for the pointless ping, haven't seen the inline comments. They are addressed now.

May 10 2019, 7:27 AM · Restricted Project, Restricted Project
nik updated the diff for D48116: [libclang] Allow skipping warnings from all included files.

Addressed inline comments.

May 10 2019, 7:26 AM · Restricted Project, Restricted Project
nik added inline comments to D48116: [libclang] Allow skipping warnings from all included files.
May 10 2019, 7:26 AM · Restricted Project, Restricted Project
nik closed D53866: [Preamble] Stop circular inclusion of main file when building preamble.

Huch, I forgot to add "Differential Revision: <URL>" to the commit message, so I'll close this manually once I know how to add the svn revision number to this. https://llvm.org/docs/Phabricator.html states:

May 10 2019, 7:02 AM · Restricted Project
nik committed rGcfe1ab97d603: [libclang] Forward isInline for NamespaceDecl to libclang (authored by nik).
[libclang] Forward isInline for NamespaceDecl to libclang
May 10 2019, 6:57 AM
nik committed rL360428: [libclang] Forward isInline for NamespaceDecl to libclang.
[libclang] Forward isInline for NamespaceDecl to libclang
May 10 2019, 6:56 AM
nik committed rC360428: [libclang] Forward isInline for NamespaceDecl to libclang.
[libclang] Forward isInline for NamespaceDecl to libclang
May 10 2019, 6:56 AM
nik committed rG3c28a2dc6bdc: [Preamble] Stop circular inclusion of main file when building preamble (authored by nik).
[Preamble] Stop circular inclusion of main file when building preamble
May 10 2019, 3:25 AM
nik committed rC360418: [Preamble] Stop circular inclusion of main file when building preamble.
[Preamble] Stop circular inclusion of main file when building preamble
May 10 2019, 3:23 AM
nik committed rL360418: [Preamble] Stop circular inclusion of main file when building preamble.
[Preamble] Stop circular inclusion of main file when building preamble
May 10 2019, 3:23 AM
nik updated the diff for D53866: [Preamble] Stop circular inclusion of main file when building preamble.

Renamed to err_pp_including_mainfile_in_preamble.

May 10 2019, 3:22 AM · Restricted Project

May 9 2019

nik added inline comments to D53866: [Preamble] Stop circular inclusion of main file when building preamble.
May 9 2019, 7:12 AM · Restricted Project
nik updated the diff for D41005: Reuse preamble even if an unsaved file does not exist.

Addressed inline comments.

May 9 2019, 6:37 AM · Restricted Project
nik updated the diff for D53866: [Preamble] Stop circular inclusion of main file when building preamble.

Moved the MainFile / MainContentCache->OrigEntry check a bit further up, for
consistency with the same test further down in SourceManager::translateFile().

May 9 2019, 5:28 AM · Restricted Project
nik added inline comments to D53866: [Preamble] Stop circular inclusion of main file when building preamble.
May 9 2019, 5:26 AM · Restricted Project

May 8 2019

nik updated the diff for D41005: Reuse preamble even if an unsaved file does not exist.

Minor diff update fixing indentation and removing not needed include.

May 8 2019, 7:19 AM · Restricted Project
nik updated the diff for D53866: [Preamble] Stop circular inclusion of main file when building preamble.

Rebased for current trunk.

May 8 2019, 7:05 AM · Restricted Project
nik added a comment to D60672: [libclang] visit c++14 lambda capture init expressions.

Tests do not pass on current trunk:

May 8 2019, 6:47 AM · Restricted Project
nik committed rG2a647e75c518: [libclang] PR41649: Remove pointless duplicate flag. NFC. (authored by nik).
[libclang] PR41649: Remove pointless duplicate flag. NFC.
May 8 2019, 6:18 AM
nik committed rC360249: [libclang] PR41649: Remove pointless duplicate flag. NFC..
[libclang] PR41649: Remove pointless duplicate flag. NFC.
May 8 2019, 6:18 AM
nik committed rL360249: [libclang] PR41649: Remove pointless duplicate flag. NFC..
[libclang] PR41649: Remove pointless duplicate flag. NFC.
May 8 2019, 6:18 AM
nik updated the summary of D61487: [clang-tidy] Make the plugin honor NOLINT.
May 8 2019, 6:15 AM · Restricted Project, Restricted Project
nik updated the diff for D61487: [clang-tidy] Make the plugin honor NOLINT.

The plugin makes use of ClangTidyDiagnosticConsumer and forwards diagnostics to
the external diagnostic engine.

May 8 2019, 6:13 AM · Restricted Project, Restricted Project

May 7 2019

nik accepted D60678: [libclang] Forward isInline for NamespaceDecl to libclang.

LGTM

May 7 2019, 12:48 AM · Restricted Project
nik added a comment to D60678: [libclang] Forward isInline for NamespaceDecl to libclang.

...and increased CINDEX_VERSION_MINOR.

May 7 2019, 12:48 AM · Restricted Project
nik updated the diff for D60678: [libclang] Forward isInline for NamespaceDecl to libclang.

Adapted c-index-test.c and added function to libclang.exports.

May 7 2019, 12:48 AM · Restricted Project

May 3 2019

nik added a comment to D61487: [clang-tidy] Make the plugin honor NOLINT.

Thanks for the fast comments!

May 3 2019, 5:42 AM · Restricted Project, Restricted Project
nik added a comment to D60678: [libclang] Forward isInline for NamespaceDecl to libclang.

Did you forget to push the change to c-index-test.c?

May 3 2019, 4:40 AM · Restricted Project
nik added a reviewer for D61487: [clang-tidy] Make the plugin honor NOLINT: bkramer.
May 3 2019, 4:03 AM · Restricted Project, Restricted Project
nik added a comment to D61487: [clang-tidy] Make the plugin honor NOLINT.

This one depends on https://reviews.llvm.org/D61486

May 3 2019, 4:03 AM · Restricted Project, Restricted Project
nik added a reviewer for D61486: [Basic] Introduce active dummy DiagnosticBuilder: alexfh.
May 3 2019, 4:03 AM · Restricted Project
nik added a reviewer for D61487: [clang-tidy] Make the plugin honor NOLINT: alexfh.
May 3 2019, 4:03 AM · Restricted Project, Restricted Project
nik created D61487: [clang-tidy] Make the plugin honor NOLINT.
May 3 2019, 4:00 AM · Restricted Project, Restricted Project
nik created D61486: [Basic] Introduce active dummy DiagnosticBuilder.
May 3 2019, 3:58 AM · Restricted Project

Apr 25 2019

nik committed rG2ec51879a745: [NFC] test commit removing excess line (authored by nik).
[NFC] test commit removing excess line
Apr 25 2019, 1:13 AM
nik committed rC359172: [NFC] test commit removing excess line.
[NFC] test commit removing excess line
Apr 25 2019, 1:12 AM
nik committed rL359172: [NFC] test commit removing excess line.
[NFC] test commit removing excess line
Apr 25 2019, 1:12 AM

Apr 18 2019

nik added a comment to D53866: [Preamble] Stop circular inclusion of main file when building preamble.

Ping. Ilya?

Apr 18 2019, 7:06 AM · Restricted Project

Feb 21 2019

nik added a comment to D48116: [libclang] Allow skipping warnings from all included files.

Ping.

Feb 21 2019, 11:27 PM · Restricted Project, Restricted Project
nik added a comment to D41005: Reuse preamble even if an unsaved file does not exist.

Ping.

Feb 21 2019, 11:26 PM · Restricted Project
nik added a comment to D53866: [Preamble] Stop circular inclusion of main file when building preamble.

Ping.

Feb 21 2019, 11:26 PM · Restricted Project
nik updated the diff for D58501: [libclang] Fix CXTranslationUnit_KeepGoing.

Fixed minor typo.

Feb 21 2019, 4:22 AM · Restricted Project, Restricted Project
nik added a reviewer for D58501: [libclang] Fix CXTranslationUnit_KeepGoing: rsmith.
Feb 21 2019, 4:04 AM · Restricted Project, Restricted Project
nik created D58501: [libclang] Fix CXTranslationUnit_KeepGoing.
Feb 21 2019, 4:03 AM · Restricted Project, Restricted Project

Feb 19 2019

nik updated the diff for D48116: [libclang] Allow skipping warnings from all included files.

OK, filtering happens now in FilterAndStoreDiagnosticConsumer, the former
StoredDiagnosticConsumer.

Feb 19 2019, 12:07 AM · Restricted Project, Restricted Project
Herald added a project to D48116: [libclang] Allow skipping warnings from all included files: Restricted Project.

For filtering in StoredDiagnosticConsumer one needs to pass the new bool everywhere along where "bool CaptureDiagnostics" is already passed on (to end up in the StoredDiagnosticConsumer constructor) . Also, ASTUnit::CaptureDiagnostics is then not enough anymore since the new bool is also needed in getMainBufferWithPrecompiledPreamble(). One could also (2) convert "bool CaptureDiagnostics" to an enum with enumerators like CaptureNothing, CaptureAll, CaptureAllWithoutNonErrorsFromIncludes to make this a bit less invasive.
If changing clang's diagnostic interface should be avoided, I tend to go with (2). Ilya?

Yeah, LG. The changes in the ASTUnit look strictly better than changes in clang - the latter seems to already provide enough to do the filtering.
If you avoid changing the StoredDiagnosticConsumer (or writing a filtering wrapper for DiagnosticConsumer), you'll end up having some diagnostics inside headers generated after preamble was built, right?

Feb 19 2019, 12:06 AM · Restricted Project, Restricted Project

Feb 14 2019

nik added a comment to D41005: Reuse preamble even if an unsaved file does not exist.

Ping.

Feb 14 2019, 11:12 PM · Restricted Project
nik added a comment to D53866: [Preamble] Stop circular inclusion of main file when building preamble.

Ping.

Feb 14 2019, 11:11 PM · Restricted Project
nik retitled D53866: [Preamble] Stop circular inclusion of main file when building preamble from [Preamble] Stop generating preamble for circular #includes to [Preamble] Stop circular inclusion of main file when building preamble.
Feb 14 2019, 4:09 AM · Restricted Project
nik added inline comments to D53866: [Preamble] Stop circular inclusion of main file when building preamble.
Feb 14 2019, 4:03 AM · Restricted Project
nik updated the diff for D53866: [Preamble] Stop circular inclusion of main file when building preamble.

Addressed comments.

Feb 14 2019, 3:59 AM · Restricted Project
Herald added a project to D53866: [Preamble] Stop circular inclusion of main file when building preamble: Restricted Project.
Feb 14 2019, 3:59 AM · Restricted Project

Feb 12 2019

nik updated the diff for D41005: Reuse preamble even if an unsaved file does not exist.

Meh, something changed in the meanwhile. ReparseReusesPreambleAfterUnsavedFileWasRemovedFromDisk fails now. Looking into it.

Feb 12 2019, 3:59 AM · Restricted Project
nik added a comment to D41005: Reuse preamble even if an unsaved file does not exist.

Meh, something changed in the meanwhile. ReparseReusesPreambleAfterUnsavedFileWasRemovedFromDisk fails now. Looking into it.

Feb 12 2019, 2:50 AM · Restricted Project
nik updated the diff for D41005: Reuse preamble even if an unsaved file does not exist.

Addressed comment.

Feb 12 2019, 2:37 AM · Restricted Project

Jan 10 2019

nik accepted D54996: [libclang] Fix clang_Cursor_isAnonymous.
Jan 10 2019, 1:18 AM · Restricted Project