- User Since
- May 9 2017, 8:22 AM (83 w, 3 d)
Fri, Dec 7
+1 as this seems to fix the regression.
Thu, Dec 6
Added a dedicated diagnostic.
Wed, Dec 5
Mon, Dec 3
Sun, Dec 2
Please fix this also for libclang clients. I think it's safe to assume that files might be edited once CXTranslationUnit_PrecompiledPreamble or CXTranslationUnit_CacheCompletionResults is set as flag - that's what clang_defaultEditingTranslationUnitOptions() returns.
Mon, Nov 26
Maybe produce a fatal error in the preprocessor? That seems to be the simplest option: the preprocessor is aware it's building the preamble and there's definitely some logic to produce fatal errors in other cases (include not found).
A fatal error currently aborts other stages of the compilation pipeline and producing one would make the run of the compiler that tries to produce the preamble fail, giving the empty preamble as a result.
Fri, Nov 16
I still don't have feedback for a real world case except "unintentional #include". Unfortunately, in real world cases the cyclic include might be not obvious at all.
Nov 14 2018
Nov 12 2018
Nov 6 2018
Coming back to this one, I see a failing test: PCHPreambleTest.ReparseWithOverriddenFileDoesNotInvalidatePreamble
Nov 1 2018
I've only the minimal example at hand right know - I'm waiting for feedback about the real world case.
Oct 31 2018
Oct 30 2018
Jun 13 2018
Jun 6 2018
- Sometimes you refer to "fixits", sometimes "fix-its" and some times "FixIts". Unify to what is already there.
- The term "completion items" is new so far. Use "completions" for consistency.
Jun 1 2018
May 30 2018
I've stumbled about this bug too and was looking into it and then I saw the mail about this change being submitted :)
May 29 2018
Generates build errors here:
May 16 2018
If this is fine now, please submit as I don't have the permissions to do so.
Addressed inline nit.
May 11 2018
May 8 2018
May 7 2018
OK, the issue with the test dependencies I've had is resolved by https://reviews.llvm.org/D46514
I have no permissions to submit, please do this for me.
Moved the test to "Index".
May 3 2018
Do I miss something? I've uploaded a new diff/version and state is still "(X) Requested Changes to Prior Diff".
Apr 27 2018
OK, to skip all function bodies in the preamble except for template functions and functions within a template class, I've amended the previous diff with:
Trying to format the diff in the previous comment:
Reduction to skip-in-preamble-only functionality.
Apr 26 2018
Added a test and clarified scenario in commit message.
Apr 25 2018
only clang-format fixes
Apr 24 2018
Addressed inline comments.
Apr 20 2018
Apr 19 2018
This one still applies and tests pass.
Sorry for the delay, I think I'll come back to this one soon.
@ilya: Using SkipFunctionBodies_AllExceptTemplates for the preamble might be also useful for clangd.
Apr 17 2018
Huch, seems already submitted. Ignore :>
Feb 7 2018
Jan 31 2018
Abandoning since the change is already in.
Jan 19 2018
Hmm, nothing changed. So how to get rid of this correctly. Is "Abandon Revision" the right thing to do?
Jan 16 2018
This was one was already submitted/merged by yvvan. Hmm, this review does not reflect that yet?
I can merge this for you.
Please add me as reviewer in any follow-up patches and we can turn them around more quickly.
Jan 14 2018
Can you submit this for me? I don't have the permissions.
Addressed inline comment.
Jan 12 2018
What about this? :)
Added assert() for getter/setter.
It might be worth adding some very simple get/set tests to ensure that properties are set as intended.
Jan 11 2018
Used macros as in a previous version to make it less verbose and error prone.
Could one use an enum to get/set different properties of the policy?
I've seen other C-API's (for Linear and Quadratic programming) follow a similar approach quite extensibly.
It would significantly reduce the size of the API.
Jan 10 2018
Rebased only, please review.