Page MenuHomePhabricator

yvvan (Ivan Donchevskii)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2017, 5:35 AM (99 w, 3 d)

Recent Activity

Wed, Apr 17

yvvan added reviewers for D53072: [clang-format] Create a new tool for IDEs based on clang-format: Dmitry.Kozhevnikov, ilya-biryukov.
Wed, Apr 17, 12:42 AM

Mon, Apr 15

yvvan added a reviewer for D53072: [clang-format] Create a new tool for IDEs based on clang-format: marcobubke.
Mon, Apr 15, 5:26 AM
yvvan updated subscribers of D60678: [libclang] Forward isInline for NamespaceDecl to libclang.
Mon, Apr 15, 3:03 AM
yvvan created D60678: [libclang] Forward isInline for NamespaceDecl to libclang.
Mon, Apr 15, 3:03 AM

Fri, Apr 12

yvvan updated the diff for D53072: [clang-format] Create a new tool for IDEs based on clang-format.

New approach - title and summary are updated.

Fri, Apr 12, 5:25 AM

Mar 7 2019

yvvan committed rG878271b2945e: [libclang] Fix CXTranslationUnit_KeepGoing (authored by yvvan).
[libclang] Fix CXTranslationUnit_KeepGoing
Mar 7 2019, 2:15 AM
yvvan committed rC355586: [libclang] Fix CXTranslationUnit_KeepGoing.
[libclang] Fix CXTranslationUnit_KeepGoing
Mar 7 2019, 2:14 AM
yvvan committed rL355586: [libclang] Fix CXTranslationUnit_KeepGoing.
[libclang] Fix CXTranslationUnit_KeepGoing
Mar 7 2019, 2:14 AM
yvvan closed D58501: [libclang] Fix CXTranslationUnit_KeepGoing.
Mar 7 2019, 2:14 AM · Restricted Project, Restricted Project

Feb 22 2019

yvvan accepted D58501: [libclang] Fix CXTranslationUnit_KeepGoing.
Feb 22 2019, 2:37 AM · Restricted Project, Restricted Project

Feb 11 2019

yvvan abandoned D57951: [Lex] Allow to set missing include error to not fatal.
Feb 11 2019, 2:12 AM
yvvan planned changes to D57951: [Lex] Allow to set missing include error to not fatal.

It's probably not needed because I don't see a path which checked for the fatal errors in 8.0. So i will probably abandon this one or update if it does not cover the case I need.

Feb 11 2019, 12:30 AM

Feb 8 2019

yvvan added a comment to D57951: [Lex] Allow to set missing include error to not fatal.

I've tested it with libclang. If something else is needed for proper clangd args forwarding - let me know.

Feb 8 2019, 6:48 AM
yvvan created D57951: [Lex] Allow to set missing include error to not fatal.
Feb 8 2019, 6:47 AM

Jan 11 2019

yvvan updated the diff for D53072: [clang-format] Create a new tool for IDEs based on clang-format.

The tests are improved - now they actually act differently with and without the introduced flag. Also few more cases are covered (see the second added test).

Jan 11 2019, 7:48 AM

Jan 10 2019

yvvan committed rC350805: [libclang] Fix clang_Cursor_isAnonymous.
[libclang] Fix clang_Cursor_isAnonymous
Jan 10 2019, 1:40 AM
yvvan committed rL350805: [libclang] Fix clang_Cursor_isAnonymous.
[libclang] Fix clang_Cursor_isAnonymous
Jan 10 2019, 1:39 AM
yvvan closed D54996: [libclang] Fix clang_Cursor_isAnonymous.
Jan 10 2019, 1:39 AM
yvvan updated the diff for D54996: [libclang] Fix clang_Cursor_isAnonymous.

Replace the absolute path with {{.*}} to be independent from the machine.

Jan 10 2019, 1:14 AM

Jan 9 2019

yvvan added a comment to D54996: [libclang] Fix clang_Cursor_isAnonymous.

Good point :)

Jan 9 2019, 11:36 PM

Jan 7 2019

yvvan added a comment to D53072: [clang-format] Create a new tool for IDEs based on clang-format.

@djasper
Ok, if there's a possible way to go forward I will find time to provide a better test which behaves differently depending on this check. Also my current patch is a bit bigger than this version.

Jan 7 2019, 4:50 AM
yvvan added a comment to D53072: [clang-format] Create a new tool for IDEs based on clang-format.
$ cat /tmp/test.cc
int foo(int a,
           int b) {
      f();
  }
 
$ clang-format -style="{ColumnLimit: 0}" /tmp/test.cc
int foo(int a,
        int b) {
  f();
}
 

Is this not what you want? If so, in what way?

Jan 7 2019, 4:42 AM
yvvan added a comment to D53072: [clang-format] Create a new tool for IDEs based on clang-format.

I don't quite understand. What you are describing should already be the behavior with ColumnLimit=0 and I think your test should pass without the new option. Doesn't it?

Jan 7 2019, 3:43 AM

Dec 13 2018

yvvan committed rCTE349132: [clang-tidy] Remove extra config.h includes.
[clang-tidy] Remove extra config.h includes
Dec 13 2018, 11:48 PM
yvvan committed rL349132: [clang-tidy] Remove extra config.h includes.
[clang-tidy] Remove extra config.h includes
Dec 13 2018, 11:48 PM
yvvan added inline comments to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
Dec 13 2018, 11:43 PM · Restricted Project
yvvan committed rCTE349131: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
[clang-tidy] Share the forced linking code between clang-tidy tool and plugin
Dec 13 2018, 11:32 PM
yvvan committed rL349131: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
[clang-tidy] Share the forced linking code between clang-tidy tool and plugin
Dec 13 2018, 11:32 PM
yvvan added inline comments to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
Dec 13 2018, 11:27 PM · Restricted Project
yvvan added inline comments to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
Dec 13 2018, 12:08 PM · Restricted Project
yvvan added inline comments to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
Dec 13 2018, 12:00 PM · Restricted Project
yvvan committed rL349038: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
[clang-tidy] Share the forced linking code between clang-tidy tool and plugin
Dec 13 2018, 6:41 AM
yvvan committed rCTE349038: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
[clang-tidy] Share the forced linking code between clang-tidy tool and plugin
Dec 13 2018, 6:41 AM
yvvan closed D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
Dec 13 2018, 6:41 AM · Restricted Project
yvvan added a comment to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.

One thing: Could you please check the utility-scripts in clang-tidy that create new checks, if they need adjustments? Not sure if we have something in there that relies on the old structure.

Dec 13 2018, 6:18 AM · Restricted Project

Dec 12 2018

yvvan updated the diff for D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.

Add standard prologue to the new header

Dec 12 2018, 3:06 AM · Restricted Project
yvvan updated the diff for D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
Dec 12 2018, 2:22 AM · Restricted Project
yvvan planned changes to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
  1. Please always upload all patches with full context.
  2. There are two places where this pattern exists - this file, and tool/ClangTidyMain.cpp. It clearly leads to such issues, Can this be reworked to be just one file that is simply included in both places?
Dec 12 2018, 1:54 AM · Restricted Project
yvvan created D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
Dec 12 2018, 1:40 AM · Restricted Project

Dec 10 2018

yvvan committed rC348764: [libclang] Revert removal of tidy plugin support from libclang introduced in….
[libclang] Revert removal of tidy plugin support from libclang introduced in…
Dec 10 2018, 8:02 AM
yvvan committed rL348764: [libclang] Revert removal of tidy plugin support from libclang introduced in….
[libclang] Revert removal of tidy plugin support from libclang introduced in…
Dec 10 2018, 8:02 AM
yvvan closed D55415: Revert removal of tidy plugin support from libclang.
Dec 10 2018, 8:02 AM

Dec 7 2018

yvvan added a comment to D55415: Revert removal of tidy plugin support from libclang.

I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it because it slows down builds while not adding value.

Dec 7 2018, 7:15 AM
yvvan added a comment to D55415: Revert removal of tidy plugin support from libclang.

We can also add an extra variable for it if you care about build time

Dec 7 2018, 12:46 AM
yvvan updated the diff for D55415: Revert removal of tidy plugin support from libclang.

I generated the wrong diff. This is the proper one.

Dec 7 2018, 12:17 AM
yvvan created D55415: Revert removal of tidy plugin support from libclang.
Dec 7 2018, 12:16 AM

Dec 4 2018

yvvan abandoned D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

The fact that so many call-sites decide what to do is pretty error-prone.
There was already at least one issue when this flag was not properly set by some of the call-sites.

Dec 4 2018, 1:05 AM

Dec 3 2018

yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

Hm. What about another way around? - We have user include paths (-I) and report them to the filesystem. This means that we have specific paths under which nothing can be mmaped and everything else can be. In particular cases we can also report -isystem there. This is quite the same logic as current isVolatile parameter but is set only once for each path.

Dec 3 2018, 7:34 AM
yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

Ok, no global option.
Why not placing your VolatileFSProvider in clang so that libclang could you it too?

Would be happy to, will need to figure out what to do with PCH and PCM files first. However if we do this on clang level, I believe we should remove the isVolatile flag from the VFS interfaces in the first place.
It would be nice to not loose out on the opportunity to avoid fully loading the PCH files, but that obviously requires passing some flags into the VFS implementation or various hacks (matching on filenames/extensions?) to find out which files are PCHs.
I actually don't know which approach to choose: on one hand, I'd really want to get rid of the isVolatile flag, on the other hand I'd really want to avoid loading large binary files into memory and that requires passing the flags.

Dec 3 2018, 4:09 AM
yvvan planned changes to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

Ok, no global option.
Why not placing your VolatileFSProvider in clang so that libclang could you it too?

Dec 3 2018, 3:37 AM
yvvan added inline comments to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.
Dec 3 2018, 1:34 AM
yvvan updated the diff for D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

Instead of forcing some default value let's give the client an ability to force disabled mmap if one desires.

Dec 3 2018, 1:19 AM

Nov 30 2018

yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

@ilya-biryukov
What do you think about the global settable bool in MemoryBuffer in place of the ifdef from https://reviews.llvm.org/D35200 ? In this case the client on Windows can set it and you're safe that any MemoryBuffer call never mmaps.

Nov 30 2018, 12:54 PM
yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

No success with unmapping. Buffers are hold by PCMCache in Preprocessor (and the same one in ASTReader) and if I clean them then SourceManger crashed sooner or later on some call that gets data from external files.
So far I have no steps to reproduce the lock on user file so I don't currently know if I try something else.

Nov 30 2018, 1:31 AM

Nov 29 2018

yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

I'm currently trying out another suggestion - which unmaps memory buffer caches after ASTUnit's Parse or Reparse and is limited to Windows only.
And my aim currently is not only clangd but any other client as well.

Nov 29 2018, 7:10 AM
yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

According to https://msdn.microsoft.com/en-us/2e9c3174-af48-4fa3-9f6a-fb62b23ed994 - "Unmapping a mapped view of a file invalidates the range occupied by the view in the address space of the process and makes the range available for other allocations".
Also as far as i understand from https://msdn.microsoft.com/en-us/library/ms810613.aspx mapped files can only be edited in other apps as mapped files opened with the same name (OpenFileMapping).

Nov 29 2018, 1:26 AM

Nov 28 2018

yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

To clarify a little bit - i did not write my own simple app but used libclang in qt creator to reproduce the lock and track the issue. This time I hope to go further, collect flags used by clang and make a simple example.

Nov 28 2018, 9:40 AM
yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

I was able to lock files last time with mmap. The Windows API calls are CreateFileMappingW (it's in the Path.inc, line 794) and MapViewOfFile (further down). As far as I remember the second call actually creates the lock and is freed only by UnmapViewOfFile in destructor

Nov 28 2018, 7:53 AM
yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

According to https://stackoverflow.com/a/7414798 (if it's true) we can't prevent locks.

Nov 28 2018, 7:25 AM
yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

"could we figure out the exact cause of the issue?"

Nov 28 2018, 6:54 AM
yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

Hm, probably FileManager can be that adapter since it's in clang

Nov 28 2018, 5:42 AM
yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

I've realized that this patch covers too much stuff outside of clang and I have no idea how bad is to not memory map it.

Nov 28 2018, 5:37 AM
yvvan created D54996: [libclang] Fix clang_Cursor_isAnonymous.
Nov 28 2018, 3:38 AM
yvvan added a comment to D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

I have the reported evidence but didn't yet have time to investigate myself.
This is probably caused by our upgrade to Clang-7 which shows that we can't rely on the aimed fixes like the one I mention (D47460).

Nov 28 2018, 1:38 AM
yvvan updated the diff for D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.

VFS is moved to llvm in 8.0, update the diff

Nov 28 2018, 12:28 AM
yvvan created D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap.
Nov 28 2018, 12:28 AM

Nov 27 2018

yvvan committed rL347654: [libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for….
[libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for…
Nov 27 2018, 4:05 AM
yvvan committed rC347654: [libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for….
[libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for…
Nov 27 2018, 4:05 AM
yvvan closed D54934: [libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for CXXConstructExpr.
Nov 27 2018, 4:05 AM
yvvan created D54934: [libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for CXXConstructExpr.
Nov 27 2018, 1:14 AM

Oct 31 2018

yvvan added a comment to D53866: [Preamble] Stop circular inclusion of main file when building preamble.

@ilya-biryukov
As far as I understand the problem the same thing happens when you are in the header a.h which includes b.h and b.h includes a.h at the same time. So you get this recursion indirectly and very often because that's why include guards are there.

Oct 31 2018, 11:06 AM · Restricted Project

Oct 19 2018

yvvan added a comment to D53072: [clang-format] Create a new tool for IDEs based on clang-format.

Do you know the better way to accomplish my aim than adding an option to libFormat? For example making a dependent library which serves a little different purpose than libFormat itself or something simpler?

Oct 19 2018, 12:36 AM

Oct 10 2018

yvvan created D53072: [clang-format] Create a new tool for IDEs based on clang-format.
Oct 10 2018, 4:35 AM

Sep 21 2018

yvvan committed rL342721: [CodeComplete] Generate completion fix-its for C code as well.
[CodeComplete] Generate completion fix-its for C code as well
Sep 21 2018, 4:25 AM
yvvan committed rC342721: [CodeComplete] Generate completion fix-its for C code as well.
[CodeComplete] Generate completion fix-its for C code as well
Sep 21 2018, 4:25 AM
yvvan closed D52261: [Sema] Generate completion fix-its for C code as well.
Sep 21 2018, 4:25 AM
yvvan updated the diff for D52261: [Sema] Generate completion fix-its for C code as well.

Provide CorrectedBase = Base for C code

Sep 21 2018, 12:22 AM
yvvan added a comment to D52261: [Sema] Generate completion fix-its for C code as well.

You're right actually. The fix is much simpler than I expected :)

Sep 21 2018, 12:16 AM

Sep 19 2018

yvvan added a comment to D52261: [Sema] Generate completion fix-its for C code as well.

I tried that first but did not I find a way just to copy an expression (we basically need the same expr for such case). Do you know how to properly generate a copy of expression or some other way to get the same expression?

Sep 19 2018, 11:11 PM
yvvan updated the diff for D52261: [Sema] Generate completion fix-its for C code as well.

Test is added

Sep 19 2018, 5:59 AM
yvvan created D52261: [Sema] Generate completion fix-its for C code as well.
Sep 19 2018, 5:31 AM

Sep 7 2018

yvvan committed rC341656: [libclang] Return the proper pointee type for 'auto' deduced to pointer.
[libclang] Return the proper pointee type for 'auto' deduced to pointer
Sep 7 2018, 6:25 AM
yvvan committed rL341656: [libclang] Return the proper pointee type for 'auto' deduced to pointer.
[libclang] Return the proper pointee type for 'auto' deduced to pointer
Sep 7 2018, 6:25 AM
yvvan closed D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer.
Sep 7 2018, 6:25 AM

Sep 5 2018

yvvan updated the diff for D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer.

Comments addressed

Sep 5 2018, 11:44 PM

Aug 28 2018

yvvan added a comment to D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer.

You are completely right! Thanks!
I did not think that -test-print-type also checks for the pointee.

Aug 28 2018, 11:15 PM

Aug 26 2018

yvvan created D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer.
Aug 26 2018, 11:42 PM

Aug 23 2018

yvvan committed rC340521: [libclang] Fix cursors for arguments of Subscript and Call operators.
[libclang] Fix cursors for arguments of Subscript and Call operators
Aug 23 2018, 2:49 AM
yvvan committed rL340521: [libclang] Fix cursors for arguments of Subscript and Call operators.
[libclang] Fix cursors for arguments of Subscript and Call operators
Aug 23 2018, 2:49 AM
yvvan closed D40481: [libclang] Fix cursors for arguments of Subscript and Call operators.
Aug 23 2018, 2:48 AM
yvvan accepted D40481: [libclang] Fix cursors for arguments of Subscript and Call operators.

Let's proceed with this one. I really see that it's going to be useful.

Aug 23 2018, 1:11 AM

Jul 31 2018

yvvan added a comment to D49794: [libclang] Allow skipping warnings from all included files.

And we already saw, that -isystem is not the best choice for that.

Are you referring to the file-locking on Windows?
Any other reasons why the -isystem trick might be non-ideal?

File locking is the first one. Another one comes with "plugin mode" of tidy.

Jul 31 2018, 6:50 AM
yvvan added a child revision for D41407: Add index-while-building support to Clang - Part 3: D49009: Add index-while-building support to Clang - non-Apple platforms.
Jul 31 2018, 6:23 AM
yvvan added a parent revision for D49009: Add index-while-building support to Clang - non-Apple platforms: D41407: Add index-while-building support to Clang - Part 3.
Jul 31 2018, 6:23 AM
yvvan added a comment to D49794: [libclang] Allow skipping warnings from all included files.

Anyways, if c++ part does not seem relevant I'm fine if we only have libclang part from D48116.

Jul 31 2018, 6:20 AM
yvvan accepted D49635: [libclang 8/8] Add support for the flag_enum attribute.
Jul 31 2018, 6:13 AM
yvvan accepted D49634: [libclang 7/8] Add support for getting property setter and getter names.
Jul 31 2018, 6:13 AM
yvvan accepted D49631: [libclang 6/8] Add support for reading implicit attributes.
Jul 31 2018, 6:12 AM
yvvan accepted D49127: [libclang 5/8] Add support for ObjC attributes without args.
Jul 31 2018, 6:12 AM
yvvan accepted D49082: [libclang 4/8] Add the clang_Type_getNullability() API.
Jul 31 2018, 6:12 AM