This is an archive of the discontinued LLVM Phabricator instance.

Implement a small subset of the C++ `type_traits` header inside sanitizer_common so we can avoid depending on system C++ headers.
ClosedPublic

Authored by delcypher on Nov 27 2018, 8:08 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Nov 27 2018, 8:08 AM
Herald added subscribers: Restricted Project, mgorny. · View Herald TranscriptNov 27 2018, 8:08 AM

I don't see it in D54904

I don't see it in D54904

It was removed after https://reviews.llvm.org/D54904?id=175500.
Is this patch still necessary?

I don't see it in D54904

It was removed after https://reviews.llvm.org/D54904?id=175500.
Is this patch still necessary?

@cryptoad
I'd like to still land it if possible. I intend to use this in future patches. I removed it from https://reviews.llvm.org/D54904 to simply have less code to review. My intention is to land this and then add the static_assert(...) that I wanted to write original in a future patch.

@cryptoad
I'd like to still land it if possible. I intend to use this in future patches. I removed it from https://reviews.llvm.org/D54904 to simply have less code to review. My intention is to land this and then add the static_assert(...) that I wanted to write original in a future patch.

Then we can review it with dependent patch?
There is probability that dependent patch will be changed during review or other reasons and we stuck with small but unused piece of code.

@cryptoad
I'd like to still land it if possible. I intend to use this in future patches. I removed it from https://reviews.llvm.org/D54904 to simply have less code to review. My intention is to land this and then add the static_assert(...) that I wanted to write original in a future patch.

Then we can review it with dependent patch?
There is probability that dependent patch will be changed during review or other reasons and we stuck with small but unused piece of code.

Okay. I'll merge this patch back into https://reviews.llvm.org/D54904?id=175500

delcypher abandoned this revision.Dec 10 2018, 1:39 PM
vitalybuka added a comment.EditedDec 10 2018, 1:56 PM

the last snapshot of D54904 has no references to is_same
However if D54904 (or other in the stack) has static_assert, then this patch LGTM

delcypher reclaimed this revision.Dec 10 2018, 3:15 PM

Oops. Sorry I misinterpreted what you meant. I'm reclaiming this revision.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2018, 11:59 AM
This revision was automatically updated to reflect the committed changes.