This is an archive of the discontinued LLVM Phabricator instance.

Differential D54255

[MIPS GlobalISel] narrowScalar G_CONSTANT
ClosedPublic

Authored by Petar.Avramovic on Nov 8 2018, 3:43 AM.

Details

Reviewers
atanasyan
petarj
dsanders
Commits
rG2cefaa274740: [MIPS GlobalISel] narrowScalar G_CONSTANT
rL346495: [MIPS GlobalISel] narrowScalar G_CONSTANT
Summary

Legalize s64 G_CONSTANT using narrowScalar on MIPS 32.

Diff Detail

Event Timeline

Petar.Avramovic created this revision.Nov 8 2018, 3:43 AM
Herald added subscribers: arichardson, kristof.beyls, rovka, sdardis. · View Herald TranscriptNov 8 2018, 3:43 AM
dsanders accepted this revision.Nov 8 2018, 8:33 AM

LGTM

This revision is now accepted and ready to land.Nov 8 2018, 8:33 AM
Closed by commit rL346495: [MIPS GlobalISel] narrowScalar G_CONSTANT (authored by Petar.Avramovic). · Explain WhyNov 9 2018, 6:24 AM
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: llvm-commits, jrtc27. · View Herald TranscriptNov 9 2018, 6:24 AM

Revision Contents

PathSize
lib/
Target/
Mips/
24 lines

Diff 173140

lib/Target/Mips/MipsLegalizerInfo.cpp

Show All 35 Lines getActionDefinitionsBuilder({G_AND, G_OR, G_XOR, G_SHL, G_ASHR, G_LSHR})
.legalFor({s32}); .legalFor({s32});
getActionDefinitionsBuilder(G_ICMP) getActionDefinitionsBuilder(G_ICMP)
.legalFor({{s32, s32}}) .legalFor({{s32, s32}})
.minScalar(0, s32); .minScalar(0, s32);
getActionDefinitionsBuilder(G_CONSTANT) getActionDefinitionsBuilder(G_CONSTANT)
.legalFor({s32}) .legalFor({s32})
.minScalar(0, s32) .clampScalar(0, s32, s32);
.customFor({s64});
getActionDefinitionsBuilder(G_GEP) getActionDefinitionsBuilder(G_GEP)
.legalFor({{p0, s32}}); .legalFor({{p0, s32}});
getActionDefinitionsBuilder(G_FRAME_INDEX) getActionDefinitionsBuilder(G_FRAME_INDEX)
.legalFor({p0}); .legalFor({p0});
getActionDefinitionsBuilder(G_GLOBAL_VALUE) getActionDefinitionsBuilder(G_GLOBAL_VALUE)
Show All 34 Lines case G_ADD: {
MIRBuilder.buildICmp(CmpInst::ICMP_ULT, Carry, ResLow, LHSLow); MIRBuilder.buildICmp(CmpInst::ICMP_ULT, Carry, ResLow, LHSLow);
MIRBuilder.buildAdd(ResHigh, TmpResHigh, Carry); MIRBuilder.buildAdd(ResHigh, TmpResHigh, Carry);
MIRBuilder.buildMerge(MI.getOperand(0).getReg(), {ResLow, ResHigh}); MIRBuilder.buildMerge(MI.getOperand(0).getReg(), {ResLow, ResHigh});
MI.eraseFromParent(); MI.eraseFromParent();
break; break;
} }
case G_CONSTANT: {
unsigned Size = MRI.getType(MI.getOperand(0).getReg()).getSizeInBits();
const LLT sHalf = LLT::scalar(Size / 2);
const APInt &CImmValue = MI.getOperand(1).getCImm()->getValue();
unsigned ResLow = MRI.createGenericVirtualRegister(sHalf);
unsigned ResHigh = MRI.createGenericVirtualRegister(sHalf);
MIRBuilder.buildConstant(
ResLow, *ConstantInt::get(MI.getMF()->getFunction().getContext(),
CImmValue.trunc(Size / 2)));
MIRBuilder.buildConstant(
ResHigh, *ConstantInt::get(MI.getMF()->getFunction().getContext(),
CImmValue.lshr(Size / 2).trunc(Size / 2)));
MIRBuilder.buildMerge(MI.getOperand(0).getReg(), {ResLow, ResHigh});
MI.eraseFromParent();
break;
}
default: default:
return false; return false;
} }
return true; return true;
} }