Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Ping. This patch is the next in the series of patches to finish the proper error handling (i.e. using Error and Expected<T>). Please see the "Stack" column above.
This patch is the next in the series of patches to finish the proper error handling (i.e. using Error and Expected<T>). Please see the "Stack" column above.
@balazske Or is it superseded by this one? https://reviews.llvm.org/D53818
This is the next part of the changes for error handling. D53818 was for ASTImporter functions only, this is for ASTNodeImporter (the Import_New functions are not used at many places directly because mostly the few import templates are used). The next part is D55049 which switches to Import_New in every other place (in clang source code only). Next part would be to use Import_New in lldb, then rename all Import_New to Import (and remove old Import).
@shafik, @a_sidorin Ping. Could you please take a look?
Guys, this and its child patch are very important patches, because without it the error handling of ASTImporter is not completed. This means we may encounter a nullptr DeclContext in the middle of the import process, etc...
lib/AST/ASTImporter.cpp | ||
---|---|---|
3418 ↗ | (On Diff #189824) | Why is this section of code removed? |
Hi Balasz,
Sorry, I missed the review accidentally. Thank you for the patch!
lib/AST/ASTImporter.cpp | ||
---|---|---|
3418 ↗ | (On Diff #189824) | I guess the reason is that this import is already done inside GetImportedOrCreateDecl(). |
lib/AST/ASTImporter.cpp | ||
---|---|---|
3418 ↗ | (On Diff #189824) | You are right: This is done in InitializeImportedDecl that is called from GetImportedOrCreateDecl. |