This is an archive of the discontinued LLVM Phabricator instance.

Differential D52858

[WebAssembly] saturating arithmetic builtins
ClosedPublic

Authored by tlively on Oct 3 2018, 6:36 PM.

Details

Reviewers
aheejin
dschuff
Commits
rG9034a47e79fa: [WebAssembly] saturating arithmetic builtins
rC343836: [WebAssembly] saturating arithmetic builtins
rL343836: [WebAssembly] saturating arithmetic builtins
Summary

Depends on D52856.

Diff Detail

Event Timeline

tlively created this revision.Oct 3 2018, 6:36 PM
Herald added subscribers: cfe-commits, kristina, sunfish and 2 others. · View Herald TranscriptOct 3 2018, 6:36 PM
tlively added a parent revision: D52813: [WebAssembly] Saturating arithmetic intrinsics.Oct 3 2018, 6:37 PM
tlively updated this revision to Diff 168224.Oct 3 2018, 8:52 PM
  • Rebase
Harbormaster completed remote builds in B23438: Diff 168224.Oct 3 2018, 8:54 PM
craig.topper added a subscriber: craig.topper.Oct 3 2018, 9:04 PM
craig.topper added inline comments.
include/clang/Basic/BuiltinsWebAssembly.def
59

Don't copy the "V:128:" part from X86. You just need the "nc". The V:128: is a special thing I'm working on for our AVX512 frequency issues.

tlively added inline comments.Oct 4 2018, 2:33 PM
include/clang/Basic/BuiltinsWebAssembly.def
59

ok, sounds good

tlively updated this revision to Diff 168388.Oct 4 2018, 3:04 PM
  • Remove V:128: attributes
Harbormaster completed remote builds in B23483: Diff 168388.Oct 4 2018, 3:06 PM
tlively added a child revision: D52910: [WebAssembly] any_true and all_true builtins.Oct 4 2018, 3:29 PM
aheejin accepted this revision.Oct 4 2018, 5:01 PM
This revision is now accepted and ready to land.Oct 4 2018, 5:01 PM
Closed by commit rL343836: [WebAssembly] saturating arithmetic builtins (authored by tlively). · Explain WhyOct 4 2018, 6:00 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 4 2018, 6:00 PM

Revision Contents

PathSize
include/
clang/
Basic/
10 lines
lib/
CodeGen/
34 lines
test/
CodeGen/
56 lines

Diff 168224

include/clang/Basic/BuiltinsWebAssembly.def

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines
BUILTIN(__builtin_wasm_replace_lane_i8x16, "V16cV16cIii", "ncV:128:") BUILTIN(__builtin_wasm_replace_lane_i8x16, "V16cV16cIii", "ncV:128:")
BUILTIN(__builtin_wasm_replace_lane_i16x8, "V8sV8sIii", "ncV:128:") BUILTIN(__builtin_wasm_replace_lane_i16x8, "V8sV8sIii", "ncV:128:")
BUILTIN(__builtin_wasm_replace_lane_i32x4, "V4iV4iIii", "ncV:128:") BUILTIN(__builtin_wasm_replace_lane_i32x4, "V4iV4iIii", "ncV:128:")
BUILTIN(__builtin_wasm_replace_lane_i64x2, "V2WiV2WiIiWi", "ncV:128:") BUILTIN(__builtin_wasm_replace_lane_i64x2, "V2WiV2WiIiWi", "ncV:128:")
BUILTIN(__builtin_wasm_replace_lane_f32x4, "V4fV4fIif", "ncV:128:") BUILTIN(__builtin_wasm_replace_lane_f32x4, "V4fV4fIif", "ncV:128:")
BUILTIN(__builtin_wasm_replace_lane_f64x2, "V2dV2dIid", "ncV:128:") BUILTIN(__builtin_wasm_replace_lane_f64x2, "V2dV2dIid", "ncV:128:")
BUILTIN(__builtin_wasm_add_saturate_s_i8x16, "V16cV16cV16c", "ncV:128:")
craig.topperUnsubmitted
Not Done
ReplyInline Actions

Don't copy the "V:128:" part from X86. You just need the "nc". The V:128: is a special thing I'm working on for our AVX512 frequency issues.

craig.topper: Don't copy the "V:128:" part from X86. You just need the "nc". The V:128: is a special thing…
tlivelyAuthorUnsubmitted
Not Done
ReplyInline Actions

ok, sounds good

tlively: ok, sounds good
BUILTIN(__builtin_wasm_add_saturate_u_i8x16, "V16cV16cV16c", "ncV:128:")
BUILTIN(__builtin_wasm_add_saturate_s_i16x8, "V8sV8sV8s", "ncV:128:")
BUILTIN(__builtin_wasm_add_saturate_u_i16x8, "V8sV8sV8s", "ncV:128:")
BUILTIN(__builtin_wasm_sub_saturate_s_i8x16, "V16cV16cV16c", "ncV:128:")
BUILTIN(__builtin_wasm_sub_saturate_u_i8x16, "V16cV16cV16c", "ncV:128:")
BUILTIN(__builtin_wasm_sub_saturate_s_i16x8, "V8sV8sV8s", "ncV:128:")
BUILTIN(__builtin_wasm_sub_saturate_u_i16x8, "V8sV8sV8s", "ncV:128:")
#undef BUILTIN #undef BUILTIN

lib/CodeGen/CGBuiltin.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 12,479 Lines • ▼ Show 20 Lines case WebAssembly::BI__builtin_wasm_replace_lane_f64x2: {
case WebAssembly::BI__builtin_wasm_replace_lane_i64x2: case WebAssembly::BI__builtin_wasm_replace_lane_i64x2:
case WebAssembly::BI__builtin_wasm_replace_lane_f32x4: case WebAssembly::BI__builtin_wasm_replace_lane_f32x4:
case WebAssembly::BI__builtin_wasm_replace_lane_f64x2: case WebAssembly::BI__builtin_wasm_replace_lane_f64x2:
return Builder.CreateInsertElement(Vec, Val, Lane); return Builder.CreateInsertElement(Vec, Val, Lane);
default: default:
llvm_unreachable("unexpected builtin ID"); llvm_unreachable("unexpected builtin ID");
} }
} }
case WebAssembly::BI__builtin_wasm_add_saturate_s_i8x16:
case WebAssembly::BI__builtin_wasm_add_saturate_u_i8x16:
case WebAssembly::BI__builtin_wasm_add_saturate_s_i16x8:
case WebAssembly::BI__builtin_wasm_add_saturate_u_i16x8:
case WebAssembly::BI__builtin_wasm_sub_saturate_s_i8x16:
case WebAssembly::BI__builtin_wasm_sub_saturate_u_i8x16:
case WebAssembly::BI__builtin_wasm_sub_saturate_s_i16x8:
case WebAssembly::BI__builtin_wasm_sub_saturate_u_i16x8: {
unsigned IntNo;
switch (BuiltinID) {
case WebAssembly::BI__builtin_wasm_add_saturate_s_i8x16:
case WebAssembly::BI__builtin_wasm_add_saturate_s_i16x8:
IntNo = Intrinsic::wasm_add_saturate_signed;
break;
case WebAssembly::BI__builtin_wasm_add_saturate_u_i8x16:
case WebAssembly::BI__builtin_wasm_add_saturate_u_i16x8:
IntNo = Intrinsic::wasm_add_saturate_unsigned;
break;
case WebAssembly::BI__builtin_wasm_sub_saturate_s_i8x16:
case WebAssembly::BI__builtin_wasm_sub_saturate_s_i16x8:
IntNo = Intrinsic::wasm_sub_saturate_signed;
break;
case WebAssembly::BI__builtin_wasm_sub_saturate_u_i8x16:
case WebAssembly::BI__builtin_wasm_sub_saturate_u_i16x8:
IntNo = Intrinsic::wasm_sub_saturate_unsigned;
break;
default:
llvm_unreachable("unexpected builtin ID");
}
Value *LHS = EmitScalarExpr(E->getArg(0));
Value *RHS = EmitScalarExpr(E->getArg(1));
Value *Callee = CGM.getIntrinsic(IntNo, ConvertType(E->getType()));
return Builder.CreateCall(Callee, {LHS, RHS});
}
default: default:
return nullptr; return nullptr;
} }
} }
Value *CodeGenFunction::EmitHexagonBuiltinExpr(unsigned BuiltinID, Value *CodeGenFunction::EmitHexagonBuiltinExpr(unsigned BuiltinID,
const CallExpr *E) { const CallExpr *E) {
▲ Show 20 Lines • Show All 197 Lines • Show Last 20 Lines

test/CodeGen/builtins-wasm.c

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Linesf32x4 f23(f32x4 v, float x) {
// WEBASSEMBLY-NEXT: ret // WEBASSEMBLY-NEXT: ret
} }
f64x2 f24(f64x2 v, double x) { f64x2 f24(f64x2 v, double x) {
return __builtin_wasm_replace_lane_f64x2(v, 1, x); return __builtin_wasm_replace_lane_f64x2(v, 1, x);
// WEBASSEMBLY: insertelement <2 x double> %v, double %x, i32 1 // WEBASSEMBLY: insertelement <2 x double> %v, double %x, i32 1
// WEBASSEMBLY-NEXT: ret // WEBASSEMBLY-NEXT: ret
} }
i8x16 f25(i8x16 x, i8x16 y) {
return __builtin_wasm_add_saturate_s_i8x16(x, y);
// WEBASSEMBLY: call <16 x i8> @llvm.wasm.add.saturate.signed.v16i8(
// WEBASSEMBLY-SAME: <16 x i8> %x, <16 x i8> %y)
// WEBASSEMBLY-NEXT: ret
}
i8x16 f26(i8x16 x, i8x16 y) {
return __builtin_wasm_add_saturate_u_i8x16(x, y);
// WEBASSEMBLY: call <16 x i8> @llvm.wasm.add.saturate.unsigned.v16i8(
// WEBASSEMBLY-SAME: <16 x i8> %x, <16 x i8> %y)
// WEBASSEMBLY-NEXT: ret
}
i16x8 f27(i16x8 x, i16x8 y) {
return __builtin_wasm_add_saturate_s_i16x8(x, y);
// WEBASSEMBLY: call <8 x i16> @llvm.wasm.add.saturate.signed.v8i16(
// WEBASSEMBLY-SAME: <8 x i16> %x, <8 x i16> %y)
// WEBASSEMBLY-NEXT: ret
}
i16x8 f28(i16x8 x, i16x8 y) {
return __builtin_wasm_add_saturate_u_i16x8(x, y);
// WEBASSEMBLY: call <8 x i16> @llvm.wasm.add.saturate.unsigned.v8i16(
// WEBASSEMBLY-SAME: <8 x i16> %x, <8 x i16> %y)
// WEBASSEMBLY-NEXT: ret
}
i8x16 f29(i8x16 x, i8x16 y) {
return __builtin_wasm_sub_saturate_s_i8x16(x, y);
// WEBASSEMBLY: call <16 x i8> @llvm.wasm.sub.saturate.signed.v16i8(
// WEBASSEMBLY-SAME: <16 x i8> %x, <16 x i8> %y)
// WEBASSEMBLY-NEXT: ret
}
i8x16 f30(i8x16 x, i8x16 y) {
return __builtin_wasm_sub_saturate_u_i8x16(x, y);
// WEBASSEMBLY: call <16 x i8> @llvm.wasm.sub.saturate.unsigned.v16i8(
// WEBASSEMBLY-SAME: <16 x i8> %x, <16 x i8> %y)
// WEBASSEMBLY-NEXT: ret
}
i16x8 f31(i16x8 x, i16x8 y) {
return __builtin_wasm_sub_saturate_s_i16x8(x, y);
// WEBASSEMBLY: call <8 x i16> @llvm.wasm.sub.saturate.signed.v8i16(
// WEBASSEMBLY-SAME: <8 x i16> %x, <8 x i16> %y)
// WEBASSEMBLY-NEXT: ret
}
i16x8 f32(i16x8 x, i16x8 y) {
return __builtin_wasm_sub_saturate_u_i16x8(x, y);
// WEBASSEMBLY: call <8 x i16> @llvm.wasm.sub.saturate.unsigned.v8i16(
// WEBASSEMBLY-SAME: <8 x i16> %x, <8 x i16> %y)
// WEBASSEMBLY-NEXT: ret
}