Depends on D52805.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
| lib/Target/WebAssembly/WebAssemblyISelLowering.cpp | ||
|---|---|---|
| 987 ↗ | (On Diff #168058) | Newline here? :3 |
| test/CodeGen/WebAssembly/simd-arith.ll | ||
|---|---|---|
| 6 ↗ | (On Diff #168166) | Do we need both the slow and fast versions for NO-SIMD128 too? Aren't they the same anyway? |
| test/CodeGen/WebAssembly/simd-arith.ll | ||
|---|---|---|
| 6 ↗ | (On Diff #168166) | Oh what I meant is... do we need to test both with and without fastisel for NO-SIMD128? With NO-SIMD128 we are just testing the pre-existing scalar expansion behavior and checking the SIMD instructions do not kick in. |
| test/CodeGen/WebAssembly/simd-arith.ll | ||
|---|---|---|
| 6 ↗ | (On Diff #168166) | Sounds like fast isel is responsible for complying with architecture features itself, so we still need this test. |